HADOOP-19605. Upgrade Protobuf 3.25.5 for docker images #7780
+134
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(!) A patch to the testing environment has been detected. |
pan3793
commented
Jul 7, 2025
| make install && | ||
| cmake -S . -B build -Dprotobuf_BUILD_TESTS=OFF && | ||
| cmake --build build --parallel $(nproc) && | ||
| cmake --install build --prefix /opt/protobuf && |
There was a problem hiding this comment.
protocolbuffers/protobuf#10132 (since protobuf 3.22.0) removes autotools support, the supported toolchains are bazel and cmake.
pan3793
commented
Jul 7, 2025
| { | ||
| "name": "protobuf", | ||
| "version": "3.21.12" | ||
| "version": "3.25.5" |
There was a problem hiding this comment.
I suppose this works, but I don't have Windows env to verify this.
There was a problem hiding this comment.
Thanks for PR @pan3793. Please let me know once you're done with all the changes and I can verify it on Windows.
There was a problem hiding this comment.
@GauthamBanasandra Now it passes on all Linux containers. Due to my limited CPP experience, my change might be dirty ...
There was a problem hiding this comment.
@GauthamBanasandra do you remember why we should install libprotobuf-dev and libprotoc-dev through APT? seems we can remove it and always use the manually installed protobuf instead?
|
💔 -1 overall
This message was automatically generated. |
pan3793
commented
Jul 7, 2025
| tar xzf /opt/protobuf.tar.gz --strip-components 1 -C /opt/protobuf-src && | ||
| mkdir -p /opt/abseil-cpp-src && | ||
| curl -L -s -S \ | ||
| https://github.com/abseil/abseil-cpp/archive/refs/tags/20230802.1.tar.gz \ |
There was a problem hiding this comment.
recent protobuf versions have hard dependency on abseil, the version is defined at
https://github.com/protocolbuffers/protobuf/blob/v3.25.5/protobuf_deps.bzl#L46
|
(!) A patch to the testing environment has been detected. |
pan3793
commented
Jul 7, 2025
| $ cmake -S . -B build -Dprotobuf_BUILD_TESTS=OFF | ||
| $ cmake --build build --parallel $(nproc) | ||
| $ cmake --install build | ||
| $ protoc --version |
There was a problem hiding this comment.
now it returns 25.5 (seems protobuf changed version policy recently)
chengpan@a1847ca27697:~/hadoop$ protoc --version
libprotoc 25.5
|
💔 -1 overall
This message was automatically generated. |
|
CentOS 7 CI failure caused by GLIBC version too low, which is already tracked by YARN-11794 and HADOOP-19489 Update: CentOS 7 was removed from trunk. |
|
hadoop-hdfs-native-client building fails, further fix is required. convert to draft now, will investigate later Update: I fixed it |
pan3793
force-pushed
the
HADOOP-19605
branch
from
1be1417 to
eb4b43e
Compare
|
(!) A patch to the testing environment has been detected. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
pan3793
force-pushed
the
HADOOP-19605
branch
from
79886df to
8434cdd
Compare
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
pan3793
force-pushed
the
HADOOP-19605
branch
from
8434cdd to
cf6a61b
Compare
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
HADOOP-19289 upgraded protobuf-java 3.25.5, we should use same version for protobuf installed in docker images.
How was this patch tested?
Changes are covered by CI, also manually tested in local
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?