-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-18562: Correct compilation error after S3A custom S3/STS header changes #7750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@adideshpande , @ahmarsuhail , @steveloughran , can you please review? Thank you. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cnauroth, LGTM.
missed this conversation...just did the #7751 PR with what looks like the same change as you, and same manual test. Merged that, so this is obsolete. (I know, I didn't wait for a review, but things were broken and the alternative option was to revert). If I'd seen this PR I would have merged it. |
No worries, thanks Steve. |
Description of PR
It looks like changes in #7379 introduced a compilation error in the tests. This patch fixes the compilation error.
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?