Skip to content

HADOOP-19406. ABFS: [Backport to 3.4][FNSOverBlob] Support User Delegation SAS for FNS Blob #7649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

HADOOP-19406. ABFS: [Backport to 3.4][FNSOverBlob] Support User Delegation SAS for FNS Blob #7649

merged 1 commit into from
Apr 25, 2025

Conversation

@manika137
Copy link
Contributor

Description of PR

Cherry-picked commit: 10cbe27
PR merged in trunk: #7523
JIRA: https://issues.apache.org/jira/browse/HADOOP-19406
In ABFS Driver, user delegation SAS is currently only supported by hierarchical namespace (HNS) enabled accounts (over DFS endpoint). This PR adds support for User Delegation SAS for non-HNS accounts over Blob endpoint as well.

How was this patch tested?

Test suite was run. Results added in comments below.

@manika137
HADOOP-19406. ABFS: [FNSOverBlob] Support User Delegation SAS for FNS…
e392420 
… Blob (apache#7523)

Contributed by Manika Joshi
Reviewed by Anmol Asrani, Manish Bhatt, Anuj Modi

Signed off by Anuj Modi<[email protected]>
@manika137
Copy link
Contributor Author

Test Suite Results

============================================================
HNS-OAuth-DFS

[WARNING] Tests run: 175, Failures: 0, Errors: 0, Skipped: 3
[WARNING] Tests run: 823, Failures: 0, Errors: 0, Skipped: 175
[WARNING] Tests run: 181, Failures: 0, Errors: 0, Skipped: 31
[WARNING] Tests run: 272, Failures: 0, Errors: 0, Skipped: 23

============================================================
HNS-SharedKey-DFS

[WARNING] Tests run: 175, Failures: 0, Errors: 0, Skipped: 4
[WARNING] Tests run: 823, Failures: 0, Errors: 0, Skipped: 140
[WARNING] Tests run: 181, Failures: 0, Errors: 0, Skipped: 31
[WARNING] Tests run: 272, Failures: 0, Errors: 0, Skipped: 10

============================================================
NonHNS-SharedKey-DFS

[WARNING] Tests run: 175, Failures: 0, Errors: 0, Skipped: 10
[WARNING] Tests run: 807, Failures: 0, Errors: 0, Skipped: 375
[WARNING] Tests run: 181, Failures: 0, Errors: 0, Skipped: 32
[WARNING] Tests run: 272, Failures: 0, Errors: 0, Skipped: 11

============================================================
AppendBlob-HNS-OAuth-DFS

[WARNING] Tests run: 175, Failures: 0, Errors: 0, Skipped: 3
[WARNING] Tests run: 823, Failures: 0, Errors: 0, Skipped: 186
[WARNING] Tests run: 181, Failures: 0, Errors: 0, Skipped: 55
[WARNING] Tests run: 272, Failures: 0, Errors: 0, Skipped: 23

============================================================
NonHNS-SharedKey-Blob

[WARNING] Tests run: 175, Failures: 0, Errors: 0, Skipped: 10
[WARNING] Tests run: 807, Failures: 0, Errors: 0, Skipped: 295
[WARNING] Tests run: 181, Failures: 0, Errors: 0, Skipped: 27
[WARNING] Tests run: 272, Failures: 0, Errors: 0, Skipped: 11

============================================================
NonHNS-OAuth-DFS

[WARNING] Tests run: 175, Failures: 0, Errors: 0, Skipped: 10
[WARNING] Tests run: 807, Failures: 0, Errors: 0, Skipped: 380
[WARNING] Tests run: 181, Failures: 0, Errors: 0, Skipped: 32
[WARNING] Tests run: 272, Failures: 0, Errors: 0, Skipped: 24

============================================================
NonHNS-OAuth-Blob

[WARNING] Tests run: 175, Failures: 0, Errors: 0, Skipped: 10
[WARNING] Tests run: 807, Failures: 0, Errors: 0, Skipped: 300
[WARNING] Tests run: 181, Failures: 0, Errors: 0, Skipped: 27
[WARNING] Tests run: 272, Failures: 0, Errors: 0, Skipped: 24

============================================================
AppendBlob-NonHNS-OAuth-Blob

[WARNING] Tests run: 175, Failures: 0, Errors: 0, Skipped: 10
[WARNING] Tests run: 807, Failures: 0, Errors: 0, Skipped: 320
[WARNING] Tests run: 181, Failures: 0, Errors: 0, Skipped: 51
[WARNING] Tests run: 272, Failures: 0, Errors: 0, Skipped: 24

============================================================
HNS-Oauth-DFS-IngressBlob

[WARNING] Tests run: 175, Failures: 0, Errors: 0, Skipped: 3
[WARNING] Tests run: 823, Failures: 0, Errors: 0, Skipped: 308
[WARNING] Tests run: 181, Failures: 0, Errors: 0, Skipped: 31
[WARNING] Tests run: 272, Failures: 0, Errors: 0, Skipped: 23

============================================================
NonHNS-OAuth-DFS-IngressBlob

[WARNING] Tests run: 175, Failures: 0, Errors: 0, Skipped: 10
[WARNING] Tests run: 807, Failures: 0, Errors: 0, Skipped: 378
[WARNING] Tests run: 181, Failures: 0, Errors: 0, Skipped: 32
[WARNING] Tests run: 272, Failures: 0, Errors: 0, Skipped: 24

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 22s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ branch-3.4 Compile Tests _
+1 💚 mvninstall 22m 46s branch-3.4 passed
+1 💚 compile 0m 24s branch-3.4 passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 compile 0m 22s branch-3.4 passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚 checkstyle 0m 22s branch-3.4 passed
+1 💚 mvnsite 0m 27s branch-3.4 passed
+1 💚 javadoc 0m 27s branch-3.4 passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 javadoc 0m 24s branch-3.4 passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚 spotbugs 0m 43s branch-3.4 passed
+1 💚 shadedclient 18m 54s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 20s the patch passed
+1 💚 compile 0m 19s the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 javac 0m 19s the patch passed
+1 💚 compile 0m 16s the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚 javac 0m 16s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 13s hadoop-tools/hadoop-azure: The patch generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2)
+1 💚 mvnsite 0m 20s the patch passed
+1 💚 javadoc 0m 17s the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 javadoc 0m 18s the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚 spotbugs 0m 42s the patch passed
+1 💚 shadedclient 18m 56s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 2m 3s hadoop-azure in the patch passed.
+1 💚 asflicense 0m 25s The patch does not generate ASF License warnings.
70m 6s
Subsystem Report/Notes
Docker ClientAPI=1.49 ServerAPI=1.49 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7649/1/artifact/out/Dockerfile
GITHUB PR #7649
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint
uname Linux 0fc27e5e47b2 5.15.0-136-generic #147-Ubuntu SMP Sat Mar 15 15:53:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.4 / e392420
Default Java Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7649/1/testReport/
Max. process+thread count 621 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7649/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@anujmodi2021 anujmodi2021 merged commit 24ce3c4 into apache:branch-3.4 Apr 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@manika137 @hadoop-yetus @anujmodi2021