-
Notifications
You must be signed in to change notification settings - Fork 9.1k
Revert "YARN-11765. Refactor: Move Clock Class from hadoop-mapreduce-project to hadoop-common-project for Reusability (#7352) Contributed by Jiandan Yang." #7599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…project to hadoop-common-project for Reusability (apache#7352) Contributed by Jiandan Yang." This reverts commit 49d4c73.
@pan3793 Thank you for your contribution! From my perspective, I believe we should minimize changes to multiple modules, so this PR seems reasonable to me. @yangjiandan , could you please take a look at this PR? |
💔 -1 overall
This message was automatically generated. |
Hi @pan3793 @slfan1989 , I don’t think we need to revert YARN-11765. First, the same concern was raised by @cnauroth in this comment before. As I mentioned in my earlier comment, our plan is to temporarily copy the clock-related classes into the hadoop-common project and remove the duplicates in a future major release. Second, although due to design changes HADOOP-19447 no longer depends on YARN-11765, it still makes sense to have the clock-related classes in hadoop-common, as they are potentially useful across multiple Hadoop subprojects. |
@yangjiandan compatibility concerns are not the interface itself, it's about the reference. as I mentioned in the PR description,
when required, you can introduce new interfaces in hadoop-common or just use |
💔 -1 overall
This message was automatically generated. |
Replacing the Clock interface with java.time.Clock could be a significantly larger change. |
@pan3793 @yangjiandan Thank you for your discussion! If there are no other comments, I will merge this PR in 1 day. |
@yangjiandan I've initially done most of the |
Description of PR
This reverts commit 49d4c73, because it breaks some public API, for example,
org.apache.hadoop.yarn.server.resourcemanager.reservation.PlanFollower
The initial design of HADOOP-19447 requires YARN-11765 as a premise, but eventually, HADOOP-19447 chooses a different approach that does not require YARN-11765.
How was this patch tested?
Pass UT.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?