HDFS-17766. [ARR] Avoid initializing unused threadPool in RouterAsyncRpcClient. #7561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @KeeProMise @Hexiaoqiao . Could you please help review this simple changes when have free time? Thanks a lot! |
|
💔 -1 overall
This message was automatically generated. |
hfutatzhanghb
force-pushed
the
HDFS-17766
branch
from
fe5b01f to
c6db077
Compare
KeeProMise
reviewed
Apr 1, 2025
| } else { | ||
| this.executorService = new ThreadPoolExecutor(numThreads, numThreads, | ||
| 0L, TimeUnit.MILLISECONDS, workQueue, threadFactory); | ||
| } |
There was a problem hiding this comment.
From my perspective, I think we can add an initExecutorService() method in RouterRpcClient, and then have RouterAsyncRpcClient inherit this method. In RouterRpcClient, we can initialize the executorService normally, but in RouterAsyncRpcClient, this method can be left as an empty implementation.
There was a problem hiding this comment.
// in RouterRpcClient
public void initExecutorService(Conf conf) {
int numThreads = conf.getInt(
RBFConfigKeys.DFS_ROUTER_CLIENT_THREADS_SIZE,
RBFConfigKeys.DFS_ROUTER_CLIENT_THREADS_SIZE_DEFAULT);
ThreadFactory threadFactory = new ThreadFactoryBuilder()
.setNameFormat("RPC Router Client-%d")
.build();
BlockingQueue<Runnable> workQueue;
if (conf.getBoolean(
RBFConfigKeys.DFS_ROUTER_CLIENT_REJECT_OVERLOAD,
RBFConfigKeys.DFS_ROUTER_CLIENT_REJECT_OVERLOAD_DEFAULT)) {
workQueue = new ArrayBlockingQueue<>(numThreads);
} else {
workQueue = new LinkedBlockingQueue<>();
}
this.executorService = new ThreadPoolExecutor(numThreads, numThreads,
0L, TimeUnit.MILLISECONDS, workQueue, threadFactory);
}
// in RouteAsyncRpcClient
public void initExecutorService(Conf conf) {
}There was a problem hiding this comment.
@KeeProMise Thanks very much for this nice suggestion. It looks better and i will optimize this PR base on your advise.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
KeeProMise
reviewed
Apr 2, 2025
Comment on lines
881
to
886
| @VisibleForTesting | ||
| public boolean isAsync() { | ||
| return getRpcServer() != null ? getRpcServer().isAsync() : | ||
| getConfig() != null ? getConfig().getBoolean(DFS_ROUTER_ASYNC_RPC_ENABLE_KEY, | ||
| DFS_ROUTER_ASYNC_RPC_ENABLE_DEFAULT) : DFS_ROUTER_ASYNC_RPC_ENABLE_DEFAULT; | ||
| } |
There was a problem hiding this comment.
Hi @hfutatzhanghb Can this method be deleted?
There was a problem hiding this comment.
@KeeProMise Nice advise, have deleted it.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
Hi @hfutatzhanghb thanks for your contribution, merged! |
|
@KeeProMise Thanks very much for reviewing and merging! |
YanivKunda
pushed a commit
to YanivKunda/hadoop
that referenced
this pull request
Apr 4, 2025
…RpcClient. (apache#7561). Contributed by hfutatzhanghb. Reviewed-by: Jian Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Avoid initializing unused threadPool in RouterAsyncRpcClient.
Actually, we use async handler to send rpc to NN rather than the original threadPool.