-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-19236 Incorporate VolcanoEngine Cloud TOS File System Implementation. (Part 2: Add unit tests) #7545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💔 -1 overall
This message was automatically generated. |
e392fad
to
b26beb4
Compare
💔 -1 overall
This message was automatically generated. |
b26beb4
to
63fc8e8
Compare
🎊 +1 overall
This message was automatically generated. |
Hi @slfan1989 @Hexiaoqiao , this is the second part of HADOOP-19236, including all the unit tests. Could you help taking a look, thanks very much ! |
@wojiaodoubao Thank you for inviting me to participate in this pr! I am currently working on upgrading hadoop-common from JUnit4 to JUnit5. It is expected that two or three related PRs will need to be merged before this PR can be merged. |
Nice to hear this, great work @slfan1989 !!! I'll wait, and update hadoop-tos to junit5 after hadoop-common is updated. |
63fc8e8
to
ca2bc0f
Compare
💔 -1 overall
This message was automatically generated. |
ca2bc0f
to
ac15867
Compare
🎊 +1 overall
This message was automatically generated. |
Hi @slfan1989 , all tests have been refactored with junit5. Could you help take a look when you have time, thanks very much! |
...orage-project/hadoop-tos/src/test/java/org/apache/hadoop/fs/tosfs/contract/TestUnbuffer.java
Outdated
Show resolved
Hide resolved
...project/hadoop-tos/src/test/java/org/apache/hadoop/fs/tosfs/object/TestDirectoryStorage.java
Outdated
Show resolved
Hide resolved
...rc/test/java/org/apache/hadoop/fs/tosfs/object/tos/auth/TestAbstractCredentialsProvider.java
Outdated
Show resolved
Hide resolved
@wojiaodoubao It looks good overall, just a few minor suggestions. |
🎊 +1 overall
This message was automatically generated. |
Hi @slfan1989 , the pr is ready for review now, please help when you have time, thanks very much! |
hi @slfan1989 , could you help review when you have time, thanks very much! |
@wojiaodoubao We've removed the JUnit 4 dependency from the trunk branch. Could you please rebase this PR? If it compiles successfully, we’ll proceed with the merge. |
…ntation (Part 2: Add unit tests.). Contributed by: ZhengHu, SunXin, XianyinXin, Rascal Wu, FangBo, Yuanzhihuan.
991cced
to
faa9ad6
Compare
Thanks @slfan1989 , thanks your comments! I rebased and tested it on my local env, it ran well. Let me push it and pending ci. |
🎊 +1 overall
This message was automatically generated. |
@wojiaodoubao Thanks for the contribution! Merged into trunk. |
Description of PR
HADOOP-19236 Incorporate VolcanoEngine Cloud TOS File System Implementation.
The full patch is too big to run ci, so it is split into 2 patches. This is the second one, containing the unit tests.
Please see #7194 for more details.
HADOOP-19236
How was this patch tested?
Unit tests and hadoop cluster.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?