HDDS-1395. Key write fails with BlockOutputStream has been closed exception #749

bshashikant · 2019-04-17T09:55:26Z

No description provided.

hadoop-yetus · 2019-04-17T11:51:02Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	26	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 6 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	68	Maven dependency ordering for branch
+1	mvninstall	981	trunk passed
+1	compile	981	trunk passed
+1	checkstyle	139	trunk passed
-1	mvnsite	50	client in trunk failed.
-1	mvnsite	55	integration-test in trunk failed.
+1	shadedclient	1084	branch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/integration-test
-1	findbugs	35	client in trunk failed.
+1	javadoc	147	trunk passed
		_ Patch Compile Tests _
0	mvndep	23	Maven dependency ordering for patch
-1	mvninstall	24	integration-test in the patch failed.
+1	compile	928	the patch passed
+1	javac	928	the patch passed
+1	checkstyle	138	the patch passed
-1	mvnsite	44	integration-test in the patch failed.
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	1	The patch has no ill-formed XML file.
+1	shadedclient	672	patch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1	findbugs	193	the patch passed
+1	javadoc	145	the patch passed
		_ Other Tests _
+1	unit	37	client in the patch passed.
+1	unit	78	common in the patch passed.
+1	unit	40	client in the patch passed.
-1	unit	41	integration-test in the patch failed.
+1	asflicense	48	The patch does not generate ASF License warnings.
		6378

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-749/1/artifact/out/Dockerfile
GITHUB PR	#749
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname	Linux 29c2176d0272 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `d608be6`
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
mvnsite	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/1/artifact/out/branch-mvnsite-hadoop-ozone_client.txt
mvnsite	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/1/artifact/out/branch-mvnsite-hadoop-ozone_integration-test.txt
findbugs	v3.1.0-RC1
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/1/artifact/out/branch-findbugs-hadoop-ozone_client.txt
mvninstall	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/1/artifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt
mvnsite	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/1/artifact/out/patch-mvnsite-hadoop-ozone_integration-test.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/1/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/1/testReport/
Max. process+thread count	445 (vs. ulimit of 5500)
modules	C: hadoop-hdds/client hadoop-hdds/common hadoop-ozone/client hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

mukul1987 · 2019-04-18T18:29:13Z

Thanks for the patch Shashi, this patch has some unit test failure related to the patch.

mukul1987

Can the changes for BlockOutputStreamEntryPool.java, be done as part of a different pull request. The current patch becomes difficult to review because of the number of changes in the patch.

bshashikant · 2019-04-18T19:58:31Z

Thanks Mukul. It is difficult to divide the patch in multiple patches as it reorganizes KeyOutputStream. I will look into the unit test failures.

bshashikant · 2019-04-18T20:13:44Z

There is a unit test failure where a watch request is not failing with GroupMismatchException even after the pipeline gets removed but fails with Timeout Exception which i need to check further. But it would really help if we have it as a single patch.

jnp · 2019-04-23T20:42:14Z

hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStream.java

This need not be public. If you need it for testing, please annotate.

This needs to be pulic because this function gets invoked from BlockoutputStreamEntryPool#isClosed() and they are in different packages.

hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStream.java

jnp

Overall, patch looks good to me, only some minor comments.

hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/CommitWatcher.java

jnp · 2019-04-24T02:04:48Z

...ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/BlockOutputStreamEntryPool.java

I think we should not remove the streamEntry here. It will be easier for debugging, or code readability. The empty entries can be pruned at the time of reporting to OM, and also logged that certain block was not written at all.

hadoop-yetus · 2019-04-24T11:28:16Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	8	#749 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#749
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

…eption (apache#749).

bshashikant · 2019-04-24T11:51:52Z

There is a related test failure with a test added with the change which requires RATIS-532.

hadoop-yetus · 2019-04-24T13:54:16Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	29	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	20	Maven dependency ordering for branch
+1	mvninstall	1031	trunk passed
+1	compile	1044	trunk passed
+1	checkstyle	136	trunk passed
+1	mvnsite	177	trunk passed
+1	shadedclient	989	branch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1	findbugs	147	trunk passed
+1	javadoc	113	trunk passed
		_ Patch Compile Tests _
0	mvndep	22	Maven dependency ordering for patch
+1	mvninstall	120	the patch passed
+1	compile	994	the patch passed
+1	javac	994	the patch passed
+1	checkstyle	129	the patch passed
+1	mvnsite	159	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	1	The patch has no ill-formed XML file.
+1	shadedclient	633	patch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1	findbugs	177	the patch passed
+1	javadoc	120	the patch passed
		_ Other Tests _
+1	unit	29	client in the patch passed.
+1	unit	90	common in the patch passed.
+1	unit	35	client in the patch passed.
-1	unit	1483	integration-test in the patch failed.
+1	asflicense	59	The patch does not generate ASF License warnings.
		7685

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestReadRetries
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient
	hadoop.ozone.client.rpc.TestContainerStateMachine
	hadoop.ozone.client.rpc.TestHybridPipelineOnDatanode
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.TestMiniChaosOzoneCluster
	hadoop.ozone.TestMiniOzoneCluster
	hadoop.ozone.TestSecureOzoneCluster

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-749/4/artifact/out/Dockerfile
GITHUB PR	#749
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname	Linux d6ea000991a5 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 64f30da
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
findbugs	v3.1.0-RC1
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/4/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/4/testReport/
Max. process+thread count	2802 (vs. ulimit of 5500)
modules	C: hadoop-hdds/client hadoop-hdds/common hadoop-ozone/client hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/4/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-04-24T14:04:25Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	32	Docker mode activated.
		_ Prechecks _
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	68	Maven dependency ordering for branch
+1	mvninstall	1069	trunk passed
+1	compile	1048	trunk passed
+1	checkstyle	128	trunk passed
+1	mvnsite	170	trunk passed
+1	shadedclient	963	branch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1	findbugs	147	trunk passed
+1	javadoc	117	trunk passed
		_ Patch Compile Tests _
0	mvndep	25	Maven dependency ordering for patch
+1	mvninstall	125	the patch passed
+1	compile	1003	the patch passed
+1	javac	1003	the patch passed
+1	checkstyle	129	the patch passed
+1	mvnsite	154	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	1	The patch has no ill-formed XML file.
+1	shadedclient	621	patch has no errors when building and testing our client artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1	findbugs	180	the patch passed
+1	javadoc	122	the patch passed
		_ Other Tests _
+1	unit	32	client in the patch passed.
+1	unit	91	common in the patch passed.
+1	unit	36	client in the patch passed.
-1	unit	2112	integration-test in the patch failed.
+1	asflicense	41	The patch does not generate ASF License warnings.
		8388

Reason	Tests
Failed junit tests	hadoop.ozone.client.rpc.TestReadRetries
	hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient
	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.client.rpc.TestHybridPipelineOnDatanode
	hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
	hadoop.ozone.TestMiniChaosOzoneCluster
	hadoop.ozone.client.rpc.TestOzoneRpcClient
	hadoop.ozone.TestMiniOzoneCluster
	hadoop.ozone.client.rpc.TestContainerStateMachineFailures
	hadoop.ozone.client.rpc.TestOzoneAtRestEncryption

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-749/3/artifact/out/Dockerfile
GITHUB PR	#749
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname	Linux bcfea1a63aab 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 64f30da
maven	version: Apache Maven 3.3.9
Default Java	1.8.0_191
findbugs	v3.1.0-RC1
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/3/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/3/testReport/
Max. process+thread count	3955 (vs. ulimit of 5500)
modules	C: hadoop-hdds/client hadoop-hdds/common hadoop-ozone/client hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/3/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

bshashikant · 2019-04-25T12:06:47Z

/retest

hadoop-yetus · 2019-04-29T14:29:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	9	#749 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#749
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/5/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

…eption (apache#749).

hadoop-yetus · 2019-04-29T14:49:19Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	7	#749 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#749
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/6/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-04-30T09:30:46Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	6	#749 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#749
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/7/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

jnp · 2019-04-30T23:06:36Z

+1 for the patch, if the test failures are unrelated.

bshashikant · 2019-05-02T04:52:10Z

/retest

hadoop-yetus · 2019-05-02T16:52:57Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	45	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	64	Maven dependency ordering for branch
+1	mvninstall	423	trunk passed
-1	compile	36	hadoop-hdds in trunk failed.
-1	compile	25	hadoop-ozone in trunk failed.
+1	checkstyle	59	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	784	branch has no errors when building and testing our client artifacts.
+1	javadoc	147	trunk passed
0	spotbugs	244	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	433	trunk passed
-0	patch	275	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
0	mvndep	26	Maven dependency ordering for patch
+1	mvninstall	406	the patch passed
+1	compile	205	the patch passed
-1	javac	86	hadoop-hdds generated 11 new + 0 unchanged - 0 fixed = 11 total (was 0)
+1	checkstyle	54	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	3	The patch has no ill-formed XML file.
+1	shadedclient	645	patch has no errors when building and testing our client artifacts.
+1	javadoc	120	the patch passed
+1	findbugs	427	the patch passed
		_ Other Tests _
-1	unit	140	hadoop-hdds in the patch failed.
-1	unit	1176	hadoop-ozone in the patch failed.
+1	asflicense	38	The patch does not generate ASF License warnings.
		5412

Reason	Tests
Failed junit tests	hadoop.ozone.scm.TestSCMNodeManagerMXBean
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.ozShell.TestS3Shell
	hadoop.hdds.scm.pipeline.TestNodeFailure
	hadoop.ozone.web.TestOzoneVolumes
	hadoop.ozone.web.client.TestOzoneClient
	hadoop.ozone.TestStorageContainerManager
	hadoop.ozone.om.TestOmBlockVersioning
	hadoop.hdds.scm.pipeline.TestNode2PipelineMap
	hadoop.ozone.scm.TestGetCommittedBlockLengthAndPutKey
	hadoop.ozone.om.TestContainerReportWithKeys
	hadoop.ozone.client.rpc.TestWatchForCommit
	hadoop.hdds.scm.safemode.TestSCMSafeModeWithPipelineRules
	hadoop.ozone.scm.pipeline.TestSCMPipelineMetrics
	hadoop.hdds.scm.pipeline.TestPipelineClose
	hadoop.ozone.ozShell.TestOzoneShell
	hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
	hadoop.hdds.scm.container.TestContainerStateManagerIntegration
	hadoop.hdds.scm.pipeline.TestSCMRestart

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-749/8/artifact/out/Dockerfile
GITHUB PR	#749
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname	Linux c024cdf21f02 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `6a42745`
Default Java	1.8.0_191
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/8/artifact/out/branch-compile-hadoop-hdds.txt
compile	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/8/artifact/out/branch-compile-hadoop-ozone.txt
javac	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/8/artifact/out/diff-compile-javac-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/8/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/8/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/8/testReport/
Max. process+thread count	4356 (vs. ulimit of 5500)
modules	C: hadoop-hdds/client hadoop-hdds/common hadoop-ozone/client hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/8/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-05-03T11:46:02Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	31	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	21	Maven dependency ordering for branch
+1	mvninstall	404	trunk passed
+1	compile	199	trunk passed
+1	checkstyle	53	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	819	branch has no errors when building and testing our client artifacts.
+1	javadoc	124	trunk passed
0	spotbugs	234	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	408	trunk passed
-0	patch	268	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
0	mvndep	25	Maven dependency ordering for patch
+1	mvninstall	405	the patch passed
+1	compile	208	the patch passed
+1	javac	208	the patch passed
-0	checkstyle	28	hadoop-ozone: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	4	The patch has no ill-formed XML file.
+1	shadedclient	667	patch has no errors when building and testing our client artifacts.
+1	javadoc	125	the patch passed
+1	findbugs	437	the patch passed
		_ Other Tests _
-1	unit	145	hadoop-hdds in the patch failed.
-1	unit	1046	hadoop-ozone in the patch failed.
+1	asflicense	37	The patch does not generate ASF License warnings.
		5348

Reason	Tests
Failed junit tests	hadoop.ozone.scm.TestXceiverClientMetrics
	hadoop.ozone.web.client.TestKeysRatis
	hadoop.ozone.om.TestOzoneManager
	hadoop.ozone.TestContainerOperations
	hadoop.ozone.om.TestOzoneManagerRestInterface
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.hdds.scm.pipeline.TestNodeFailure
	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.web.client.TestVolume
	hadoop.ozone.web.TestOzoneRestWithMiniCluster
	hadoop.hdds.scm.pipeline.TestRatisPipelineUtils
	hadoop.ozone.om.TestOzoneManagerConfiguration
	hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerHandler
	hadoop.hdds.scm.pipeline.TestNode2PipelineMap
	hadoop.ozone.scm.TestGetCommittedBlockLengthAndPutKey
	hadoop.ozone.client.rpc.TestBlockOutputStream
	hadoop.ozone.TestMiniOzoneCluster
	hadoop.ozone.client.rpc.TestContainerStateMachineFailures
	hadoop.ozone.scm.pipeline.TestSCMPipelineMetrics
	hadoop.hdds.scm.pipeline.TestPipelineClose
	hadoop.ozone.TestContainerStateMachineIdempotency
	hadoop.ozone.om.TestOzoneManagerHA
	hadoop.ozone.scm.TestContainerSmallFile
	hadoop.ozone.om.TestOmAcls
	hadoop.hdds.scm.pipeline.TestSCMRestart

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-749/9/artifact/out/Dockerfile
GITHUB PR	#749
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname	Linux 714cc545bcd9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / f1875b2
Default Java	1.8.0_191
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/9/artifact/out/diff-checkstyle-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/9/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/9/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/9/testReport/
Max. process+thread count	4130 (vs. ulimit of 5500)
modules	C: hadoop-hdds hadoop-hdds/client hadoop-hdds/common hadoop-ozone hadoop-ozone/client hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/9/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-05-03T16:45:56Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	30	Docker mode activated.
		_ Prechecks _
+1	dupname	1	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	22	Maven dependency ordering for branch
+1	mvninstall	398	trunk passed
+1	compile	204	trunk passed
+1	checkstyle	53	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	819	branch has no errors when building and testing our client artifacts.
+1	javadoc	130	trunk passed
0	spotbugs	234	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	413	trunk passed
-0	patch	270	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
0	mvndep	29	Maven dependency ordering for patch
+1	mvninstall	403	the patch passed
+1	compile	209	the patch passed
+1	javac	209	the patch passed
+1	checkstyle	62	the patch passed
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	4	The patch has no ill-formed XML file.
+1	shadedclient	666	patch has no errors when building and testing our client artifacts.
+1	javadoc	133	the patch passed
+1	findbugs	427	the patch passed
		_ Other Tests _
-1	unit	145	hadoop-hdds in the patch failed.
-1	unit	1311	hadoop-ozone in the patch failed.
+1	asflicense	38	The patch does not generate ASF License warnings.
		5772

Reason	Tests
Failed junit tests	hadoop.ozone.om.TestOzoneManagerRestInterface
	hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
	hadoop.ozone.ozShell.TestS3Shell
	hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient
	hadoop.hdds.scm.pipeline.TestNodeFailure
	hadoop.ozone.client.rpc.TestBCSID
	hadoop.ozone.ozShell.TestOzoneDatanodeShell
	hadoop.ozone.client.rpc.TestContainerStateMachine
	hadoop.ozone.client.rpc.TestHybridPipelineOnDatanode
	hadoop.ozone.om.TestOzoneManagerConfiguration
	hadoop.ozone.om.TestOMDbCheckpointServlet
	hadoop.ozone.scm.node.TestSCMNodeMetrics
	hadoop.hdds.scm.pipeline.TestNode2PipelineMap
	hadoop.ozone.client.rpc.TestBlockOutputStream
	hadoop.ozone.om.TestScmSafeMode
	hadoop.hdds.scm.safemode.TestSCMSafeModeWithPipelineRules
	hadoop.ozone.TestMiniOzoneCluster
	hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline
	hadoop.ozone.client.rpc.TestContainerStateMachineFailures
	hadoop.hdds.scm.pipeline.TestPipelineClose
	hadoop.ozone.om.TestOzoneManagerHA
	hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException
	hadoop.hdds.scm.container.TestContainerStateManagerIntegration
	hadoop.ozone.om.TestOmAcls
	hadoop.hdds.scm.pipeline.TestSCMRestart

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-749/10/artifact/out/Dockerfile
GITHUB PR	#749
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname	Linux f1b119980d60 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / f1875b2
Default Java	1.8.0_191
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/10/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/10/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/10/testReport/
Max. process+thread count	4646 (vs. ulimit of 5500)
modules	C: hadoop-hdds hadoop-hdds/client hadoop-hdds/common hadoop-ozone hadoop-ozone/client hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/10/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

…eption

bshashikant · 2019-05-07T13:13:04Z

/retest

hadoop-yetus · 2019-05-07T14:56:17Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	47	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 5 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	74	Maven dependency ordering for branch
+1	mvninstall	446	trunk passed
+1	compile	225	trunk passed
+1	checkstyle	59	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	899	branch has no errors when building and testing our client artifacts.
+1	javadoc	124	trunk passed
0	spotbugs	274	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	486	trunk passed
		_ Patch Compile Tests _
0	mvndep	27	Maven dependency ordering for patch
+1	mvninstall	450	the patch passed
+1	compile	201	the patch passed
+1	javac	201	the patch passed
-0	checkstyle	29	hadoop-hdds: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1	mvnsite	0	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	3	The patch has no ill-formed XML file.
+1	shadedclient	733	patch has no errors when building and testing our client artifacts.
+1	javadoc	130	the patch passed
+1	findbugs	468	the patch passed
		_ Other Tests _
-1	unit	157	hadoop-hdds in the patch failed.
-1	unit	1291	hadoop-ozone in the patch failed.
+1	asflicense	33	The patch does not generate ASF License warnings.
		6050

Reason	Tests
Failed junit tests	hadoop.ozone.container.TestContainerReplication

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-749/13/artifact/out/Dockerfile
GITHUB PR	#749
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname	Linux 0f9e9cedcd18 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `49e1292`
Default Java	1.8.0_191
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/13/artifact/out/diff-checkstyle-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/13/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/13/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/13/testReport/
Max. process+thread count	4858 (vs. ulimit of 5500)
modules	C: hadoop-hdds hadoop-hdds/client hadoop-hdds/common hadoop-ozone hadoop-ozone/client hadoop-ozone/integration-test U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/13/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-05-07T19:10:08Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0	Docker mode activated.
-1	patch	15	#749 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem	Report/Notes
GITHUB PR	#749
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-749/14/console
versions	git=1.9.1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

…osed exception (#749)" This reverts commit d525633.

…eption (#749). Contributed by Shashikant Banerjee

bshashikant · 2019-05-07T19:32:16Z

The 1 test failure reported is not related to the patch.

- Fix titles for blog posts - Fix a rendering issue with hyperlinks on the front-page - Add links from homepage sections to relevant documentation pages Author: Jagadish <[email protected]> Reviewers: Jagadish<[email protected]> Closes apache#749 from vjagadish1989/website-reorg21

bshashikant requested review from jnp and mukul1987 April 17, 2019 09:55

xiaoyuyao added the ozone label Apr 17, 2019

xiaoyuyao assigned bshashikant Apr 17, 2019

mukul1987 requested changes Apr 18, 2019

View reviewed changes

jnp reviewed Apr 23, 2019

View reviewed changes

jnp reviewed Apr 24, 2019

View reviewed changes

bshashikant closed this Apr 24, 2019

bshashikant force-pushed the HDDS-1395 branch from 2d80046 to 64f30da Compare April 24, 2019 11:39

bshashikant added a commit to bshashikant/hadoop that referenced this pull request Apr 24, 2019

HDDS-1395. Key write fails with BlockOutputStream has been closed exc…

fe313a8

…eption (apache#749).

bshashikant reopened this Apr 24, 2019

bshashikant added a commit to bshashikant/hadoop that referenced this pull request Apr 29, 2019

HDDS-1395. Key write fails with BlockOutputStream has been closed exc…

f7a42fe

…eption (apache#749).

bshashikant force-pushed the HDDS-1395 branch from c234c00 to 3290ffb Compare May 6, 2019 04:34

bshashikant closed this May 7, 2019

bshashikant force-pushed the HDDS-1395 branch from 3290ffb to 49e1292 Compare May 7, 2019 13:09

HDDS-1395. Key write fails with BlockOutputStream has been closed exc…

27c2fec

…eption

bshashikant reopened this May 7, 2019

Addressed checkstyle issue

2fcfb03

bshashikant merged commit d525633 into apache:trunk May 7, 2019

asfgit pushed a commit that referenced this pull request May 7, 2019

Revert "HDDS-1395. Key write fails with BlockOutputStream has been cl…

01451a5

…osed exception (#749)" This reverts commit d525633.

asfgit pushed a commit that referenced this pull request May 7, 2019

HDDS-1395. Key write fails with BlockOutputStream has been closed exc…

7f0e2c6

…eption (#749). Contributed by Shashikant Banerjee

bshashikant deleted the HDDS-1395 branch May 7, 2019 19:32

HDDS-1395. Key write fails with BlockOutputStream has been closed exception #749

HDDS-1395. Key write fails with BlockOutputStream has been closed exception #749

Uh oh!

Conversation

bshashikant commented Apr 17, 2019

Uh oh!

hadoop-yetus commented Apr 17, 2019

Uh oh!

mukul1987 commented Apr 18, 2019

Uh oh!

mukul1987 left a comment

Choose a reason for hiding this comment

Uh oh!

bshashikant commented Apr 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bshashikant commented Apr 18, 2019

Uh oh!

jnp Apr 23, 2019

Choose a reason for hiding this comment

Uh oh!

bshashikant Apr 24, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jnp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jnp Apr 24, 2019

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Apr 24, 2019

Uh oh!

bshashikant commented Apr 24, 2019

Uh oh!

hadoop-yetus commented Apr 24, 2019

Uh oh!

hadoop-yetus commented Apr 24, 2019

Uh oh!

bshashikant commented Apr 25, 2019

Uh oh!

hadoop-yetus commented Apr 29, 2019

Uh oh!

hadoop-yetus commented Apr 29, 2019

Uh oh!

hadoop-yetus commented Apr 30, 2019

Uh oh!

jnp commented Apr 30, 2019

Uh oh!

bshashikant commented May 2, 2019

Uh oh!

hadoop-yetus commented May 2, 2019

Uh oh!

hadoop-yetus commented May 3, 2019

Uh oh!

hadoop-yetus commented May 3, 2019

Uh oh!

bshashikant commented May 7, 2019

Uh oh!

hadoop-yetus commented May 7, 2019

Uh oh!

hadoop-yetus commented May 7, 2019

Uh oh!

bshashikant commented May 7, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bshashikant commented Apr 18, 2019 •

edited

Loading