YARN-11783. Upgrade wro4j to 1.8.0

[GauthamBanasandra]

Description of PR

• There was a change to upgrade Mockito to 4.11.0 in HADOOP-19243. Upgrade Mockito version to 4.11.0 #6968.
• This broke the build on Windows in the hadoop-yarn-ui module - HADOOP-19243. Upgrade Mockito version to 4.11.0 #6968 (comment).
• We need to upgrade the version wro4j to 1.8.0 to get rid of its dependency on mockito, in order to fix the build failure of hadoop-yarn-ui module.
• We tried reverting the wro4j version in YARN-11779. Reset mockito version to 2.18.0 in hadoop-yarn-ui #7440. But it looks like this isn't feasible and could impede the JDK17 upgrade of Hadoop.

How was this patch tested?

Verified by building locally on Windows 11.

For code changes:

• Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
• Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

[slfan1989]

@GauthamBanasandra Thanks for the contribution! @ayushtkn @steveloughran I found that Jenkins is not working, can we restart Jenkins?

[iomega11]

Hi!

I was having the same issue on both Windows 10 and linux containers:

[ERROR] Failed to execute goal ro.isdc.wro4j:wro4j-maven-plugin:1.7.9:run (default) on project hadoop-yarn-ui: Execution default of goal ro.isdc.wro4j:wro4j-maven-plugin:1.7.9:run failed: An API incompatibility was encountered while executing ro.isdc.wro4j:wro4j-maven-plugin:1.7.9:run: java.lang.ExceptionInInitializerError: null
[ERROR] -----------------------------------------------------
[ERROR] realm =    plugin>ro.isdc.wro4j:wro4j-maven-plugin:1.7.9
[ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
[ERROR] urls[0] = file:/home/nicolas/.m2/repository/ro/isdc/wro4j/wro4j-maven-plugin/1.7.9/wro4j-maven-plugin-1.7.9.jar

(truncated a part of the stacktrace)

[ERROR] urls[99] = file:/home/nicolas/.m2/repository/log4j/log4j/1.2.17/log4j-1.2.17.jar
[ERROR] Number of foreign imports: 1
[ERROR] import: Entry[import  from realm ClassRealm[project>org.apache.hadoop:hadoop-project:3.5.0-SNAPSHOT, parent: ClassRealm[maven.api, parent: null]]]
[ERROR] 
[ERROR] -----------------------------------------------------
[ERROR] : NullPointerException

I was able to test the fix locally and it worked for me. Thanks a lot!

[steveloughran]

this something which is redistributed? in which case the LICENSE file needs updating too

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	7m 17s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	24m 15s		trunk passed
+1 💚	compile	1m 19s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	compile	1m 8s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚	mvnsite	0m 28s		trunk passed
+1 💚	javadoc	0m 20s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 16s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚	shadedclient	50m 7s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 8s		the patch passed
+1 💚	compile	0m 55s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javac	0m 55s		the patch passed
+1 💚	compile	1m 2s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚	javac	1m 2s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	0m 19s		the patch passed
+1 💚	javadoc	0m 9s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javadoc	0m 10s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚	shadedclient	22m 9s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 53s		hadoop-yarn-ui in the patch passed.
+1 💚	asflicense	0m 35s		The patch does not generate ASF License warnings.
		84m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7457/1/artifact/out/Dockerfile
GITHUB PR	#7457
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname	Linux ec6f0916ad44 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / a6832f4
Default Java	Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7457/1/testReport/
Max. process+thread count	545 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7457/1/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[goiri]

LICENSE update required.

[GauthamBanasandra]

I was having the same issue on both Windows 10 and linux containers:

@iomega11 thanks for checking. It's strange that this was failing on Linux as well. Somehow, the CI isn't failing - even for Windows. It's only the local build that fails.

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 19s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	6m 36s		Maven dependency ordering for branch
+1 💚	mvninstall	19m 41s		trunk passed
+1 💚	compile	8m 36s		trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	compile	7m 39s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚	mvnsite	11m 25s		trunk passed
-1 ❌	javadoc	1m 40s	/branch-javadoc-root-jdkUbuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04.txt	root in trunk failed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04.
+1 💚	javadoc	4m 44s		trunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚	shadedclient	27m 31s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s		Maven dependency ordering for patch
+1 💚	mvninstall	18m 20s		the patch passed
+1 💚	compile	7m 58s		the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚	javac	7m 58s		the patch passed
+1 💚	compile	7m 23s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚	javac	7m 23s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	11m 52s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
-1 ❌	javadoc	1m 27s	/patch-javadoc-root-jdkUbuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04.txt	root in the patch failed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04.
+1 💚	javadoc	4m 46s		the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚	shadedclient	26m 53s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	447m 6s		root in the patch passed.
+1 💚	asflicense	1m 1s		The patch does not generate ASF License warnings.
		604m 43s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7457/2/artifact/out/Dockerfile
GITHUB PR	#7457
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname	Linux ec543ad9abed 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / cd380ae
Default Java	Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7457/2/testReport/
Max. process+thread count	3723 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7457/2/console
versions	git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

[ayushtkn]

LGTM
The javadoc failure looks unrelated, seems to be introduced by HDFS-17496