-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-19348. Integrate analytics accelerator into S3A. #7334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -147,9 +147,11 @@ | |
| import org.apache.hadoop.fs.s3a.impl.StoreContextFactory; | ||
| import org.apache.hadoop.fs.s3a.impl.UploadContentProviders; | ||
| import org.apache.hadoop.fs.s3a.impl.CSEUtils; | ||
| import org.apache.hadoop.fs.s3a.impl.streams.InputStreamType; | ||
| import org.apache.hadoop.fs.s3a.impl.streams.ObjectReadParameters; | ||
| import org.apache.hadoop.fs.s3a.impl.streams.ObjectInputStreamCallbacks; | ||
| import org.apache.hadoop.fs.s3a.impl.streams.StreamFactoryRequirements; | ||
| import org.apache.hadoop.fs.s3a.impl.streams.StreamIntegration; | ||
| import org.apache.hadoop.fs.s3a.tools.MarkerToolOperations; | ||
| import org.apache.hadoop.fs.s3a.tools.MarkerToolOperationsImpl; | ||
| import org.apache.hadoop.fs.statistics.DurationTracker; | ||
|
|
@@ -440,6 +442,11 @@ public class S3AFileSystem extends FileSystem implements StreamCapabilities, | |
| */ | ||
| private boolean isCSEEnabled; | ||
|
|
||
| /** | ||
| * Is this S3A FS instance using analytics accelerator? | ||
| */ | ||
| private boolean isAnalyticsAccelaratorEnabled; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FWIW I've got a draft plan in my head to move all these bools and other config options into some config class under store...probably start with the Conditional Create stuff where the new flags go in. Microsoft's reflection-based resolution is what I'm looking at. |
||
|
|
||
| /** | ||
| * Bucket AccessPoint. | ||
| */ | ||
|
|
@@ -629,6 +636,8 @@ public void initialize(URI name, Configuration originalConf) | |
| // If encryption method is set to CSE-KMS or CSE-CUSTOM then CSE is enabled. | ||
| isCSEEnabled = CSEUtils.isCSEEnabled(getS3EncryptionAlgorithm().getMethod()); | ||
|
|
||
| isAnalyticsAccelaratorEnabled = StreamIntegration.determineInputStreamType(conf).equals(InputStreamType.Analytics); | ||
|
|
||
| // Create the appropriate fsHandler instance using a factory method | ||
| fsHandler = createFileSystemHandler(); | ||
| fsHandler.setCSEGauge((IOStatisticsStore) getIOStatistics()); | ||
|
|
@@ -1156,6 +1165,7 @@ private ClientManager createClientManager(URI fsURI, boolean dtEnabled) throws I | |
| conf.getBoolean(CHECKSUM_VALIDATION, CHECKSUM_VALIDATION_DEFAULT)) | ||
| .withClientSideEncryptionEnabled(isCSEEnabled) | ||
| .withClientSideEncryptionMaterials(cseMaterials) | ||
| .withAnalyticsAcceleratorEnabled(isAnalyticsAccelaratorEnabled) | ||
| .withKMSRegion(conf.get(S3_ENCRYPTION_CSE_KMS_REGION)); | ||
|
|
||
| // this is where clients and the transfer manager are created on demand. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.