Skip to content

HDDS-1426. Minor logging improvements for MiniOzoneChaosCluster. Cont… #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

HDDS-1426. Minor logging improvements for MiniOzoneChaosCluster. Cont… #730

wants to merge 1 commit into from

Conversation

@arp7
Copy link
Contributor

@arp7 arp7 commented Apr 11, 2019

…ributed by Arpit Agarwal.

Change-Id: I3459de58dd99e48a41b4408fd4a71b86bceeb329

@arp7 arp7 requested a review from mukul1987 April 11, 2019 22:04
@arp7 arp7 added the ozone label Apr 11, 2019
@arp7
HDDS-1426. Minor logging improvements for MiniOzoneChaosCluster. Cont…
3de8a63 
…ributed by Arpit Agarwal.

Change-Id: Ied04ad29348d012366c7018ed9009890a37bb4d2
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 42 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 1164 trunk passed
-1 compile 31 integration-test in trunk failed.
+1 checkstyle 23 trunk passed
-1 mvnsite 30 integration-test in trunk failed.
+1 shadedclient 112 branch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1 findbugs 0 trunk passed
+1 javadoc 22 trunk passed
_ Patch Compile Tests _
-1 mvninstall 24 integration-test in the patch failed.
-1 compile 24 integration-test in the patch failed.
-1 javac 24 integration-test in the patch failed.
+1 checkstyle 19 the patch passed
-1 mvnsite 26 integration-test in the patch failed.
+1 shellcheck 0 There were no new shellcheck issues.
+1 shelldocs 15 The patch generated 0 new + 104 unchanged - 132 fixed = 104 total (was 236)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 807 patch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1 findbugs 0 the patch passed
+1 javadoc 19 the patch passed
_ Other Tests _
-1 unit 25 integration-test in the patch failed.
+1 asflicense 29 The patch does not generate ASF License warnings.
2547
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-730/1/artifact/out/Dockerfile
GITHUB PR #730
Optional Tests dupname asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall shadedclient findbugs checkstyle
uname Linux 230513dee4f3 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / ed3747c
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-730/1/artifact/out/branch-compile-hadoop-ozone_integration-test.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-730/1/artifact/out/branch-mvnsite-hadoop-ozone_integration-test.txt
shellcheck v0.4.6
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-730/1/artifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-730/1/artifact/out/patch-compile-hadoop-ozone_integration-test.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-730/1/artifact/out/patch-compile-hadoop-ozone_integration-test.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-730/1/artifact/out/patch-mvnsite-hadoop-ozone_integration-test.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-730/1/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-730/1/testReport/
Max. process+thread count 293 (vs. ulimit of 5500)
modules C: hadoop-ozone/integration-test U: hadoop-ozone/integration-test
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-730/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 41 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+1 mvninstall 1136 trunk passed
-1 compile 29 integration-test in trunk failed.
+1 checkstyle 23 trunk passed
-1 mvnsite 30 integration-test in trunk failed.
+1 shadedclient 740 branch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1 findbugs 0 trunk passed
+1 javadoc 21 trunk passed
_ Patch Compile Tests _
-1 mvninstall 23 integration-test in the patch failed.
-1 compile 23 integration-test in the patch failed.
-1 javac 23 integration-test in the patch failed.
+1 checkstyle 17 the patch passed
-1 mvnsite 24 integration-test in the patch failed.
+1 shellcheck 0 There were no new shellcheck issues.
+1 shelldocs 16 The patch generated 0 new + 104 unchanged - 132 fixed = 104 total (was 236)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 834 patch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1 findbugs 0 the patch passed
+1 javadoc 18 the patch passed
_ Other Tests _
-1 unit 26 integration-test in the patch failed.
+1 asflicense 28 The patch does not generate ASF License warnings.
3169
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-730/2/artifact/out/Dockerfile
GITHUB PR #730
Optional Tests dupname asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall shadedclient findbugs checkstyle
uname Linux dbd70b1252c6 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / ed3747c
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-730/2/artifact/out/branch-compile-hadoop-ozone_integration-test.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-730/2/artifact/out/branch-mvnsite-hadoop-ozone_integration-test.txt
shellcheck v0.4.6
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-730/2/artifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt
compile https://builds.apache.org/job/hadoop-multibranch/job/PR-730/2/artifact/out/patch-compile-hadoop-ozone_integration-test.txt
javac https://builds.apache.org/job/hadoop-multibranch/job/PR-730/2/artifact/out/patch-compile-hadoop-ozone_integration-test.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-730/2/artifact/out/patch-mvnsite-hadoop-ozone_integration-test.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-730/2/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-730/2/testReport/
Max. process+thread count 305 (vs. ulimit of 5500)
modules C: hadoop-ozone/integration-test U: hadoop-ozone/integration-test
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-730/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

elek
elek approved these changes Apr 12, 2019
View reviewed changes
Copy link
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 thanks @arp7 the improvement.

I can confirm that the one unit test failure is independent.

@elek elek closed this in fd676e1 Apr 12, 2019
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
@Sanil15 @jagadish-v0
SAMZA-1950: Fixing Style for Meetups
62857f6 
Author: Sanil15 <[email protected]>

Reviewers: Jagadish<[email protected]>

Closes apache#730 from Sanil15/SAMZA-1950
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elek elek elek approved these changes

@mukul1987 mukul1987 Awaiting requested review from mukul1987

Assignees

No one assigned

Labels

ozone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arp7 @hadoop-yetus @elek