Skip to content

HDFS-17706. TestBlockTokenWithDFSStriped fails due to closed streams #7275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2025
Merged

HDFS-17706. TestBlockTokenWithDFSStriped fails due to closed streams #7275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...fs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockTokenWithDFS.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,9 @@ protected void doTestRead(Configuration conf, MiniDFSCluster cluster,

// restart the namenode to allow DFSClient to re-fetch tokens
cluster.restartNameNode(0);
// Reopen closed streams
in1 = fs.open(fileToRead);
in3 = fs.open(fileToRead);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your works here. Not familiar with this unit test, just confused where are this input stream closed? Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review. The exceptions happen in the 2 assertFalse(checkFile()) lines right above and the streams were closed during exception handling.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, try to explore the code but not see any explicit close stream operation, anything I skipped? Thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hexiaoqiao Sir, inputStream is closed here: https://github.com/harris233/hadoop/blob/e73f432f56ca8c209cff0a7f3077522b5e76e0d7/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/StripeReader.java#L356C7-L356C28

This code was introduced by HDFS-17080

image image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. +1.

// verify blockSeekTo() works again (by transparently re-fetching
// tokens from namenode)
in1.seek(0);
Expand Down
Loading