Skip to content

HDDS-1376. Datanode exits while executing client command when scmId is null #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 16, 2019
Merged

HDDS-1376. Datanode exits while executing client command when scmId is null #724

merged 4 commits into from
Apr 16, 2019

Conversation

@hanishakoneru
Copy link
Contributor

No description provided.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 62 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 4 new or modified test files.
_ trunk Compile Tests _
0 mvndep 85 Maven dependency ordering for branch
+1 mvninstall 1355 trunk passed
+1 compile 1137 trunk passed
+1 checkstyle 214 trunk passed
+1 mvnsite 128 trunk passed
+1 shadedclient 1138 branch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1 findbugs 54 trunk passed
+1 javadoc 61 trunk passed
_ Patch Compile Tests _
0 mvndep 21 Maven dependency ordering for patch
+1 mvninstall 68 the patch passed
+1 compile 937 the patch passed
+1 javac 937 the patch passed
+1 checkstyle 217 the patch passed
+1 mvnsite 82 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 747 patch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1 findbugs 62 the patch passed
+1 javadoc 61 the patch passed
_ Other Tests _
-1 unit 74 container-service in the patch failed.
-1 unit 1239 integration-test in the patch failed.
+1 asflicense 45 The patch does not generate ASF License warnings.
7717
Reason Tests
Failed junit tests hadoop.ozone.container.common.TestDatanodeStateMachine
hadoop.ozone.om.TestOzoneManagerHA
hadoop.ozone.scm.TestXceiverClientManager
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-724/1/artifact/out/Dockerfile
GITHUB PR #724
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux d661e9ea1d87 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 586826f
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-724/1/artifact/out/patch-unit-hadoop-hdds_container-service.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-724/1/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-724/1/testReport/
Max. process+thread count 4534 (vs. ulimit of 5500)
modules C: hadoop-hdds/container-service hadoop-ozone/integration-test U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-724/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

arp7
arp7 approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@arp7 arp7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@arp7
Copy link
Contributor

arp7 commented Apr 11, 2019 •
edited
Loading

LGTM. Please verify the UT failures are unrelated before submitting the change.

Link to UT failures run: https://ci.anzix.net/job/ozone/16626/testReport/

nandakumar131
nandakumar131 approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@nandakumar131 nandakumar131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, looks good to me.

bharatviswa504
bharatviswa504 reviewed Apr 12, 2019
View reviewed changes
...n/java/org/apache/hadoop/ozone/container/keyvalue/helpers/KeyValueContainerLocationUtil.java
String scmId,
long containerId) {
Preconditions.checkNotNull(hddsVolumeDir, "Base Directory cannot be null");
Preconditions.checkNotNull(scmId, "scmUuid cannot be null");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@hanishakoneru
Copy link
Contributor Author

Fixed checkstyle and one related unit test failure. The other unit test failures are not related and pass locally.

bharatviswa504
bharatviswa504 approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@bharatviswa504 bharatviswa504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

@hanishakoneru
Copy link
Contributor Author

Thank you @bharatviswa504 and @arp7 for the reviews. Merging with trunk.

@hanishakoneru hanishakoneru merged commit e543c3b into apache:trunk Apr 16, 2019
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
@jagadish-v0
Clean-up the case-studies page for Ebay, add a diagram
0b0a0ca 
Author: Jagadish <[email protected]>

Reviewers: Jagadish<[email protected]>

Closes apache#724 from vjagadish1989/website-reorg17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arp7 arp7 arp7 approved these changes

@bharatviswa504 bharatviswa504 bharatviswa504 approved these changes

@nandakumar131 nandakumar131 nandakumar131 approved these changes

Assignees

No one assigned

Labels

ozone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hanishakoneru @hadoop-yetus @arp7 @bharatviswa504 @nandakumar131