Skip to content

Conversation

@arp7
Copy link
Contributor

@arp7 arp7 commented Apr 11, 2019

…by Arpit Agarwal.

Change-Id: I73394296b7de3b31b4d136fd5ed020a82bc063aa

…by Arpit Agarwal.

Change-Id: I73394296b7de3b31b4d136fd5ed020a82bc063aa
@arp7 arp7 added the ozone label Apr 11, 2019
@arp7 arp7 requested a review from elek April 11, 2019 00:09
@arp7 arp7 self-assigned this Apr 11, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 70 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 4 new or modified test files.
_ trunk Compile Tests _
0 mvndep 96 Maven dependency ordering for branch
+1 mvninstall 2170 trunk passed
+1 compile 1219 trunk passed
+1 checkstyle 215 trunk passed
+1 mvnsite 123 trunk passed
+1 shadedclient 1119 branch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1 findbugs 59 trunk passed
+1 javadoc 61 trunk passed
_ Patch Compile Tests _
0 mvndep 23 Maven dependency ordering for patch
+1 mvninstall 71 the patch passed
+1 compile 1013 the patch passed
+1 javac 1013 the patch passed
+1 checkstyle 223 the patch passed
+1 mvnsite 97 the patch passed
+1 whitespace 1 The patch has no whitespace issues.
+1 shadedclient 814 patch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1 findbugs 78 the patch passed
+1 javadoc 76 the patch passed
_ Other Tests _
-1 unit 112 container-service in the patch failed.
-1 unit 1666 integration-test in the patch failed.
+1 asflicense 54 The patch does not generate ASF License warnings.
9328
Reason Tests
Failed junit tests hadoop.ozone.container.common.TestDatanodeStateMachine
hadoop.ozone.TestContainerStateMachineIdempotency
hadoop.ozone.om.TestScmChillMode
hadoop.hdds.scm.container.TestContainerStateManagerIntegration
hadoop.ozone.TestMiniChaosOzoneCluster
hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient
hadoop.ozone.container.TestContainerReplication
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
hadoop.ozone.client.rpc.TestContainerStateMachine
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-723/1/artifact/out/Dockerfile
GITHUB PR #723
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux b8e1661b7594 4.4.0-144-generic #170~14.04.1-Ubuntu SMP Mon Mar 18 15:02:05 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / e9c4109
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-723/1/artifact/out/patch-unit-hadoop-hdds_container-service.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-723/1/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-723/1/testReport/
Max. process+thread count 3776 (vs. ulimit of 5500)
modules C: hadoop-hdds/container-service hadoop-ozone/integration-test U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-723/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Change-Id: I18bc44148b2f94493419c6126b516181d8353108
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 52 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 4 new or modified test files.
_ trunk Compile Tests _
0 mvndep 22 Maven dependency ordering for branch
+1 mvninstall 1025 trunk passed
+1 compile 1374 trunk passed
+1 checkstyle 330 trunk passed
+1 mvnsite 319 trunk passed
+1 shadedclient 1672 branch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1 findbugs 66 trunk passed
+1 javadoc 63 trunk passed
_ Patch Compile Tests _
0 mvndep 22 Maven dependency ordering for patch
+1 mvninstall 69 the patch passed
+1 compile 913 the patch passed
+1 javac 913 the patch passed
+1 checkstyle 194 the patch passed
+1 mvnsite 91 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 687 patch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1 findbugs 69 the patch passed
+1 javadoc 73 the patch passed
_ Other Tests _
-1 unit 100 container-service in the patch failed.
-1 unit 1213 integration-test in the patch failed.
+1 asflicense 52 The patch does not generate ASF License warnings.
8038
Reason Tests
Failed junit tests hadoop.ozone.container.common.TestDatanodeStateMachine
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
hadoop.ozone.client.rpc.TestBlockOutputStream
hadoop.ozone.client.rpc.TestCommitWatcher
hadoop.ozone.TestMiniOzoneCluster
hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline
hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion
hadoop.ozone.container.TestContainerReplication
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-723/2/artifact/out/Dockerfile
GITHUB PR #723
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux fd875196eebb 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / ed3747c
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-723/2/artifact/out/patch-unit-hadoop-hdds_container-service.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-723/2/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-723/2/testReport/
Max. process+thread count 3604 (vs. ulimit of 5500)
modules C: hadoop-hdds/container-service hadoop-ozone/integration-test U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-723/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Thanks to address this issue.

Unit tests are unrelated (will check if they are already followed as flaky tests...)

Acceptance test is failed due to a different problem: we have a code to wait until all the 3 datanodes are up, but no similar code for OM and MIT krb5 server (for secure config). We need to implement them but I prefer to do this after https://issues.apache.org/jira/browse/HDDS-1424

Will merge it soon.

@elek
Copy link
Member

elek commented Apr 12, 2019

Created: https://issues.apache.org/jira/browse/HDDS-1435

Both the tests have similar failures in the log (NotLeaderException...)

@elek elek closed this in abace70 Apr 12, 2019
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
vjagadish
Added `CONFIGURATIONS` under `DOCUMENTATION`
Updated `configuration.md` page to work with new configs

Do we have documentation about `SystemDescriptors` anywhere on the website?
I was thinking to add it in the `configuration.md` page otherwise.

Author: Daniel Chen <[email protected]>

Reviewers: Jagadish<[email protected]>

Closes apache#723 from dxichen/add-configs-to-website
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants