HDDS-1192. Support -conf command line argument in GenericCli #713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/label ozone |
|
/retest |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
kittinanasi
force-pushed
the
HDDS-1192
branch
2 times, most recently
from
335811f to
38e5b23
Compare
|
💔 -1 overall
This message was automatically generated. |
elek
reviewed
Apr 17, 2019
There was a problem hiding this comment.
Thanks a lot the patch @kittinanasi This is a big step forward to start full Ozone cluster from any IDE. I tested and worked well (without adding ozone-site.xml to the classpath!)
Overall it looks good to me. I like it. I have one minor proposal to simplify the change (I think we can do exactly the same without adding the new method GenericParentCommand. Which is not a big deal but we need to add the new method to all the subcommands).
With that approach initConf also can be removed and all the HddsDatanodeService.createHddsDatanodeService can be simplified...
The failure of TestAuditParser.testHelp() seems to be related (the output of the --help is asserted but now it contains the --conf. Maybe we can simplify the assertion).
There was a problem hiding this comment.
I think this part can be simplified (but fix me if I am wrong) with using two start method:
/**
* Starts HddsDatanode services.
*
* @param service The service instance invoking this method
*/
@Override
public void start(Object service) {
if (service instanceof Configurable) {
start(new OzoneConfiguration(((Configurable) service).getConf()));
} else {
start(new OzoneConfiguration());
}
}
public void start(OzoneConfiguration conf) {
this.conf = conf;
DefaultMetricsSystem.initialize("HddsDatanode");
OzoneConfiguration.activate();
if (HddsUtils.isHddsEnabled(conf)) {
In this case we don't need to add the additional method to the GenericParentCommand so it can be as simple as now.
And from the new call() method we can use the createOzoneConfiguration()
@Override
public Void call() throws Exception {
if (printBanner) {
StringUtils
.startupShutdownMessage(HddsDatanodeService.class, args, LOG);
}
start(createOzoneConfiguration());
join();
return null;
}
initConf also can be removed with this approach (IMHO)
There was a problem hiding this comment.
This is a good idea, I simplified this part, but I introduced a setConfiguration method here as well so that I don't have to modify MiniOzoneCluster that much.
There was a problem hiding this comment.
LIKE. Thanks to fix this part (and the similar items). It's better to use the included CommandLine.ParameterException...
|
💔 -1 overall
This message was automatically generated. |
|
TestOzoneAtRestEncryption test failure does not seem related. |
elek
approved these changes
Apr 24, 2019
There was a problem hiding this comment.
+1. Thanks @kittinanasi the update.
I will commit it soon (there is one checkstyle violation, I am fixing it during the commit).
Neither the acceptance tests nor the unit tests are related. All the unit tests are related to RAFT ring.
|
Thanks @elek for committing and for fixing the remaining checkstyle issue! |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
Author: Jagadish <[email protected]> Reviewers: Jagadish<[email protected]> Closes apache#713 from vjagadish1989/website-reorg11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.