-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-19255. Update io.compression.codec.lzo.buffersize to 262144 #7009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-19255. Update io.compression.codec.lzo.buffersize to 262144 #7009
Conversation
💔 -1 overall
This message was automatically generated. |
@slfan1989 , can you please have a look at it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM, pending clean CI run
I realised that CommonConfigurationKeys has defined default as 64KB which can created the issue with this default config. |
@guptashailesh92 can we've any UT for this.? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the Jira Description
From my analysis, i was pinpoint to the [change](https://github.com/apache/hadoop/pull/5912/files#diff-268b9968a4db21ac6eeb7bcaef10e4db744d00ba53989fc7251bb3e8d9eac7dfR904) which changed io.compression.codec.lzo.buffersize from 64KB to 256KB.
The configuration you are checking is io.compression.codec.lz4.buffersize
not io.compression.codec.lzo.buffersize
The one in the linked PR is LZ4 and here you are bothering LZO.
No value has changed for these configs since 2011ish, & We can't change the default value like that either unless there is some proven bug, changing defaults is an incompatible change
We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Description of PR
https://issues.apache.org/jira/browse/HADOOP-19255
Fix LZO decompression due to change in hadoop 3..4.0
How was this patch tested?
hadoop fs -text file:///home/hadoop/part-ak.lzo
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?