You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, you would get incorrect behavior in that you would always have to set dfs.client.failover.max.attempts to be +1 greater to have the desired behavior, e.g. if you want it to attempt failover exactly once, you would have to set dfs.client.failover.max.attempts=2.
Without this change, if you set dfs.client.failover.max.attempts=1, to attempt to failover just once time, instead it wouldn't try at all, and you see this log message:
org.apache.hadoop.io.retry.RetryInvocationHandler - Exception while invoking class org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getFileInfo over hadoop-node-01.docker.infra.atscale.com/127.0.0.21:8020. Not retrying because failovers (1) exceeded maximum allowed (1)
Note that the non-failover retries just below this change is correct.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1027
trunk passed
+1
compile
979
trunk passed
+1
checkstyle
46
trunk passed
+1
mvnsite
72
trunk passed
+1
shadedclient
753
branch has no errors when building and testing our client artifacts.
+1
findbugs
95
trunk passed
+1
javadoc
55
trunk passed
_ Patch Compile Tests _
+1
mvninstall
43
the patch passed
+1
compile
936
the patch passed
+1
javac
936
the patch passed
+1
checkstyle
52
the patch passed
+1
mvnsite
77
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
655
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1025
trunk passed
+1
compile
1026
trunk passed
+1
checkstyle
44
trunk passed
+1
mvnsite
81
trunk passed
+1
shadedclient
760
branch has no errors when building and testing our client artifacts.
+1
javadoc
59
trunk passed
0
spotbugs
116
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
115
trunk passed
_ Patch Compile Tests _
+1
mvninstall
45
the patch passed
+1
compile
1082
the patch passed
+1
javac
1082
the patch passed
+1
checkstyle
39
the patch passed
+1
mvnsite
69
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
606
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1058
trunk passed
+1
compile
1125
trunk passed
+1
checkstyle
40
trunk passed
+1
mvnsite
75
trunk passed
+1
shadedclient
796
branch has no errors when building and testing our client artifacts.
+1
javadoc
61
trunk passed
0
spotbugs
123
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
122
trunk passed
_ Patch Compile Tests _
+1
mvninstall
50
the patch passed
+1
compile
1097
the patch passed
+1
javac
1097
the patch passed
+1
checkstyle
38
the patch passed
+1
mvnsite
72
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
629
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1222
trunk passed
+1
compile
1160
trunk passed
+1
checkstyle
44
trunk passed
+1
mvnsite
81
trunk passed
+1
shadedclient
885
branch has no errors when building and testing our client artifacts.
+1
javadoc
63
trunk passed
0
spotbugs
128
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
126
trunk passed
_ Patch Compile Tests _
+1
mvninstall
51
the patch passed
+1
compile
1113
the patch passed
+1
javac
1113
the patch passed
+1
checkstyle
45
the patch passed
+1
mvnsite
76
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
757
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1226
trunk passed
+1
compile
1122
trunk passed
+1
checkstyle
48
trunk passed
+1
mvnsite
89
trunk passed
+1
shadedclient
940
branch has no errors when building and testing our client artifacts.
+1
javadoc
66
trunk passed
0
spotbugs
133
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
131
trunk passed
_ Patch Compile Tests _
+1
mvninstall
48
the patch passed
+1
compile
1067
the patch passed
+1
javac
1067
the patch passed
+1
checkstyle
49
the patch passed
+1
mvnsite
86
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
743
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1090
trunk passed
+1
compile
1192
trunk passed
+1
checkstyle
42
trunk passed
+1
mvnsite
78
trunk passed
+1
shadedclient
756
branch has no errors when building and testing our client artifacts.
+1
javadoc
61
trunk passed
0
spotbugs
118
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
116
trunk passed
_ Patch Compile Tests _
+1
mvninstall
46
the patch passed
+1
compile
1061
the patch passed
+1
javac
1061
the patch passed
+1
checkstyle
36
the patch passed
+1
mvnsite
72
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
650
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1276
trunk passed
+1
compile
1071
trunk passed
+1
checkstyle
42
trunk passed
+1
mvnsite
80
trunk passed
+1
shadedclient
844
branch has no errors when building and testing our client artifacts.
+1
javadoc
66
trunk passed
0
spotbugs
124
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
122
trunk passed
_ Patch Compile Tests _
+1
mvninstall
49
the patch passed
+1
compile
1114
the patch passed
+1
javac
1114
the patch passed
+1
checkstyle
48
the patch passed
+1
mvnsite
89
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
750
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1050
trunk passed
+1
compile
1143
trunk passed
+1
checkstyle
39
trunk passed
+1
mvnsite
70
trunk passed
+1
shadedclient
739
branch has no errors when building and testing our client artifacts.
+1
javadoc
56
trunk passed
0
spotbugs
110
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
107
trunk passed
_ Patch Compile Tests _
+1
mvninstall
43
the patch passed
+1
compile
1027
the patch passed
+1
javac
1027
the patch passed
+1
checkstyle
37
the patch passed
+1
mvnsite
66
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
646
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1109
trunk passed
+1
compile
1050
trunk passed
+1
checkstyle
37
trunk passed
+1
mvnsite
71
trunk passed
+1
shadedclient
749
branch has no errors when building and testing our client artifacts.
+1
javadoc
60
trunk passed
0
spotbugs
118
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
116
trunk passed
_ Patch Compile Tests _
+1
mvninstall
44
the patch passed
+1
compile
1027
the patch passed
+1
javac
1027
the patch passed
+1
checkstyle
39
the patch passed
+1
mvnsite
72
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
671
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1207
trunk passed
+1
compile
1133
trunk passed
+1
checkstyle
42
trunk passed
+1
mvnsite
79
trunk passed
+1
shadedclient
864
branch has no errors when building and testing our client artifacts.
+1
javadoc
65
trunk passed
0
spotbugs
125
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
123
trunk passed
_ Patch Compile Tests _
+1
mvninstall
48
the patch passed
+1
compile
1080
the patch passed
+1
javac
1080
the patch passed
+1
checkstyle
45
the patch passed
+1
mvnsite
73
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
729
patch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1
mvninstall
1251
trunk passed
+1
compile
1118
trunk passed
+1
checkstyle
45
trunk passed
+1
mvnsite
77
trunk passed
+1
shadedclient
862
branch has no errors when building and testing our client artifacts.
+1
javadoc
72
trunk passed
0
spotbugs
147
Used deprecated FindBugs config; considering switching to SpotBugs.
+1
findbugs
144
trunk passed
_ Patch Compile Tests _
+1
mvninstall
58
the patch passed
+1
compile
1143
the patch passed
+1
javac
1143
the patch passed
+1
checkstyle
50
the patch passed
+1
mvnsite
84
the patch passed
+1
whitespace
0
The patch has no whitespace issues.
+1
shadedclient
737
patch has no errors when building and testing our client artifacts.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change, you would get incorrect behavior in that you would always have to set
dfs.client.failover.max.attempts
to be +1 greater to have the desired behavior, e.g. if you want it to attempt failover exactly once, you would have to setdfs.client.failover.max.attempts=2
.Without this change, if you set
dfs.client.failover.max.attempts=1
, to attempt to failover just once time, instead it wouldn't try at all, and you see this log message:Note that the non-failover retries just below this change is correct.