HADOOP-19222. Switch yum repo baseurl due to CentOS 7 sunset #6932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(!) A patch to the testing environment has been detected. |
pan3793
commented
Jul 9, 2024
| cd /etc/yum.repos.d/ || exit && | ||
| sed -i 's/mirrorlist/#mirrorlist/g' /etc/yum.repos.d/CentOS-* && | ||
| sed -i 's|#baseurl=http://mirror.centos.org|baseurl=http://vault.centos.org|g' /etc/yum.repos.d/CentOS-* && | ||
| sed -i 's|# *baseurl=http://mirror.centos.org|baseurl=http://vault.centos.org|g' /etc/yum.repos.d/CentOS-* && |
There was a problem hiding this comment.
change is necessary, this makes it support both
#baseurl=http://mirror.centos.org/...
# baseurl=http://mirror.centos.org/...
|
💔 -1 overall
This message was automatically generated. |
|
investigation: Yetus failed to create user "jenkins" on building run-specific image yetus/hadoop:tp-11600 this should be a Yetus side issue, and I suppose it has been broken for a while ... the corresponding code should be https://github.com/apache/yetus/blob/23ddb4e106785effb2e1154aed65329f722bfabe/precommit/src/main/shell/test-patch-docker/Dockerfile.patchspecific#L31 due to the incorrectly setup for user "jenkins", the PATH env is abnormal, then commands like |
|
I have less knowledge of Yetus, not sure how to fix and verify that. For reviewers, this PR change is orthogonal to the Yetus issue, it fixes the CentOS 7 YUM repo resolving issues. I lean toward merging it first (though Yetus is not happy ...) and then fixing the Yetus issue later. |
|
not my area of knowledge at all...can anyone else take a look at this? |
|
@GauthamBanasandra Can you help take a look at this issue? Thank you very much! |
|
(!) A patch to the testing environment has been detected. |
|
(!) A patch to the testing environment has been detected. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
|
🎊 +1 overall
This message was automatically generated. |
|
(!) A patch to the testing environment has been detected. |
4 tasks
pan3793
commented
Jul 10, 2024
dev-support/jenkins.sh
Outdated
| # don't let these tests cause -1s because we aren't really paying that | ||
| # much attention to them | ||
| YETUS_ARGS+=("--tests-filter=checkstyle") | ||
| YETUS_ARGS+=("--tests-filter=checkstyle,test4tests") |
There was a problem hiding this comment.
I opened HADOOP-19223 (#6937) to make this change independently.
There was a problem hiding this comment.
Okay, test passed, let me revert this change.
|
🎊 +1 overall
This message was automatically generated. |
LGTM +1 It's still concerning when these situations arise. Previously, I've had to roll back PRs twice due to this issue. |
slfan1989
reviewed
Jul 10, 2024
| # Apply the script again because centos-release-scl creates new YUM repo files | ||
| RUN pkg-resolver/set-vault-as-baseurl-centos.sh centos:7 | ||
|
|
||
| # hadolint ignore=DL3008,SC2046 |
There was a problem hiding this comment.
I readed our previous Dockerfiles and found that DL3008 and SC2046 were not ignored. Why we should ignore these two rules here?
There was a problem hiding this comment.
the hadolint rule codes can be found at https://github.com/hadolint/hadolint?tab=readme-ov-file#rules
pan3793
commented
Jul 11, 2024
|
(!) A patch to the testing environment has been detected. |
|
The last change after approval is d59e005, this patch is ready to go. |
|
💔 -1 overall
This message was automatically generated. |
slfan1989
approved these changes
Jul 11, 2024
|
@pan3793 Thanks for the contribution! @GauthamBanasandra Thanks for the review! |
slfan1989
pushed a commit
that referenced
this pull request
Jul 11, 2024
…Contributed by Cheng Pan. Reviewed-by: Gautham Banasandra <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
KeeProMise
pushed a commit
to KeeProMise/hadoop
that referenced
this pull request
Sep 9, 2024
…6932) Contributed by Cheng Pan. Reviewed-by: Gautham Banasandra <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
Hexiaoqiao
pushed a commit
to Hexiaoqiao/hadoop
that referenced
this pull request
Sep 12, 2024
…6932) Contributed by Cheng Pan. Reviewed-by: Gautham Banasandra <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: HADOOP-19222. Switch yum repo baseurl due to CentOS 7 sunset.
Similar to HADOOP-18151 (which handled sunset for CentOS 8), CentOS 7 reached EOL on July 1, 2024
How was this patch tested?
This change will trigger Yetus to run the native library building.
Without this change, the CentOS 7 CI fails with:
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?