HDDS-1382. Create customized CSI server for Ozone. #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyuyao
reviewed
Apr 17, 2019
hadoop-ozone/csi/src/main/java/org/apache/hadoop/ozone/csi/CsiServer.java
Outdated
Show resolved
Hide resolved
xiaoyuyao
reviewed
Apr 17, 2019
Contributor
There was a problem hiding this comment.
Can we make 1000_000_000 configurable?
xiaoyuyao
reviewed
Apr 17, 2019
Contributor
There was a problem hiding this comment.
NIT: LOG.info("Executing {}", mountCommand);
xiaoyuyao
reviewed
Apr 17, 2019
Contributor
There was a problem hiding this comment.
NIT: LOG.info("Executing {}", umountCommand);
Contributor
|
Thanks @elek for working on this, the change LGTM overall, just few minor comments. |
|
💔 -1 overall
This message was automatically generated. |
ajayydv
reviewed
May 21, 2019
Member
Author
There was a problem hiding this comment.
Thanks. Removed the modification of ozone-default.xml as I switched to use the annotation based configs.
ajayydv
reviewed
May 21, 2019
Contributor
There was a problem hiding this comment.
tmp directory might be emptied by admins and others without knowledge of this file.
Member
Author
There was a problem hiding this comment.
AFAIK it shouldn't be a problem. This is a socket which is created by the process to listen on and even if it's deleted the socket will work well (until the close).
But I modified it to /var/lib/csi.sock. It can be more meaningful (and maybe more safe If my previous statement is wrong ;-) )
ajayydv
reviewed
May 21, 2019
Contributor
There was a problem hiding this comment.
shall we use the new config annotations instead?
Member
Author
There was a problem hiding this comment.
Absolutely. I uploaded a new version with config annotations.
ajayydv
reviewed
May 21, 2019
Contributor
|
@elek thanks for the patch. LGTM, added few comments. Seems this needs a rebase as well. |
|
💔 -1 overall
This message was automatically generated. |
Contributor
|
+1, @elek Can you please fix the checkstyle issues while committing ? Thanks |
Member
Author
|
Thanks the review @anuengineer I am merging it right now (checkstyle issues are fixed). And we can continue the work:
|
|
💔 -1 overall
This message was automatically generated. |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
…vel API Author: Prateek Maheshwari <[email protected]> Reviewers: Yi Pan <[email protected]>, Jagadish Venkataraman <[email protected]> Closes apache#693 from prateekm/intermediate-stream-serde
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://issues.apache.org/jira/browse/HDDS-1382 for more details..