-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-19065. Update Protocol Buffers installation to 3.21.12 #6576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-19065. Update Protocol Buffers installation to 3.21.12 #6576
Conversation
(!) A patch to the testing environment has been detected. |
146f9dc
to
6015e99
Compare
(!) A patch to the testing environment has been detected. |
Message error, pushed twice, ignored. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
-1 You don't need to submit such changes. After the release of hadoop-3.4.0, I will uniformly adjust the release compilation script. |
@slfan1989 Discussed in JIRA: https://issues.apache.org/jira/browse/HADOOP-19065 cc @steveloughran |
I temporarily don't support porting this to the hadoop-3.4.0 branch. I've spent a lot of time setting up the compilation environment, and I don't want to introduce any additional issues. |
OK, understand. |
I will try to use this change on the Centos 7.9 I prepared, including x86 & arm, and hope it goes well. I will +1 if it passes. |
While I'd like to do this after releasing hadoop-3.4.0, @tasanuma makes a valid point. Since we already support protobuf 3.21.12 in hadoop-thirdparty 1.2.0, we should try to make this change now. cc: @steveloughran |
I concur |
I've created https://issues.apache.org/jira/browse/HADOOP-19087 as the JIRA for follow-on stuff for 3.4.1, which is going to mainly be packaging/jar changes. let's target that one with this |
@huangzhaobo99 Thanks for the contribution! @steveloughran Thanks for the review! |
@slfan1989 Thanks for your verification and merging work, @steveloughran Thanks for your review. |
Description of PR
JIRA: https://issues.apache.org/jira/browse/HADOOP-19065
Instructions and docker script for installing protobuf updated from 3.7.1 to 3.21.12