Skip to content

HDFS-17390. [FGL] FSDirectory supports this fine-grained locking #6573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2024
Merged

HDFS-17390. [FGL] FSDirectory supports this fine-grained locking #6573

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions ...project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
*/
package org.apache.hadoop.hdfs.server.namenode;

import org.apache.hadoop.hdfs.server.namenode.fgl.FSNamesystemLockMode;
import org.apache.hadoop.hdfs.server.namenode.snapshot.Snapshot;
import org.apache.hadoop.util.StringUtils;

Expand Down Expand Up @@ -261,27 +262,31 @@ public void setINodeAttributeProvider(
* remain as placeholders only
*/
void readLock() {
assert namesystem.hasReadLock() : "Should hold namesystem read lock";
assert namesystem.hasReadLock(FSNamesystemLockMode.FS) :
"Should hold read lock of namesystem FSLock";
}

void readUnlock() {
assert namesystem.hasReadLock() : "Should hold namesystem read lock";
assert namesystem.hasReadLock(FSNamesystemLockMode.FS) :
"Should hold read lock of namesystem FSLock";
}

void writeLock() {
assert namesystem.hasWriteLock() : "Should hold namesystem write lock";
assert namesystem.hasWriteLock(FSNamesystemLockMode.FS) :
"Should hold write lock of namesystem FSLock";
}

void writeUnlock() {
assert namesystem.hasWriteLock() : "Should hold namesystem write lock";
assert namesystem.hasWriteLock(FSNamesystemLockMode.FS) :
"Should hold write lock of namesystem FSLock";
}

boolean hasWriteLock() {
return namesystem.hasWriteLock();
return namesystem.hasWriteLock(FSNamesystemLockMode.FS);
}

boolean hasReadLock() {
return namesystem.hasReadLock();
return namesystem.hasReadLock(FSNamesystemLockMode.FS);
}

public int getListLimit() {
Expand Down