Skip to content

Conversation

@mukund-thakur
Copy link
Contributor

Just a backport to branch-3.3 because of merged conflicts. Let Yetus run the tests.

Description of PR

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

…isk of Timeout waiting for connection from pool. (apache#6372)

HADOOP-19015.  Increase fs.s3a.connection.maximum to 500 to minimize the risk of Timeout waiting for connection from the pool

Contributed By: Mukund Thakur
 Conflicts:
	hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
	hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java
	hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/performance.md
@mukund-thakur
Copy link
Contributor Author

Should we merge this in branch-3.3 given we are seeing these issues more after V2 SDK? @steveloughran @ahmarsuhail

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-3.3 Compile Tests _
+0 🆗 mvndep 13m 41s Maven dependency ordering for branch
+1 💚 mvninstall 35m 12s branch-3.3 passed
+1 💚 compile 18m 40s branch-3.3 passed
+1 💚 checkstyle 2m 43s branch-3.3 passed
+1 💚 mvnsite 2m 38s branch-3.3 passed
+1 💚 javadoc 1m 39s branch-3.3 passed
+1 💚 spotbugs 3m 55s branch-3.3 passed
+1 💚 shadedclient 36m 38s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 30s Maven dependency ordering for patch
+1 💚 mvninstall 1m 40s the patch passed
+1 💚 compile 17m 58s the patch passed
+1 💚 javac 17m 58s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 2m 41s the patch passed
+1 💚 mvnsite 2m 35s the patch passed
+1 💚 javadoc 1m 26s the patch passed
+1 💚 spotbugs 4m 14s the patch passed
+1 💚 shadedclient 36m 29s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 18m 4s hadoop-common in the patch passed.
+1 💚 unit 2m 44s hadoop-aws in the patch passed.
+1 💚 asflicense 0m 56s The patch does not generate ASF License warnings.
209m 36s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6487/1/artifact/out/Dockerfile
GITHUB PR #6487
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle markdownlint
uname Linux d9eab37c7d6a 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / 6d23e36
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu118.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6487/1/testReport/
Max. process+thread count 3150 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6487/1/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran
Copy link
Contributor

+1 from me, but as its a backport you can self-approve

@mukund-thakur mukund-thakur merged commit 11d622d into apache:branch-3.3 Jan 25, 2024
@mukund-thakur
Copy link
Contributor Author

+1 from me, but as its a backport you can self-approve

Oh I see. thanks. I can't really approve but I can merge. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants