Skip to content

Conversation

@pan3793
Copy link
Member

@pan3793 pan3793 commented Jan 17, 2024

This reverts commit 2c4ab72.

Description of PR

TL;DR, it generate the wrong source code and messes the code jump in IDEA.

See details in https://issues.apache.org/jira/browse/HADOOP-16822

How was this patch tested?

Pass CI.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

… Contributed by Karel Kolman."

This reverts commit 2c4ab72.
@pan3793
Copy link
Member Author

pan3793 commented Jan 17, 2024

cc @jojochuang @steveloughran

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 60m 0s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 xmllint 0m 1s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 47m 43s trunk passed
+1 💚 compile 0m 21s trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚 compile 0m 21s trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚 mvnsite 0m 25s trunk passed
+1 💚 javadoc 0m 25s trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 23s trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚 shadedclient 86m 44s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 7m 21s the patch passed
+1 💚 compile 0m 13s the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚 javac 0m 13s the patch passed
+1 💚 compile 0m 13s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚 javac 0m 13s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 15s the patch passed
+1 💚 javadoc 0m 14s the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 13s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚 shadedclient 38m 7s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 18s hadoop-client-api in the patch passed.
+1 💚 asflicense 0m 34s The patch does not generate ASF License warnings.
197m 55s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6458/1/artifact/out/Dockerfile
GITHUB PR #6458
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname Linux 41ba3b906dea 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 34a7bca
Default Java Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6458/1/testReport/
Max. process+thread count 566 (vs. ulimit of 5500)
modules C: hadoop-client-modules/hadoop-client-api U: hadoop-client-modules/hadoop-client-api
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6458/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@pan3793
Copy link
Member Author

pan3793 commented Jan 21, 2024

Also cc @pjfanning @Hexiaoqiao

@pan3793
Copy link
Member Author

pan3793 commented Mar 8, 2024

I think we already reached the consensus in the JIRA discussion, could any committer take a look?

cc @slfan1989 @sunchao

Copy link
Contributor

@cxzl25 cxzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pan3793
Copy link
Member Author

pan3793 commented Apr 7, 2024

cc @aajisaka @steveloughran

@steveloughran steveloughran merged commit 281e2d2 into apache:trunk Apr 10, 2024
@steveloughran
Copy link
Contributor

done, though as I pressed sent I realised the title had pulled line #2 up; sorry.

will cherrypick to 3.4

steveloughran pushed a commit that referenced this pull request Apr 10, 2024
… Contributed by Karel Kolman." (#6458)

This reverts commit 2c4ab72.

Justification: this was making debugging through IDEs worse, rather than better.
@steveloughran
Copy link
Contributor

merged to 3.4; branch-3.3 had conflicts. @pan3793 if you want it there, create another PR so yetus can validate it. thanks!

pan3793 added a commit to pan3793/hadoop that referenced this pull request Apr 10, 2024
… Contributed by Karel Kolman." (apache#6458)

This reverts commit 2c4ab72.

Justification: this was making debugging through IDEs worse, rather than better.
steveloughran pushed a commit that referenced this pull request Apr 11, 2024
… Contributed by Karel Kolman." (#6458)


This reverts commit 2c4ab72.

Justification: this was making debugging through IDEs worse, rather than better.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants