-
Notifications
You must be signed in to change notification settings - Fork 9.1k
YARN-11639. CME and NPE in PriorityUtilizationQueueOrderingPolicy #6455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, added a comment.
...server/resourcemanager/scheduler/capacity/policy/PriorityUtilizationQueueOrderingPolicy.java
Outdated
Show resolved
Hide resolved
…ationQueueOrderingPolicy
|
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Thanks @ferdelyi for the patch, @tomicooler for the review. Merging to trunk. |
|
@brumi1024 and @tomicooler thank you for both of you the review. |
Description of PR
ConcurrentModificationException and NPE in PriorityUtilizationQueueOrderingPolicy issue was resolved by sorting the snapshot of the queues.
How was this patch tested?
With a load test making sure that the dynamic queue deletion event frequently coincides with the assignment iterator.
Since it is a concurrency issue, there is no unit test for this change.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?