Skip to content

Conversation

@slfan1989
Copy link
Contributor

@slfan1989 slfan1989 commented Jan 11, 2024

Description of PR

JIRA: HADOOP-19034. Fix Download Maven Url Not Found.

In the process of preparing Hadoop 3.4.0 Release, I found that when opening the link to download maven, it will prompt not found. We need to fix this issue.

wget 'https://dlcdn.apache.org/maven/maven-3/3.6.3/binaries/apache-maven-3.6.3-bin.tar.gz'

Not Found
The requested URL was not found on this server.

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 17m 41s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 13m 52s Maven dependency ordering for branch
+1 💚 mvninstall 36m 36s trunk passed
+1 💚 mvnsite 0m 0s trunk passed
+1 💚 shadedclient 36m 17s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 29s Maven dependency ordering for patch
+1 💚 mvninstall 0m 0s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 0s the patch passed
+1 💚 shellcheck 0m 1s No new issues.
+1 💚 shadedclient 36m 35s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 32s The patch does not generate ASF License warnings.
146m 27s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6438/1/artifact/out/Dockerfile
GITHUB PR #6438
Optional Tests dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs
uname Linux d6c0078af564 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / c3e36ed
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6438/1/testReport/
Max. process+thread count 535 (vs. ulimit of 5500)
modules C: U:
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6438/1/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@steveloughran steveloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.

tested the curl command locally and it works

Copy link
Contributor

@Hexiaoqiao Hexiaoqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1. Check this link and command works fine at local.

@Hexiaoqiao Hexiaoqiao merged commit 0f8b74b into apache:trunk Jan 14, 2024
@Hexiaoqiao
Copy link
Contributor

Merged. Thanks @slfan1989 and @steveloughran .

Hexiaoqiao pushed a commit that referenced this pull request Jan 14, 2024
…by Shilun Fan.

Reviewed-by: Steve Loughran <[email protected]>
Signed-off-by: He Xiaoqiao <[email protected]>
(cherry picked from commit 0f8b74b)
Hexiaoqiao pushed a commit that referenced this pull request Jan 14, 2024
…by Shilun Fan.

Reviewed-by: Steve Loughran <[email protected]>
Signed-off-by: He Xiaoqiao <[email protected]>
(cherry picked from commit 0f8b74b)
@slfan1989
Copy link
Contributor Author

@Hexiaoqiao @steveloughran Thanks for reviewing the code!

@steveloughran
Copy link
Contributor

FWIW I think I just aggregated things like this into the general "release" JIRA so been able to push stuff through without so much effort.

jiajunmao pushed a commit to jiajunmao/hadoop-MLEC that referenced this pull request Feb 6, 2024
…buted by Shilun Fan.

Reviewed-by: Steve Loughran <[email protected]>
Signed-off-by: He Xiaoqiao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants