HDFS-17312. packetsReceived metric should ignore heartbeat packet. #6394

hfutatzhanghb · 2023-12-30T15:55:38Z

Description of PR

Metric packetsReceived should ignore heartbeat packet and only used to count data packets and last packet in block.

As the above documatation shows, Its original goal is counting total packets received by DataNode excluding heartbeat packet from client. We should fix it.

hadoop-yetus · 2023-12-30T21:42:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 30s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 40s		trunk passed
+1 💚	compile	1m 17s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	compile	1m 9s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	checkstyle	1m 6s		trunk passed
+1 💚	mvnsite	1m 21s		trunk passed
+1 💚	javadoc	1m 5s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 39s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
-1 ❌	spotbugs	3m 12s	/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html	hadoop-hdfs-project/hadoop-hdfs in trunk has 1 extant spotbugs warnings.
+1 💚	shadedclient	34m 25s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 9s		the patch passed
+1 💚	compile	1m 11s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javac	1m 11s		the patch passed
+1 💚	compile	1m 3s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	javac	1m 3s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 56s		the patch passed
+1 💚	mvnsite	1m 11s		the patch passed
+1 💚	javadoc	0m 50s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 29s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	spotbugs	3m 10s		the patch passed
+1 💚	shadedclient	35m 2s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	211m 7s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 42s		The patch does not generate ASF License warnings.
		345m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6394/1/artifact/out/Dockerfile
GITHUB PR	#6394
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux f0781619503a 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `d70974d`
Default Java	Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6394/1/testReport/
Max. process+thread count	3227 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6394/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hfutatzhanghb · 2023-12-31T01:05:37Z

@Hexiaoqiao @zhangshuyan0 @tomscut @tasanuma Sir, could you please review this simple modification when you are free ?

hotcodemacha

Can you check if there any other parts of the system that might rely on the current behavior of the packetsReceived metric including heartbeat packets? We need to ensure this change doesn't inadvertently affect other functionalities.

Testing and Validation: Can you confirm if there are existing tests that cover this change or if new tests are needed? It's essential to validate that this modification behaves as expected in various scenarios, including edge cases.

...-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java

hfutatzhanghb · 2024-01-01T01:47:05Z

Can you check if there any other parts of the system that might rely on the current behavior of the packetsReceived metric including heartbeat packets? We need to ensure this change doesn't inadvertently affect other functionalities.

Testing and Validation: Can you confirm if there are existing tests that cover this change or if new tests are needed? It's essential to validate that this modification behaves as expected in various scenarios, including edge cases.

Hi, @ashutoshcipher. Sir. Thanks for your replying. I have checked other parts which using packetsReceived metrics. There are no parts or functionalities rely on the current behavior of the packetsReceived metric including heartbeat packets. We use find in path to search packetsReceived in all hadoop codes.

hfutatzhanghb · 2024-01-01T02:04:15Z

@Hexiaoqiao @zhangshuyan0 @ashutoshcipher Sir, have updated this PR's description. Please take a look

hadoop-yetus · 2024-01-01T11:28:02Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 30s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 25s		trunk passed
+1 💚	compile	1m 17s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	compile	1m 12s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	checkstyle	1m 6s		trunk passed
+1 💚	mvnsite	1m 18s		trunk passed
+1 💚	javadoc	1m 6s		trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 36s		trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
-1 ❌	spotbugs	3m 10s	/branch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html	hadoop-hdfs-project/hadoop-hdfs in trunk has 1 extant spotbugs warnings.
+1 💚	shadedclient	34m 33s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 7s		the patch passed
+1 💚	compile	1m 10s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javac	1m 10s		the patch passed
+1 💚	compile	1m 4s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	javac	1m 4s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 56s		the patch passed
+1 💚	mvnsite	1m 10s		the patch passed
+1 💚	javadoc	0m 51s		the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 29s		the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08
+1 💚	spotbugs	3m 13s		the patch passed
+1 💚	shadedclient	34m 10s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	212m 56s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 42s		The patch does not generate ASF License warnings.
		346m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6394/2/artifact/out/Dockerfile
GITHUB PR	#6394
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 4156fe6a1694 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `9ef6f72`
Default Java	Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6394/2/testReport/
Max. process+thread count	5099 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6394/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

tasanuma

Thanks for reporting the issue. I think the change is appropriate. I also agree that there is no other parts that relies on the current code. +1.

tasanuma · 2024-01-11T13:05:19Z

The spotbugs warning is not related to this PR.

tasanuma · 2024-01-11T13:10:03Z

Thanks for your contribution, @hfutatzhanghb. Thanks for your comments, @ashutoshcipher.

hfutatzhanghb · 2024-01-11T13:15:15Z

@tasanuma Sir, thanks a lot for your reviewing and merging~ @ashutoshcipher Thanks for your reviewing~

hfutatzhanghb · 2024-01-11T13:18:17Z

Thanks for your contribution, @hfutatzhanghb. Thanks for your comments, @ashutoshcipher.

@tasanuma Hi, sir. BTW, could you please add ‘Contributed by xxx’ in the commit message . hahaha~

…6394) Signed-off-by: Takanobu Asanuma <[email protected]> (cherry picked from commit 6a05376)

tasanuma · 2024-01-11T14:27:11Z

I believe the author of the commit, that can be confirmed by git log, is undoubtedly the contributor of the commit, so I haven't been including names in the commit messages. But if you prefer, I'll include your name from the next time. :)

hfutatzhanghb · 2024-01-11T14:55:37Z

I believe the author of the commit, that can be confirmed by git log, is undoubtedly the contributor of the commit, so I haven't been including names in the commit messages. But if you prefer, I'll include your name from the next time. :)

HaHa, Sir, thanks a lot for replying, It's all Okay for you whether including or not including nick name in commit message. I just like the nick "farmmamba"~ Thanks again~

…6394) Signed-off-by: Takanobu Asanuma <[email protected]> (cherry picked from commit 6a05376)

…pache#6394) Signed-off-by: Takanobu Asanuma <[email protected]>

HDFS-17312. packetsReceived metric should ignore heartbeat packet

d70974d

github-actions bot added HDFS trunk labels Dec 30, 2023

hotcodemacha suggested changes Dec 31, 2023

View reviewed changes

...-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockReceiver.java Show resolved Hide resolved

hfutatzhanghb requested a review from hotcodemacha January 1, 2024 02:02

trigger yetus.

9ef6f72

tasanuma approved these changes Jan 11, 2024

View reviewed changes

tasanuma merged commit 6a05376 into apache:trunk Jan 11, 2024

tasanuma pushed a commit that referenced this pull request Jan 11, 2024

HDFS-17312. packetsReceived metric should ignore heartbeat packet. (#…

3bb2ee6

…6394) Signed-off-by: Takanobu Asanuma <[email protected]> (cherry picked from commit 6a05376)

hfutatzhanghb deleted the HDFS-17312 branch January 11, 2024 13:23

tasanuma pushed a commit that referenced this pull request Jan 15, 2024

HDFS-17312. packetsReceived metric should ignore heartbeat packet. (#…

70f06d7

…6394) Signed-off-by: Takanobu Asanuma <[email protected]> (cherry picked from commit 6a05376)

jiajunmao pushed a commit to jiajunmao/hadoop-MLEC that referenced this pull request Feb 6, 2024

HDFS-17312. packetsReceived metric should ignore heartbeat packet. (a…

589ab9a

…pache#6394) Signed-off-by: Takanobu Asanuma <[email protected]>

Uh oh!

HDFS-17312. packetsReceived metric should ignore heartbeat packet. #6394

HDFS-17312. packetsReceived metric should ignore heartbeat packet. #6394

Uh oh!

Conversation

hfutatzhanghb commented Dec 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Uh oh!

hadoop-yetus commented Dec 30, 2023

Uh oh!

hfutatzhanghb commented Dec 31, 2023

Uh oh!

hotcodemacha left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hfutatzhanghb commented Jan 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hfutatzhanghb commented Jan 1, 2024

Uh oh!

hadoop-yetus commented Jan 1, 2024

Uh oh!

tasanuma left a comment

Choose a reason for hiding this comment

Uh oh!

tasanuma commented Jan 11, 2024

Uh oh!

tasanuma commented Jan 11, 2024

Uh oh!

hfutatzhanghb commented Jan 11, 2024

Uh oh!

hfutatzhanghb commented Jan 11, 2024

Uh oh!

tasanuma commented Jan 11, 2024

Uh oh!

hfutatzhanghb commented Jan 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hfutatzhanghb commented Dec 30, 2023 •

edited

Loading

hfutatzhanghb commented Jan 1, 2024 •

edited

Loading