Skip to content

HADOOP-18823. Add Labeler Github Action. #5874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 24, 2023
Merged

HADOOP-18823. Add Labeler Github Action. #5874

merged 5 commits into from
Jul 24, 2023

Conversation

@ayushtkn
Copy link
Member

@ayushtkn ayushtkn commented Jul 22, 2023 •
edited
Loading

Description of PR

Add Labeler Github Action
https://github.com/marketplace/actions/labeler

How was this patch tested?

My Fork: https://github.com/ayushtkn/hadoop/pulls

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 yamllint 0m 0s yamllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 shadedclient 30m 6s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 shadedclient 20m 33s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 30s The patch does not generate ASF License warnings.
54m 5s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5874/1/artifact/out/Dockerfile
GITHUB PR #5874
Optional Tests dupname asflicense codespell detsecrets yamllint
uname Linux 182028e78cdb 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / d4c55e6
Max. process+thread count 554 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5874/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@ayushtkn
Copy link
Member Author

Result can be checked from my fork:
https://github.com/ayushtkn/hadoop/pulls

Hexiaoqiao
Hexiaoqiao reviewed Jul 22, 2023
View reviewed changes
Copy link
Contributor

@Hexiaoqiao Hexiaoqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great feature. leave nit comment inline, not blocker issues.
+1 from my side.

.github/labeler.yml Outdated
- hadoop-hdfs-project/**
RBF:
- hadoop-hdfs-project/hadoop-hdfs-rbf/**
HDFS-NATIVE:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show NATIVE name include hdfs-native and common-native(hadoop-common-project/hadoop-common/src/main/native) together?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

.github/labeler.yml
@@ -0,0 +1,54 @@
#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blank here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@ayushtkn
Copy link
Member Author

Thanx @Hexiaoqiao for the review, have addressed the comments.
Example PR from my fork: ayushtkn#8

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 yamllint 0m 0s yamllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 shadedclient 30m 5s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 shadedclient 20m 32s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 30s The patch does not generate ASF License warnings.
54m 20s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5874/5/artifact/out/Dockerfile
GITHUB PR #5874
Optional Tests dupname asflicense codespell detsecrets yamllint
uname Linux 4b41f8a5c46c 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / cfc89d2
Max. process+thread count 697 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5874/5/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Hexiaoqiao
Hexiaoqiao approved these changes Jul 23, 2023
View reviewed changes
Copy link
Contributor

@Hexiaoqiao Hexiaoqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.

@ayushtkn ayushtkn merged commit c04a17f into apache:trunk Jul 24, 2023
asfgit pushed a commit that referenced this pull request Jan 22, 2024
@ayushtkn
Revert "HADOOP-18823. Add Labeler Github Action. (#5874). Contributed…
a013f06 
… by Ayush Saxena."

This reverts commit c04a17f.

Reverted from Branch-3.4, since this commit is relevant only for trunk.
slfan1989 pushed a commit that referenced this pull request Jan 25, 2024
@ayushtkn @slfan1989
Revert "HADOOP-18823. Add Labeler Github Action. (#5874). Contributed…
c4f4ebe 
… by Ayush Saxena."

This reverts commit c04a17f.

Reverted from Branch-3.4, since this commit is relevant only for trunk.
jiajunmao pushed a commit to jiajunmao/hadoop-MLEC that referenced this pull request Feb 6, 2024
@ayushtkn @jiajunmao
HADOOP-18823. Add Labeler Github Action. (apache#5874). Contributed b…
cd89aee 
…y Ayush Saxena.

Reviewed-by: He Xiaoqiao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hexiaoqiao Hexiaoqiao Hexiaoqiao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ayushtkn @hadoop-yetus @Hexiaoqiao