Skip to content

HDDS-1196. Add a ReplicationStartTimer class. #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 8, 2019
Merged

HDDS-1196. Add a ReplicationStartTimer class. #567

merged 3 commits into from
Mar 8, 2019

Conversation

@bharatviswa504
Copy link
Contributor

No description provided.

@bharatviswa504 bharatviswa504 self-assigned this Mar 7, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 24 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
0 mvndep 13 Maven dependency ordering for branch
+1 mvninstall 1027 trunk passed
+1 compile 84 trunk passed
+1 checkstyle 32 trunk passed
+1 mvnsite 81 trunk passed
+1 shadedclient 772 branch has no errors when building and testing our client artifacts.
+1 findbugs 113 trunk passed
+1 javadoc 66 trunk passed
_ Patch Compile Tests _
0 mvndep 13 Maven dependency ordering for patch
+1 mvninstall 75 the patch passed
+1 compile 69 the patch passed
+1 javac 69 the patch passed
-0 checkstyle 25 hadoop-hdds: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)
+1 mvnsite 63 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 1 The patch has no ill-formed XML file.
+1 shadedclient 759 patch has no errors when building and testing our client artifacts.
+1 findbugs 115 the patch passed
+1 javadoc 47 the patch passed
_ Other Tests _
-1 unit 60 common in the patch failed.
+1 unit 103 server-scm in the patch passed.
+1 asflicense 24 The patch does not generate ASF License warnings.
3608
Reason Tests
Failed junit tests hadoop.hdds.security.x509.certificate.client.TestDefaultCertificateClient
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-567/1/artifact/out/Dockerfile
GITHUB PR #567
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname Linux e166862f4f8d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 618e009
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-567/1/artifact/out/diff-checkstyle-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-567/1/artifact/out/patch-unit-hadoop-hdds_common.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-567/1/testReport/
Max. process+thread count 413 (vs. ulimit of 5500)
modules C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-567/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 34 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
0 mvndep 30 Maven dependency ordering for branch
+1 mvninstall 1055 trunk passed
+1 compile 71 trunk passed
+1 checkstyle 27 trunk passed
+1 mvnsite 72 trunk passed
+1 shadedclient 696 branch has no errors when building and testing our client artifacts.
+1 findbugs 99 trunk passed
+1 javadoc 53 trunk passed
_ Patch Compile Tests _
0 mvndep 9 Maven dependency ordering for patch
+1 mvninstall 74 the patch passed
+1 compile 63 the patch passed
+1 javac 63 the patch passed
-0 checkstyle 21 hadoop-hdds: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)
+1 mvnsite 58 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 1 The patch has no ill-formed XML file.
+1 shadedclient 688 patch has no errors when building and testing our client artifacts.
+1 findbugs 114 the patch passed
+1 javadoc 54 the patch passed
_ Other Tests _
-1 unit 58 common in the patch failed.
+1 unit 104 server-scm in the patch passed.
+1 asflicense 24 The patch does not generate ASF License warnings.
3458
Reason Tests
Failed junit tests hadoop.hdds.security.x509.certificate.client.TestDefaultCertificateClient
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-567/2/artifact/out/Dockerfile
GITHUB PR #567
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname Linux fbd33c068d8a 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 618e009
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-567/2/artifact/out/diff-checkstyle-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-567/2/artifact/out/patch-unit-hadoop-hdds_common.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-567/2/testReport/
Max. process+thread count 445 (vs. ulimit of 5500)
modules C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-567/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@nandakumar131
Copy link
Contributor

Adding ReplicationBeginTimer handler should be done outside SCMChillModeManager. An event producer doesn't need to know about the event consumers. We can add the handler in StorageContainerManager, that's where we add all the handlers.

We don't have to check chillModeEnabled inside ReplicationBeginTimer, that check is already done in SCMChillModeManager.

New Thread creation in ReplicationBeginTimer can be replaced with CompletableFuture.runAsync(this::run)

@bharatviswa504
Copy link
Contributor Author

Added ChillModeHandler and only ChillModeHandler will handle the ChillModeStatus Event, and this class sets chill mode status in other classes.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 24 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 3 new or modified test files.
_ trunk Compile Tests _
0 mvndep 12 Maven dependency ordering for branch
+1 mvninstall 1042 trunk passed
+1 compile 74 trunk passed
+1 checkstyle 26 trunk passed
+1 mvnsite 66 trunk passed
+1 shadedclient 720 branch has no errors when building and testing our client artifacts.
+1 findbugs 107 trunk passed
+1 javadoc 54 trunk passed
_ Patch Compile Tests _
0 mvndep 13 Maven dependency ordering for patch
+1 mvninstall 69 the patch passed
+1 compile 72 the patch passed
+1 javac 72 the patch passed
-0 checkstyle 25 hadoop-hdds: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
+1 mvnsite 58 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 1 The patch has no ill-formed XML file.
+1 shadedclient 706 patch has no errors when building and testing our client artifacts.
-1 findbugs 49 hadoop-hdds/server-scm generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 javadoc 55 the patch passed
_ Other Tests _
-1 unit 83 common in the patch failed.
+1 unit 87 server-scm in the patch passed.
+1 asflicense 31 The patch does not generate ASF License warnings.
3503
Reason Tests
FindBugs module:hadoop-hdds/server-scm
Unread field:ChillModeHandler.java:[line 75]
Failed junit tests hadoop.hdds.security.x509.certificate.client.TestDefaultCertificateClient
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-567/4/artifact/out/Dockerfile
GITHUB PR #567
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname Linux 9b7423841cbc 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 1bc282e
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-567/4/artifact/out/diff-checkstyle-hadoop-hdds.txt
findbugs https://builds.apache.org/job/hadoop-multibranch/job/PR-567/4/artifact/out/new-findbugs-hadoop-hdds_server-scm.html
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-567/4/artifact/out/patch-unit-hadoop-hdds_common.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-567/4/testReport/
Max. process+thread count 446 (vs. ulimit of 5500)
modules C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-567/4/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@bharatviswa504 bharatviswa504 force-pushed the HDDS-1196 branch 3 times, most recently from 6c73bdf to e78ff7a Compare March 8, 2019 00:39
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 25 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 4 new or modified test files.
_ trunk Compile Tests _
0 mvndep 11 Maven dependency ordering for branch
+1 mvninstall 1090 trunk passed
+1 compile 74 trunk passed
+1 checkstyle 30 trunk passed
+1 mvnsite 69 trunk passed
+1 shadedclient 712 branch has no errors when building and testing our client artifacts.
+1 findbugs 100 trunk passed
+1 javadoc 55 trunk passed
_ Patch Compile Tests _
0 mvndep 10 Maven dependency ordering for patch
+1 mvninstall 66 the patch passed
+1 compile 69 the patch passed
+1 javac 69 the patch passed
-0 checkstyle 22 hadoop-hdds: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
+1 mvnsite 61 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 1 The patch has no ill-formed XML file.
+1 shadedclient 715 patch has no errors when building and testing our client artifacts.
+1 findbugs 120 the patch passed
+1 javadoc 48 the patch passed
_ Other Tests _
-1 unit 59 common in the patch failed.
-1 unit 101 server-scm in the patch failed.
+1 asflicense 25 The patch does not generate ASF License warnings.
3519
Reason Tests
Failed junit tests hadoop.hdds.security.x509.certificate.client.TestDefaultCertificateClient
hadoop.hdds.scm.chillmode.TestChillModeHandler
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-567/5/artifact/out/Dockerfile
GITHUB PR #567
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname Linux b72401716b6e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 064f38b
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-567/5/artifact/out/diff-checkstyle-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-567/5/artifact/out/patch-unit-hadoop-hdds_common.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-567/5/artifact/out/patch-unit-hadoop-hdds_server-scm.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-567/5/testReport/
Max. process+thread count 411 (vs. ulimit of 5500)
modules C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-567/5/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 28 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 4 new or modified test files.
_ trunk Compile Tests _
0 mvndep 24 Maven dependency ordering for branch
+1 mvninstall 1041 trunk passed
+1 compile 76 trunk passed
+1 checkstyle 31 trunk passed
+1 mvnsite 81 trunk passed
+1 shadedclient 753 branch has no errors when building and testing our client artifacts.
+1 findbugs 113 trunk passed
+1 javadoc 65 trunk passed
_ Patch Compile Tests _
0 mvndep 13 Maven dependency ordering for patch
+1 mvninstall 71 the patch passed
+1 compile 69 the patch passed
+1 javac 69 the patch passed
-0 checkstyle 24 hadoop-hdds: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
+1 mvnsite 64 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 2 The patch has no ill-formed XML file.
+1 shadedclient 751 patch has no errors when building and testing our client artifacts.
+1 findbugs 122 the patch passed
+1 javadoc 53 the patch passed
_ Other Tests _
-1 unit 58 common in the patch failed.
-1 unit 101 server-scm in the patch failed.
+1 asflicense 29 The patch does not generate ASF License warnings.
3616
Reason Tests
Failed junit tests hadoop.hdds.security.x509.certificate.client.TestDefaultCertificateClient
hadoop.hdds.scm.chillmode.TestChillModeHandler
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-567/7/artifact/out/Dockerfile
GITHUB PR #567
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname Linux 9a7f0c78e80d 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 064f38b
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-567/7/artifact/out/diff-checkstyle-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-567/7/artifact/out/patch-unit-hadoop-hdds_common.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-567/7/artifact/out/patch-unit-hadoop-hdds_server-scm.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-567/7/testReport/
Max. process+thread count 410 (vs. ulimit of 5500)
modules C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-567/7/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 57 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 4 new or modified test files.
_ trunk Compile Tests _
0 mvndep 44 Maven dependency ordering for branch
+1 mvninstall 1395 trunk passed
+1 compile 110 trunk passed
+1 checkstyle 40 trunk passed
+1 mvnsite 80 trunk passed
+1 shadedclient 926 branch has no errors when building and testing our client artifacts.
+1 findbugs 122 trunk passed
+1 javadoc 72 trunk passed
_ Patch Compile Tests _
0 mvndep 15 Maven dependency ordering for patch
+1 mvninstall 84 the patch passed
+1 compile 74 the patch passed
+1 javac 74 the patch passed
-0 checkstyle 26 hadoop-hdds: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
+1 mvnsite 62 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 2 The patch has no ill-formed XML file.
+1 shadedclient 888 patch has no errors when building and testing our client artifacts.
+1 findbugs 123 the patch passed
+1 javadoc 55 the patch passed
_ Other Tests _
-1 unit 77 common in the patch failed.
-1 unit 114 server-scm in the patch failed.
+1 asflicense 32 The patch does not generate ASF License warnings.
4455
Reason Tests
Failed junit tests hadoop.hdds.security.x509.certificate.client.TestDefaultCertificateClient
hadoop.hdds.scm.chillmode.TestChillModeHandler
hadoop.hdds.scm.block.TestBlockManager
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-567/6/artifact/out/Dockerfile
GITHUB PR #567
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname Linux 2249b866bd4d 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 064f38b
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-567/6/artifact/out/diff-checkstyle-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-567/6/artifact/out/patch-unit-hadoop-hdds_common.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-567/6/artifact/out/patch-unit-hadoop-hdds_server-scm.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-567/6/testReport/
Max. process+thread count 323 (vs. ulimit of 5500)
modules C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-567/6/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 21 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 4 new or modified test files.
_ trunk Compile Tests _
0 mvndep 23 Maven dependency ordering for branch
+1 mvninstall 1116 trunk passed
+1 compile 75 trunk passed
+1 checkstyle 28 trunk passed
+1 mvnsite 74 trunk passed
+1 shadedclient 802 branch has no errors when building and testing our client artifacts.
+1 findbugs 107 trunk passed
+1 javadoc 58 trunk passed
_ Patch Compile Tests _
0 mvndep 11 Maven dependency ordering for patch
+1 mvninstall 71 the patch passed
+1 compile 67 the patch passed
+1 javac 67 the patch passed
-0 checkstyle 24 hadoop-hdds: The patch generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)
+1 mvnsite 59 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 2 The patch has no ill-formed XML file.
+1 shadedclient 792 patch has no errors when building and testing our client artifacts.
+1 findbugs 123 the patch passed
+1 javadoc 53 the patch passed
_ Other Tests _
-1 unit 76 common in the patch failed.
+1 unit 90 server-scm in the patch passed.
+1 asflicense 24 The patch does not generate ASF License warnings.
3741
Reason Tests
Failed junit tests hadoop.hdds.security.x509.certificate.client.TestDefaultCertificateClient
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-567/8/artifact/out/Dockerfile
GITHUB PR #567
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname Linux 7ba8e46b2c67 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 064f38b
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-567/8/artifact/out/diff-checkstyle-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-567/8/artifact/out/patch-unit-hadoop-hdds_common.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-567/8/testReport/
Max. process+thread count 362 (vs. ulimit of 5500)
modules C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-567/8/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 22 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 4 new or modified test files.
_ trunk Compile Tests _
0 mvndep 10 Maven dependency ordering for branch
+1 mvninstall 1022 trunk passed
+1 compile 76 trunk passed
+1 checkstyle 29 trunk passed
+1 mvnsite 123 trunk passed
+1 shadedclient 774 branch has no errors when building and testing our client artifacts.
+1 findbugs 108 trunk passed
+1 javadoc 57 trunk passed
_ Patch Compile Tests _
0 mvndep 9 Maven dependency ordering for patch
+1 mvninstall 68 the patch passed
+1 compile 64 the patch passed
+1 javac 64 the patch passed
-0 checkstyle 21 hadoop-hdds: The patch generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)
+1 mvnsite 60 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 2 The patch has no ill-formed XML file.
+1 shadedclient 705 patch has no errors when building and testing our client artifacts.
+1 findbugs 113 the patch passed
+1 javadoc 58 the patch passed
_ Other Tests _
-1 unit 61 common in the patch failed.
+1 unit 105 server-scm in the patch passed.
+1 asflicense 29 The patch does not generate ASF License warnings.
3511
Reason Tests
Failed junit tests hadoop.hdds.security.x509.certificate.client.TestDefaultCertificateClient
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-567/9/artifact/out/Dockerfile
GITHUB PR #567
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname Linux 5a8cee3fee73 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 064f38b
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-567/9/artifact/out/diff-checkstyle-hadoop-hdds.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-567/9/artifact/out/patch-unit-hadoop-hdds_common.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-567/9/testReport/
Max. process+thread count 445 (vs. ulimit of 5500)
modules C: hadoop-hdds/common hadoop-hdds/server-scm U: hadoop-hdds
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-567/9/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@bharatviswa504
Copy link
Contributor Author

@nandakumar131
Updated the patch according to the discussion today.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 24 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 5 new or modified test files.
_ trunk Compile Tests _
0 mvndep 22 Maven dependency ordering for branch
+1 mvninstall 1023 trunk passed
+1 compile 1063 trunk passed
+1 checkstyle 199 trunk passed
+1 mvnsite 161 trunk passed
+1 shadedclient 1043 branch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1 findbugs 155 trunk passed
+1 javadoc 113 trunk passed
_ Patch Compile Tests _
0 mvndep 19 Maven dependency ordering for patch
+1 mvninstall 121 the patch passed
+1 compile 919 the patch passed
+1 javac 919 the patch passed
+1 checkstyle 178 the patch passed
+1 mvnsite 145 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 2 The patch has no ill-formed XML file.
+1 shadedclient 612 patch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1 findbugs 177 the patch passed
+1 javadoc 116 the patch passed
_ Other Tests _
-1 unit 65 common in the patch failed.
-1 unit 106 server-scm in the patch failed.
-1 unit 649 integration-test in the patch failed.
+1 unit 78 tools in the patch passed.
+1 asflicense 43 The patch does not generate ASF License warnings.
6938
Reason Tests
Failed junit tests hadoop.hdds.security.x509.certificate.client.TestDefaultCertificateClient
hadoop.hdds.scm.server.TestSCMClientProtocolServer
hadoop.ozone.TestOzoneConfigurationFields
hadoop.ozone.om.TestOzoneManager
hadoop.ozone.scm.node.TestQueryNode
hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient
hadoop.ozone.container.server.TestSecureContainerServer
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-567/10/artifact/out/Dockerfile
GITHUB PR #567
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname Linux bbba46d5da1f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 373705f
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-567/10/artifact/out/patch-unit-hadoop-hdds_common.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-567/10/artifact/out/patch-unit-hadoop-hdds_server-scm.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-567/10/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-567/10/testReport/
Max. process+thread count 3965 (vs. ulimit of 5500)
modules C: hadoop-hdds/common hadoop-hdds/server-scm hadoop-ozone/integration-test hadoop-ozone/tools U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-567/10/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 26 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 5 new or modified test files.
_ trunk Compile Tests _
0 mvndep 23 Maven dependency ordering for branch
+1 mvninstall 1094 trunk passed
+1 compile 1073 trunk passed
+1 checkstyle 205 trunk passed
+1 mvnsite 180 trunk passed
+1 shadedclient 1079 branch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1 findbugs 169 trunk passed
+1 javadoc 146 trunk passed
_ Patch Compile Tests _
0 mvndep 24 Maven dependency ordering for patch
+1 mvninstall 132 the patch passed
+1 compile 950 the patch passed
+1 javac 950 the patch passed
+1 checkstyle 193 the patch passed
+1 mvnsite 186 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 xml 1 The patch has no ill-formed XML file.
+1 shadedclient 669 patch has no errors when building and testing our client artifacts.
0 findbugs 0 Skipped patched modules with no Java source: hadoop-ozone/integration-test
+1 findbugs 205 the patch passed
+1 javadoc 149 the patch passed
_ Other Tests _
-1 unit 87 common in the patch failed.
+1 unit 105 server-scm in the patch passed.
-1 unit 567 integration-test in the patch failed.
+1 unit 77 tools in the patch passed.
+1 asflicense 36 The patch does not generate ASF License warnings.
7286
Reason Tests
Failed junit tests hadoop.hdds.security.x509.certificate.client.TestDefaultCertificateClient
hadoop.ozone.container.server.TestSecureContainerServer
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-567/11/artifact/out/Dockerfile
GITHUB PR #567
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
uname Linux 8a32daa4ed33 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 373705f
maven version: Apache Maven 3.3.9
Default Java 1.8.0_191
findbugs v3.1.0-RC1
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-567/11/artifact/out/patch-unit-hadoop-hdds_common.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-567/11/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-567/11/testReport/
Max. process+thread count 4094 (vs. ulimit of 5500)
modules C: hadoop-hdds/common hadoop-hdds/server-scm hadoop-ozone/integration-test hadoop-ozone/tools U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-567/11/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@nandakumar131
Copy link
Contributor

+1.

@nandakumar131 nandakumar131 merged commit 341c076 into apache:trunk Mar 8, 2019
@bharatviswa504 bharatviswa504 deleted the HDDS-1196 branch March 8, 2019 16:56
shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
@rmatharu
SAMZA-1735: Adding ListGaugeMBean, to enable MBean validation
3055e85 
Adding ListGaugeMBean, to enable MBean validation.
Tested with LocalContainerRunner and YARN job.

JIRA SAMZA-1733/ SAMZA-1735.

Author: Ray Matharu <[email protected]>

Reviewers: Cameron Lee <[email protected]>

Closes apache#567 from rmatharu/ListGaugeMBean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nandakumar131 nandakumar131 Awaiting requested review from nandakumar131

@arp7 arp7 Awaiting requested review from arp7

Assignees

@bharatviswa504 bharatviswa504

Labels

ozone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bharatviswa504 @hadoop-yetus @nandakumar131