-
Notifications
You must be signed in to change notification settings - Fork 9.1k
YARN-11470. FederationStateStoreFacade Cache Support Guava Cache. #5609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
00dbec8
YARN-11470. FederationStateStoreFacade Cache Support Guava Cache.
62587d1
YARN-11470. Fix CheckStyle.
9609a09
YARN-11470. Fix CheckStyle.
ee634de
YARN-11470. Fix CheckStyle.
8425562
YARN-11470. Fix CheckStyle.
0039781
YARN-11470. Fix CheckStyle.
6b75349
YARN-11470. Fix CheckStyle.
e3852b1
YARN-11470. Fix CheckStyle.
e9352f7
YARN-11470. Fix CheckStyle.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
117 changes: 117 additions & 0 deletions
117
...on/src/main/java/org/apache/hadoop/yarn/server/federation/cache/FederationGuavaCache.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,117 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with this | ||
| * work for additional information regarding copyright ownership. The ASF | ||
| * licenses this file to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * <p> | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * <p> | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
|
|
||
| package org.apache.hadoop.yarn.server.federation.cache; | ||
|
|
||
| import org.apache.hadoop.conf.Configuration; | ||
| import org.apache.hadoop.thirdparty.com.google.common.cache.Cache; | ||
| import org.apache.hadoop.thirdparty.com.google.common.cache.CacheBuilder; | ||
| import org.apache.hadoop.yarn.api.records.ApplicationId; | ||
| import org.apache.hadoop.yarn.conf.YarnConfiguration; | ||
| import org.apache.hadoop.yarn.exceptions.YarnException; | ||
| import org.apache.hadoop.yarn.server.federation.store.FederationStateStore; | ||
| import org.apache.hadoop.yarn.server.federation.store.records.SubClusterId; | ||
| import org.apache.hadoop.yarn.server.federation.store.records.SubClusterInfo; | ||
| import org.apache.hadoop.yarn.server.federation.store.records.SubClusterPolicyConfiguration; | ||
|
|
||
| import java.util.Map; | ||
| import java.util.concurrent.TimeUnit; | ||
|
|
||
| public class FederationGuavaCache extends FederationCache { | ||
|
|
||
| private Cache<String, CacheRequest<String, ?>> cache; | ||
|
|
||
| private int cacheTimeToLive; | ||
|
|
||
| private String className = this.getClass().getSimpleName(); | ||
|
|
||
| private boolean isCachingEnabled = false; | ||
|
|
||
| @Override | ||
| public boolean isCachingEnabled() { | ||
| return isCachingEnabled; | ||
| } | ||
|
|
||
| @Override | ||
| public void initCache(Configuration pConf, FederationStateStore pStateStore) { | ||
| // Picking the JCache provider from classpath, need to make sure there's | ||
| // no conflict or pick up a specific one in the future. | ||
| cacheTimeToLive = pConf.getInt(YarnConfiguration.FEDERATION_CACHE_TIME_TO_LIVE_SECS, | ||
| YarnConfiguration.DEFAULT_FEDERATION_CACHE_TIME_TO_LIVE_SECS); | ||
| if (cacheTimeToLive <= 0) { | ||
| isCachingEnabled = false; | ||
| return; | ||
| } | ||
| this.setStateStore(pStateStore); | ||
|
|
||
| // Initialize Cache. | ||
| cache = CacheBuilder.newBuilder().expireAfterWrite(cacheTimeToLive, | ||
| TimeUnit.MILLISECONDS).build(); | ||
| isCachingEnabled = true; | ||
| } | ||
|
|
||
| @Override | ||
| public void clearCache() { | ||
| cache.invalidateAll(); | ||
| cache = null; | ||
| } | ||
|
|
||
| @Override | ||
| public Map<SubClusterId, SubClusterInfo> getSubClusters(boolean filterInactiveSubClusters) | ||
| throws YarnException { | ||
| final String cacheKey = buildCacheKey(className, GET_SUBCLUSTERS_CACHEID, | ||
| Boolean.toString(filterInactiveSubClusters)); | ||
| CacheRequest<String, ?> cacheRequest = cache.getIfPresent(cacheKey); | ||
| if (cacheRequest == null) { | ||
| cacheRequest = buildGetSubClustersCacheRequest(className, filterInactiveSubClusters); | ||
| cache.put(cacheKey, cacheRequest); | ||
| } | ||
| return buildSubClusterInfoMap(cacheRequest); | ||
| } | ||
|
|
||
| @Override | ||
| public Map<String, SubClusterPolicyConfiguration> getPoliciesConfigurations() throws Exception { | ||
| final String cacheKey = buildCacheKey(className, GET_POLICIES_CONFIGURATIONS_CACHEID); | ||
| CacheRequest<String, ?> cacheRequest = cache.getIfPresent(cacheKey); | ||
| if(cacheRequest == null){ | ||
| cacheRequest = buildGetPoliciesConfigurationsCacheRequest(className); | ||
| cache.put(cacheKey, cacheRequest); | ||
| } | ||
| return buildPolicyConfigMap(cacheRequest); | ||
| } | ||
|
|
||
| @Override | ||
| public SubClusterId getApplicationHomeSubCluster(ApplicationId appId) throws Exception { | ||
| final String cacheKey = buildCacheKey(className, GET_APPLICATION_HOME_SUBCLUSTER_CACHEID, | ||
| appId.toString()); | ||
| CacheRequest<String, ?> cacheRequest = cache.getIfPresent(cacheKey); | ||
| if (cacheRequest == null) { | ||
| cacheRequest = buildGetApplicationHomeSubClusterRequest(className, appId); | ||
| cache.put(cacheKey, cacheRequest); | ||
| } | ||
| CacheResponse<SubClusterId> response = | ||
| ApplicationHomeSubClusterCacheResponse.class.cast(cacheRequest.getValue()); | ||
| return response.getItem(); | ||
| } | ||
|
|
||
| @Override | ||
| public void removeSubCluster(boolean flushCache) { | ||
| final String cacheKey = buildCacheKey(className, GET_SUBCLUSTERS_CACHEID, | ||
| Boolean.toString(flushCache)); | ||
| cache.invalidate(cacheKey); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
121 changes: 121 additions & 0 deletions
121
...mon/src/test/java/org/apache/hadoop/yarn/server/federation/cache/TestFederationCache.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with this | ||
| * work for additional information regarding copyright ownership. The ASF | ||
| * licenses this file to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * <p> | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * <p> | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
|
|
||
| package org.apache.hadoop.yarn.server.federation.cache; | ||
|
|
||
| import org.apache.hadoop.conf.Configuration; | ||
| import org.apache.hadoop.yarn.api.records.ApplicationId; | ||
| import org.apache.hadoop.yarn.conf.YarnConfiguration; | ||
| import org.apache.hadoop.yarn.exceptions.YarnException; | ||
| import org.apache.hadoop.yarn.server.federation.store.FederationStateStore; | ||
| import org.apache.hadoop.yarn.server.federation.store.impl.MemoryFederationStateStore; | ||
| import org.apache.hadoop.yarn.server.federation.store.records.SubClusterId; | ||
| import org.apache.hadoop.yarn.server.federation.store.records.SubClusterInfo; | ||
| import org.apache.hadoop.yarn.server.federation.store.records.SubClusterPolicyConfiguration; | ||
| import org.apache.hadoop.yarn.server.federation.utils.FederationStateStoreFacade; | ||
| import org.apache.hadoop.yarn.server.federation.utils.FederationStateStoreTestUtil; | ||
| import org.junit.After; | ||
| import org.junit.Before; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
| import org.junit.runners.Parameterized; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.Arrays; | ||
| import java.util.Collection; | ||
| import java.util.Map; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
|
|
||
| /** | ||
| * Unit tests for FederationCache. | ||
| */ | ||
| @RunWith(Parameterized.class) | ||
| public class TestFederationCache { | ||
|
|
||
| @Parameterized.Parameters | ||
| public static Collection<Class[]> getParameters() { | ||
| return Arrays.asList(new Class[][] {{FederationGuavaCache.class}, {FederationJCache.class}}); | ||
| } | ||
|
|
||
| private final long clusterTs = System.currentTimeMillis(); | ||
| private final int numSubClusters = 3; | ||
| private final int numApps = 5; | ||
| private final int numQueues = 2; | ||
|
|
||
| private Configuration conf; | ||
| private FederationStateStore stateStore; | ||
| private FederationStateStoreTestUtil stateStoreTestUtil; | ||
| private FederationStateStoreFacade facade = FederationStateStoreFacade.getInstance(); | ||
|
|
||
| public TestFederationCache(Class cacheClassName) { | ||
| conf = new Configuration(); | ||
| conf.setInt(YarnConfiguration.FEDERATION_CACHE_TIME_TO_LIVE_SECS, 1); | ||
| conf.setClass(YarnConfiguration.FEDERATION_FACADE_CACHE_CLASS, | ||
| cacheClassName, FederationCache.class); | ||
| } | ||
|
|
||
| @Before | ||
| public void setUp() throws IOException, YarnException { | ||
| stateStore = new MemoryFederationStateStore(); | ||
| stateStore.init(conf); | ||
| facade.reinitialize(stateStore, conf); | ||
| // hydrate the store | ||
| stateStoreTestUtil = new FederationStateStoreTestUtil(stateStore); | ||
| stateStoreTestUtil.registerSubClusters(numSubClusters); | ||
| stateStoreTestUtil.addAppsHomeSC(clusterTs, numApps); | ||
| stateStoreTestUtil.addPolicyConfigs(numQueues); | ||
| } | ||
|
|
||
| @After | ||
| public void tearDown() throws Exception { | ||
| stateStore.close(); | ||
| stateStore = null; | ||
| } | ||
|
|
||
| @Test | ||
| public void testGetSubCluster() throws YarnException { | ||
| for (int i = 0; i < numSubClusters; i++) { | ||
| SubClusterId subClusterId = | ||
| SubClusterId.newInstance(FederationStateStoreTestUtil.SC_PREFIX + i); | ||
| SubClusterInfo expectedSubCluster = stateStoreTestUtil.querySubClusterInfo(subClusterId); | ||
| SubClusterInfo cachedSubCluster = facade.getSubCluster(subClusterId); | ||
| assertEquals(expectedSubCluster, cachedSubCluster); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testGetPoliciesConfigurations() throws YarnException { | ||
| Map<String, SubClusterPolicyConfiguration> queuePolicies = | ||
| facade.getPoliciesConfigurations(); | ||
| for (String queue : queuePolicies.keySet()) { | ||
| SubClusterPolicyConfiguration expectedPC = stateStoreTestUtil.queryPolicyConfiguration(queue); | ||
| SubClusterPolicyConfiguration cachedPC = queuePolicies.get(queue); | ||
| assertEquals(expectedPC, cachedPC); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testGetHomeSubClusterForApp() throws YarnException { | ||
| for (int i = 0; i < numApps; i++) { | ||
| ApplicationId appId = ApplicationId.newInstance(clusterTs, i); | ||
| SubClusterId expectedSC = stateStoreTestUtil.queryApplicationHomeSC(appId); | ||
| SubClusterId cachedPC = facade.getApplicationHomeSubCluster(appId); | ||
| assertEquals(expectedSC, cachedPC); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.