-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HDFS-16933. A race in SerialNumberMap will cause wrong owner, group and XATTR #5430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💔 -1 overall
This message was automatically generated. |
|
@ZanderXu Thanks for your works. Great catch here! Do you take benchmark if any possible performance decrease here when parallel fsimage loading? |
Almost no performance lost, because this sync is just used for new users. |
|
Great. LGTM. +1 from my side. Will check in if anymore comments for two work days here. |
|
Committed to trunk. Thanks @ZanderXu for your contribution! |
…nd XATTR. (apache#5430). Contributed by ZanderXu. Signed-off-by: He Xiaoqiao <[email protected]>
Jira: HDFS-16933
We encountered a problem that NameNode randomly has wrong owner ship after loading the same fsimage if we enable parallel fsimage loading.
After tracing and found that maybe there is a race in SerialNumberMap.
There are two mappings in SerialNumberMap, t2i and i2t. They should be safely updated together.