-
Notifications
You must be signed in to change notification settings - Fork 9.1k
YARN-11079. Make an AbstractParentQueue to store common ParentQueue and ManagedParentQueue functionality #5380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change-Id: Icb90fc5887fc282a671c92980733aed3fd7ce85f
Change-Id: Icb6b055cc10bbeb7273221505e604e104ca619c1
|
💔 -1 overall
This message was automatically generated. |
Change-Id: Ia4d65a0b807d91ce6c611111a97c4c36f20f169f
|
💔 -1 overall
This message was automatically generated. |
Change-Id: I400bb5b96598293b33796b7fb7555a0ca3382575
|
💔 -1 overall
This message was automatically generated. |
Aim: to trigger untriggered jenkins Change-Id: Iea1ee17e02efd66c30b97a7e7d025a6eb6ae25d0
|
💔 -1 overall
This message was automatically generated. |
...va/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractParentQueue.java
Outdated
Show resolved
Hide resolved
…Queue class and fixed checkstyle Change-Id: I9ea17100ab6cf3cbcadb2728652fe3b6ec2f5af8
|
💔 -1 overall
This message was automatically generated. |
Change-Id: Ia228c39bc65a78c14581f5b7bc7a70f0aae0b6a4
|
💔 -1 overall
This message was automatically generated. |
Change-Id: Ib185eca647105ab9057eee0be9da82afa9f48173
|
💔 -1 overall
This message was automatically generated. |
Change-Id: I257f587c735832ed64ff7a35afd558f1f0433f53
|
💔 -1 overall
This message was automatically generated. |
|
Hi @susheel-gupta , I compared the old version of ParentQueue vs. AbstractParentQueue and found some differences:
Otherwise LGTM |
@szilard-nemeth There was this warning where they asked to fix the spotbugs, so I added this commit . With the above changes in this commit , the numApplications field is an instance of AtomicInteger, which provides an atomic incrementAndGet method to increment the value of the counter atomically. Since AtomicInteger provides atomic operations, we don't need to use locks or synchronization to ensure atomicity. References: |
|
Thanks @susheel-gupta for the explanation, |
Change-Id: Icb90fc5887fc282a671c92980733aed3fd7ce85f
Description of PR
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?