Skip to content

Conversation

@szucsvillo
Copy link

No description provided.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 49s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 xmllint 0m 1s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 45m 44s trunk passed
+1 💚 compile 0m 16s trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚 compile 0m 18s trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚 mvnsite 0m 22s trunk passed
+1 💚 javadoc 0m 25s trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚 javadoc 0m 19s trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚 shadedclient 72m 52s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 14s the patch passed
+1 💚 compile 0m 12s the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚 javac 0m 12s the patch passed
+1 💚 compile 0m 11s the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚 javac 0m 11s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 13s the patch passed
+1 💚 javadoc 0m 12s the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚 javadoc 0m 11s the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚 shadedclient 27m 14s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 14s hadoop-project in the patch passed.
+1 💚 asflicense 0m 33s The patch does not generate ASF License warnings.
104m 4s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5345/1/artifact/out/Dockerfile
GITHUB PR #5345
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname Linux 97bfd0150be1 4.15.0-197-generic #208-Ubuntu SMP Tue Nov 1 17:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 7ed7f25
Default Java Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5345/1/testReport/
Max. process+thread count 540 (vs. ulimit of 5500)
modules C: hadoop-project U: hadoop-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5345/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@virajjasani
Copy link
Contributor

We also need to upgrade curator to 5.4.0 right?

Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update new versions being introduced on https://github.com/apache/hadoop/blob/trunk/LICENSE-binary ?
This would also help trigger full build run

@virajjasani
Copy link
Contributor

Curator 5.4.0 supports Zookeeper 3.7 at least, not sure if it would work with 3.8 as well, but let's try in our build first.
Thanks

…on 5.4.0

Change-Id: I4614dfe72c26aed48c42d2a4e57897168c02404b
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 49s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 16m 43s Maven dependency ordering for branch
+1 💚 mvninstall 28m 44s trunk passed
+1 💚 compile 25m 33s trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚 compile 21m 55s trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚 mvnsite 26m 22s trunk passed
+1 💚 javadoc 8m 27s trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 7m 27s trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚 shadedclient 38m 33s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 1m 1s Maven dependency ordering for patch
+1 💚 mvninstall 25m 17s the patch passed
+1 💚 compile 24m 57s the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚 javac 24m 57s the patch passed
+1 💚 compile 21m 56s the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
-1 ❌ javac 21m 56s /results-compile-javac-root-jdkPrivateBuild-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09.txt root-jdkPrivateBuild-1.8.0_362-8u362-ga-0ubuntu120.04.1-b09 with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu120.04.1-b09 generated 1 new + 2624 unchanged - 1 fixed = 2625 total (was 2625)
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 21m 19s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 8m 23s the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 7m 21s the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚 shadedclient 39m 23s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 486m 42s /patch-unit-root.txt root in the patch failed.
+1 💚 asflicense 1m 12s The patch does not generate ASF License warnings.
783m 58s
Reason Tests
Failed junit tests hadoop.hdfs.server.blockmanagement.TestPendingReconstruction
hadoop.hdfs.TestErasureCodingExerciseAPIs
hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetCache
hadoop.cli.TestAclCLI
hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
hadoop.hdfs.server.namenode.snapshot.TestSnapshotFileLength
hadoop.hdfs.server.namenode.TestStartup
hadoop.hdfs.server.namenode.TestFSEditLogLoader
hadoop.hdfs.qjournal.server.TestJournaledEditsCache
hadoop.hdfs.server.namenode.TestAuditLoggerWithCommands
hadoop.hdfs.TestQuota
hadoop.hdfs.server.blockmanagement.TestBlockManagerSafeMode
hadoop.hdfs.server.datanode.TestDataNodeMetricsLogger
hadoop.hdfs.server.namenode.TestCheckpoint
hadoop.hdfs.server.namenode.ha.TestDelegationTokensWithHA
hadoop.hdfs.tools.TestViewFileSystemOverloadSchemeWithDFSAdmin
hadoop.hdfs.tools.TestECAdmin
hadoop.hdfs.server.diskbalancer.TestDiskBalancer
hadoop.hdfs.tools.TestDebugAdmin
hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
hadoop.hdfs.web.TestWebHDFS
hadoop.hdfs.server.namenode.TestFSNamesystemLock
hadoop.hdfs.TestEncryptedTransfer
hadoop.hdfs.TestDFSShell
hadoop.hdfs.server.namenode.TestAuditLogger
hadoop.hdfs.server.namenode.TestFSNamesystemLockReport
hadoop.hdfs.server.namenode.TestFsck
hadoop.hdfs.tools.TestViewFileSystemOverloadSchemeWithFSCommands
hadoop.hdfs.TestViewDistributedFileSystem
hadoop.hdfs.server.namenode.TestCacheDirectives
hadoop.hdfs.tools.TestDFSAdmin
hadoop.cli.TestAclCLIWithPosixAclInheritance
hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints
hadoop.hdfs.server.datanode.TestDirectoryScanner
hadoop.hdfs.server.datanode.TestLargeBlockReport
hadoop.hdfs.server.namenode.TestNamenodeRetryCache
hadoop.hdfs.server.datanode.TestFsDatasetCacheRevocation
hadoop.hdfs.server.namenode.TestNameNodeMetricsLogger
hadoop.hdfs.server.namenode.TestAuditLogs
hadoop.hdfs.TestMaintenanceState
hadoop.cli.TestXAttrCLI
hadoop.hdfs.server.blockmanagement.TestReplicationPolicy
hadoop.hdfs.server.namenode.TestCacheDirectivesWithViewDFS
hadoop.hdfs.TestRollingUpgrade
hadoop.hdfs.protocol.datatransfer.sasl.TestSaslDataTransfer
hadoop.hdfs.TestDFSUpgradeFromImage
hadoop.hdfs.TestDistributedFileSystem
hadoop.hdfs.server.namenode.TestAuditLogAtDebug
hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
hadoop.hdfs.TestDFSRename
hadoop.hdfs.tools.TestDFSAdminWithHA
hadoop.hdfs.server.namenode.TestEditsDoubleBuffer
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5345/2/artifact/out/Dockerfile
GITHUB PR #5345
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname Linux 101f71a1699b 4.15.0-197-generic #208-Ubuntu SMP Tue Nov 1 17:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 79777a2
Default Java Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5345/2/testReport/
Max. process+thread count 2246 (vs. ulimit of 5500)
modules C: hadoop-project . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5345/2/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

<maven.test.failure.ignore>true</maven.test.failure.ignore>
<maven.test.redirectTestOutputToFile>true</maven.test.redirectTestOutputToFile>
<jetty.version>9.4.48.v20220622</jetty.version>
<jetty.version>9.4.49.v20220914</jetty.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated. Are you updating Jetty because Zookeeper has jetty dependency and you're trying to harmonize them?

If so I'd suggest to exclude the jetty from zookeeper. We update Jetty frequently and do not necessarily use the same version as Zookeeper.

@github-actions
Copy link
Contributor

We're closing this stale PR because it has been open for 100 days with no activity. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you feel like this was a mistake, or you would like to continue working on it, please feel free to re-open it and ask for a committer to remove the stale tag and review again.
Thanks all for your contribution.

@github-actions github-actions bot added the Stale label Oct 27, 2025
@github-actions github-actions bot closed this Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants