MAPREDUCE-7429 Application log link is not accessible via TimelineServer WebUI in IPV6 scenario #5236
+125
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniel-009497
force-pushed
the
MAPREDUCE-7429
branch
from
6028423 to
b1a0e4f
Compare
slfan1989
reviewed
Dec 17, 2022
...op-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/util/WebAppUtils.java
Outdated
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Daniel-009497
force-pushed
the
MAPREDUCE-7429
branch
from
b1a0e4f to
2bfbf9c
Compare
|
@Daniel-009497 Thank you very much for your contribution, but we need to fix checkstyle issue. Don't worry about javadoc issue, it seems to be a problem with jdk. |
Daniel-009497
force-pushed
the
MAPREDUCE-7429
branch
from
2bfbf9c to
e156724
Compare
|
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Daniel-009497
force-pushed
the
MAPREDUCE-7429
branch
from
e156724 to
e8eba06
Compare
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
Dec 19, 2022
| } | ||
|
|
||
| public static String normalizeV6Address(String target) { | ||
| if (!target.startsWith("[")) { |
There was a problem hiding this comment.
I'm pretty sure regex would help here.
| target = target.trim(); | ||
| String port = target.substring(target.lastIndexOf(":") + 1); | ||
| String addr = target.substring(0, i); | ||
| target = "[" + addr + "]" + ":" + port; |
There was a problem hiding this comment.
Make the input target final in the declaration and return a new variable.
public static String normalizeV6Address(final String target) {
| return createSocketAddrForHost(host, port); | ||
| } | ||
|
|
||
| public static String normalizeV6Address(String target) { |
|
|
||
| public static URI constructResURI(Configuration conf, String address, | ||
| String uri) { | ||
| if (StringUtils.countMatches(address, ":") > 2) { |
There was a problem hiding this comment.
This probable be in NetUtils and be a proper isIPV6Address() or something.
Daniel-009497
force-pushed
the
MAPREDUCE-7429
branch
from
e8eba06 to
e5ec449
Compare
slfan1989
reviewed
Dec 20, 2022
| if (StringUtils.countMatches(target, ":") > 2) { | ||
| // if scheme exists in the target, for example: | ||
| // https://ffff:ffff:ffff:ffff::1:XXXX will be formed like | ||
| // https://[ffff:ffff:ffff:ffff::1]:XXXX |
There was a problem hiding this comment.
The code looks fine, we'd better use a specific port in the comments, such as 8088
There was a problem hiding this comment.
Thanks for review.
Just modified as you mentioned.
Pls help to merge once the pipeline is done.
And pls help to review the other PR I raised if you got time.
Thanks a lot.
Daniel-009497
force-pushed
the
MAPREDUCE-7429
branch
2 times, most recently
from
bd10b58 to
56eb9ec
Compare
|
@Daniel-009497 Thank you very much for your contribution, but we need to wait for |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
Dec 20, 2022
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestNetUtils.java
Outdated
Show resolved
Hide resolved
...op-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/util/WebAppUtils.java
Outdated
Show resolved
Hide resolved
goiri
reviewed
Dec 20, 2022
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetUtils.java
Outdated
Show resolved
Hide resolved
Daniel-009497
force-pushed
the
MAPREDUCE-7429
branch
from
56eb9ec to
07973a0
Compare
|
💔 -1 overall
This message was automatically generated. |
…ver WebUI in IPV6 scenario
Daniel-009497
force-pushed
the
MAPREDUCE-7429
branch
from
07973a0 to
85aa877
Compare
|
@goiri |
|
I found that this change is in the yarn module, but the title is mapreduce. waiting yetus compilation result If our changes affect the mapreduce module, we'd better wait for MAPREDUCE-7428 (#5243), wait for this to complete, and do compilation again. |
|
💔 -1 overall
This message was automatically generated. |
goiri
approved these changes
Dec 22, 2022
| } | ||
|
|
||
| public static String normalizeV6Address(String target) { | ||
| if (!target.startsWith("[")) { |
zeekling
suggested changes
Sep 16, 2025
| } | ||
| target = target.trim(); | ||
| boolean hasScheme = target.contains("://"); | ||
| if (NetUtils.isIPV6Address(target)) { |
There was a problem hiding this comment.
NetUtils.isIPV6Address(target) is slow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Application log link is not accessible via Timelineserver Web UI under IPV6 scenario owing to no ipv6 normalization for IP address.