Skip to content

HDFS-16852. Skip KeyProviderCache shutdown hook registration if already shutting down #5160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 16, 2022
Merged

HDFS-16852. Skip KeyProviderCache shutdown hook registration if already shutting down #5160

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61a10bb
HDFS-16852 Swallow IllegalStateException in KeyProviderCache construc…
Nov 22, 2022
b8eb012
Register the shutdownhook when not in shutdown.
Dec 3, 2022
3c8fd54
Fixed checkstyle
Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...dfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/KeyProviderCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,11 @@ public void onRemoval(
})
.build();

ShutdownHookManager.get().addShutdownHook(new KeyProviderCacheFinalizer(),
SHUTDOWN_HOOK_PRIORITY);
// Register the shutdown hook when not in shutdown
if (!ShutdownHookManager.get().isShutdownInProgress()) {
ShutdownHookManager.get().addShutdownHook(
new KeyProviderCacheFinalizer(), SHUTDOWN_HOOK_PRIORITY);
}
}

public KeyProvider get(final Configuration conf,
Expand Down