HADOOP-18502. MutableStat should return 0 when there is no change #5058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
ZanderXu
reviewed
Nov 3, 2022
| } | ||
|
|
||
| /** | ||
| * MutableStat should output 0 instead of the previous state when there is no change |
| MetricsRecordBuilder builderWithoutChange = mockMetricsRecordBuilder(); | ||
| MetricsRegistry registry = new MetricsRegistry("test"); | ||
| MutableStat stat = registry.newStat("Test", "Test", "Ops", "Val", false); | ||
|
|
There was a problem hiding this comment.
Can remove this empty line.
| assertGauge("TestAvgVal", 1.5, builderWithChange); | ||
|
|
||
| registry.snapshot(builderWithoutChange, true); | ||
| assertGauge("TestAvgVal", 0.0, builderWithoutChange); |
There was a problem hiding this comment.
Here too. Can add one UT to verify the INumOps?
| stat.add(1000, 2000); | ||
| registry.snapshot(builderWithChange, true); | ||
|
|
||
| assertCounter("TestNumOps", 2000L, builderWithChange); |
There was a problem hiding this comment.
Can add one UT to verify the INumOps?
hotcodemacha
suggested changes
Nov 3, 2022
|
🎊 +1 overall
This message was automatically generated. |
ZanderXu
approved these changes
Nov 4, 2022
hotcodemacha
approved these changes
Nov 8, 2022
|
Merged. @ted12138 Thanks for your contribution. @ashutoshcipher Thanks for your review. |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
NyteKnight
pushed a commit
to NyteKnight/hadoop
that referenced
this pull request
Jun 25, 2024
…ache#5058) (Cherry-picked from 7002e21) ACLOVERRIDE
NyteKnight
pushed a commit
to NyteKnight/hadoop
that referenced
this pull request
Jun 25, 2024
HADOOP-18502. MutableStat should return 0 when there is no change (apache#5058)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
When we try to switch active NN to standby, we find that the getContentSummary average time is always a very high value even if there is no more query.
For us, the metrics return 0 is more reasonable.
How was this patch tested?
Active NN will hold some operations average response time, but when we switch ANN to SNN, the avg metrics should be 0.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?