Skip to content

Conversation

@jojochuang
Copy link
Contributor

Reviewed-by: Tsz-Wo Nicholas Sze [email protected]

Co-authored-by: Wei-Chiu Chuang [email protected]
(cherry picked from commit 6847ec0)

Conflicts:
hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/oncrpc/RpcProgram.java

Description of PR

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

…4997)

Reviewed-by: Tsz-Wo Nicholas Sze <[email protected]>

Co-authored-by: Wei-Chiu Chuang <[email protected]>
(cherry picked from commit 6847ec0)

 Conflicts:
	hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/oncrpc/RpcProgram.java
@jojochuang
Copy link
Contributor Author

Only conflicts were the guava imports.

Copy link
Contributor

@hotcodemacha hotcodemacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 (Jenkins pending)

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 6m 3s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 5 new or modified test files.
_ branch-3.2 Compile Tests _
+0 🆗 mvndep 5m 1s Maven dependency ordering for branch
+1 💚 mvninstall 28m 22s branch-3.2 passed
+1 💚 compile 16m 3s branch-3.2 passed
+1 💚 checkstyle 2m 48s branch-3.2 passed
+1 💚 mvnsite 1m 5s branch-3.2 passed
+1 💚 javadoc 1m 2s branch-3.2 passed
+1 💚 spotbugs 1m 52s branch-3.2 passed
+1 💚 shadedclient 15m 18s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 23s Maven dependency ordering for patch
+1 💚 mvninstall 0m 48s the patch passed
+1 💚 compile 15m 24s the patch passed
+1 💚 javac 15m 24s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 2m 41s /results-checkstyle-root.txt root: The patch generated 19 new + 140 unchanged - 7 fixed = 159 total (was 147)
+1 💚 mvnsite 1m 4s the patch passed
+1 💚 javadoc 0m 58s the patch passed
+1 💚 spotbugs 1m 55s the patch passed
+1 💚 shadedclient 15m 39s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 47s hadoop-nfs in the patch passed.
+1 💚 unit 2m 47s hadoop-hdfs-nfs in the patch passed.
+1 💚 asflicense 0m 47s The patch does not generate ASF License warnings.
124m 34s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4999/1/artifact/out/Dockerfile
GITHUB PR #4999
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname Linux 2a589af0f5c5 4.15.0-192-generic #203-Ubuntu SMP Wed Aug 10 17:40:03 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.2 / 9ecd7ae
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~18.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4999/1/testReport/
Max. process+thread count 375 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-nfs hadoop-hdfs-project/hadoop-hdfs-nfs U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4999/1/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@jojochuang jojochuang merged commit 9faebf3 into apache:branch-3.2 Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants