Skip to content

Conversation

@snmvaughan
Copy link
Contributor

Back port to branch-3.3, to avoid reconnecting to the old address after detecting that the address has been updated.

  • Use a stable hashCode to allow safe IP addr changes
  • Add test that updated address is used

Once the address has been updated, it will be used in future calls. Test verifies that a second request succeeds and that it uses the existing updated address instead of having to re-resolve.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

…ache#4692)

Back port to branch-3.3, to avoid reconnecting to the old address after detecting that the address has been updated.

* Use a stable hashCode to allow safe IP addr changes
* Add test that updated address is used

Once the address has been updated, it will be used in future calls.  Test verifies that a second request succeeds and that it uses the existing updated address instead of having to re-resolve.
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 7m 5s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-3.3 Compile Tests _
+1 💚 mvninstall 36m 23s branch-3.3 passed
+1 💚 compile 18m 9s branch-3.3 passed
+1 💚 checkstyle 1m 32s branch-3.3 passed
+1 💚 mvnsite 2m 5s branch-3.3 passed
+1 💚 javadoc 1m 26s branch-3.3 passed
+1 💚 spotbugs 3m 5s branch-3.3 passed
+1 💚 shadedclient 27m 38s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 5s the patch passed
+1 💚 compile 17m 24s the patch passed
+1 💚 javac 17m 24s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 28s hadoop-common-project/hadoop-common: The patch generated 0 new + 129 unchanged - 3 fixed = 129 total (was 132)
+1 💚 mvnsite 2m 4s the patch passed
+1 💚 javadoc 1m 19s the patch passed
+1 💚 spotbugs 3m 4s the patch passed
+1 💚 shadedclient 27m 34s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 18m 16s hadoop-common in the patch passed.
+1 💚 asflicense 1m 32s The patch does not generate ASF License warnings.
170m 41s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4768/1/artifact/out/Dockerfile
GITHUB PR #4768
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 3ae5eb2b7cd3 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / 39bf713
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~18.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4768/1/testReport/
Max. process+thread count 1267 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4768/1/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@sunchao sunchao merged commit cfc11d2 into apache:branch-3.3 Aug 20, 2022
@sunchao
Copy link
Member

sunchao commented Aug 20, 2022

Merged, thanks!

@snmvaughan snmvaughan deleted the feature/HADOOP-18365-3.3 branch August 22, 2022 21:56
bbeaudreault pushed a commit to HubSpot/hadoop that referenced this pull request Jul 12, 2023
…ge is detected (apache#4692) (apache#4768)

Back port to branch-3.3, to avoid reconnecting to the old address after detecting that the address has been updated.

* Use a stable hashCode to allow safe IP addr changes
* Add test that updated address is used

Once the address has been updated, it will be used in future calls.  Test verifies that a second request succeeds and that it uses the existing updated address instead of having to re-resolve.

Co-authored-by: Steve Vaughan Jr <[email protected]>
NyteKnight pushed a commit to NyteKnight/hadoop that referenced this pull request Jun 25, 2024
…ache#4… (apache#356)

* HADOOP-18365. Update the remote address when a change is detected (apache#4692) (apache#4768)

Back port to branch-3.3, to avoid reconnecting to the old address after detecting that the address has been updated.

* Use a stable hashCode to allow safe IP addr changes
* Add test that updated address is used

Once the address has been updated, it will be used in future calls.  Test verifies that a second request succeeds and that it uses the existing updated address instead of having to re-resolve.

Co-authored-by: Steve Vaughan Jr <[email protected]>

* ACLOVERRIDE

---------

Co-authored-by: Steve Vaughan <[email protected]>
Co-authored-by: Steve Vaughan Jr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants