YARN-6572. Refactoring Router services to use common util classes for pipeline creations. #4594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pipeline creations.
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
goiri
reviewed
Jul 20, 2022
| if (pipeline == null) { | ||
| throw new YarnRuntimeException( | ||
| "RequestInterceptor pipeline is not configured in the system"); | ||
| } catch (IOException | InvocationTargetException | NoSuchMethodException | RuntimeException |
There was a problem hiding this comment.
At this point we better catch Exception
There was a problem hiding this comment.
I will refactor this part of the code.
| // add to the map, to ensure thread safe. | ||
| LOG.info("Initializing request processing pipeline for application " | ||
| + "for the user: {}", user); | ||
| + "for the user: {}.", user); |
There was a problem hiding this comment.
We could put the string in a single line.
| RMAdminRequestInterceptor pipeline = null; | ||
| ClientMethod remoteMethod = null; | ||
| try { | ||
| remoteMethod = new ClientMethod("setNextInterceptor", |
There was a problem hiding this comment.
Declare it directly here:
ClientMethod remoteMethod = new ClientMethod("setNextInterceptor",
| | IllegalAccessException ex) { | ||
| throw new YarnRuntimeException("Create RequestInterceptor Chain error.", ex); | ||
| } | ||
| return pipeline; |
There was a problem hiding this comment.
Given that if error we always return exception, can we define the pipeline inside of the try and do the exception returns properly?
There was a problem hiding this comment.
Thank you for your suggestion. I handled different Exceptions in RouterServerUtil#createRequestInterceptorChain, and used YarnRuntimeException to make it easier for the caller to use it.
| */ | ||
| @VisibleForTesting | ||
| protected RESTRequestInterceptor createRequestInterceptorChain() { | ||
| RESTRequestInterceptor pipeline = null; |
There was a problem hiding this comment.
This code is very similar to the other one.
As we are refactoring, can we clean this up?
There was a problem hiding this comment.
Thanks for your help reviewing the code, I will continue to refactor this part of the code.
goiri
reviewed
Jul 20, 2022
| this.userPipelineMap = Collections.synchronizedMap( | ||
| new LRUCacheHashMap<String, RequestInterceptorChainWrapper>( | ||
| maxCacheSize, true)); | ||
| new LRUCacheHashMap<>(maxCacheSize, true)); |
added 2 commits
July 20, 2022 19:50
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
goiri
reviewed
Jul 21, 2022
| package org.apache.hadoop.yarn.server.router.clientrm; | ||
|
|
||
| import java.io.IOException; | ||
| import java.lang.reflect.InvocationTargetException; |
There was a problem hiding this comment.
import java.lang.reflect.InvocationTargetException;:8: Unused import - java.lang.reflect.InvocationTargetException. [UnusedImports]
|
🎊 +1 overall
This message was automatically generated. |
goiri
approved these changes
Jul 22, 2022
|
🎊 +1 overall
This message was automatically generated. |
goiri
reviewed
Jul 25, 2022
| YarnConfiguration.DEFAULT_ROUTER_WEBAPP_INTERCEPTOR_CLASS, | ||
| RESTRequestInterceptor.class); | ||
| } catch (YarnRuntimeException ex) { | ||
| throw new YarnRuntimeException("Create RequestInterceptor Chain error.", ex); |
There was a problem hiding this comment.
We catch the exception to throw it?
There was a problem hiding this comment.
I will modify the code to remove the try catch.
|
🎊 +1 overall
This message was automatically generated. |
|
@goiri Please help me to review the code again, thank you very much! |
goiri
approved these changes
Jul 27, 2022
|
🎊 +1 overall
This message was automatically generated. |
|
There are a few unused imports. |
Thanks for the suggestion, I will remove this part. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
added 2 commits
August 3, 2022 09:20
This reverts commit a7cd76c.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
goiri
approved these changes
Aug 5, 2022
|
🎊 +1 overall
This message was automatically generated. |
|
@goiri Can you help to merge this pr into trunk branch? Thank you very much! |
|
@goiri Thank you very much for your help reviewing the code! |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
… pipeline creations. (apache#4594)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira : YARN-6572. Refactoring Router services to use common util classes for pipeline creations.
When reading the code, I found that RouterClientRMService.java, RouterRMAdminService.java, RouterWebServices.java have a lot of repetitive code in the method of calling createRequestInterceptorChain, and I extracted the methods in RouterServerUtil.