Skip to content

HADOOP-18330 #4551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

HADOOP-18330 #4551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c9870d
Added path to client creation parameters
ashutoshpant Jul 11, 2022
dbec319
fixed javadoc style and indentation
ashutoshpant Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,6 +888,7 @@ private void bindAWSClient(URI name, boolean dtEnabled) throws IOException {
S3ClientFactory.S3ClientCreationParameters parameters = null;
parameters = new S3ClientFactory.S3ClientCreationParameters()
.withCredentialSet(credentials)
.withPath(name)
.withEndpoint(endpoint)
.withMetrics(statisticsContext.newStatisticsFromAwsSdk())
.withPathStyleAccess(conf.getBoolean(PATH_STYLE_ACCESS, false))
Expand Down
21 changes: 21 additions & 0 deletions hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ClientFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,11 @@ final class S3ClientCreationParameters {
*/
private String userAgentSuffix = "";

/**
* Path to s3a bucket.
*/
private URI pathUri = "";

/**
* List of request handlers to include in the chain
* of request execution in the SDK.
Expand Down Expand Up @@ -214,6 +219,22 @@ public S3ClientCreationParameters withUserAgentSuffix(
return this;
}

/**
* Set path.
* @param value new value
* @return the path
*/

public S3ClientCreationParameters withPath(
final URI value) {
pathUri = value;
return this;
}

public URI getPath() {
return pathUri;
}

public String getEndpoint() {
return endpoint;
}
Expand Down