-
Notifications
You must be signed in to change notification settings - Fork 9.1k
YARN-11187. Remove WhiteBox in yarn module. #4463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@jojochuang please help to review the code, thank you very much! |
This comment was marked as outdated.
This comment was marked as outdated.
|
@steveloughran @aajisaka Please help to review the code, I hope that Whitebox can be completely removed from the yarn module. |
This comment was marked as outdated.
This comment was marked as outdated.
|
Hi, @aajisaka I have seen the suggestions you gave, I will modify and refactor the relevant code according to your suggestions, thank you very much. Refer to the discussion of this jira |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@aajisaka Can you help review this pr? Thank you very much! |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@aajisaka Can you help review this pr? Thank you very much! |
.../apache/hadoop/yarn/server/nodemanager/containermanager/launcher/TestContainersLauncher.java
Outdated
Show resolved
Hide resolved
.../apache/hadoop/yarn/server/nodemanager/containermanager/launcher/TestContainersLauncher.java
Outdated
Show resolved
Hide resolved
.../apache/hadoop/yarn/server/nodemanager/containermanager/launcher/TestContainersLauncher.java
Outdated
Show resolved
Hide resolved
.../apache/hadoop/yarn/server/nodemanager/containermanager/launcher/TestContainersLauncher.java
Outdated
Show resolved
Hide resolved
|
@aajisaka Can you help review the code again? Thank you very much! |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your update @slfan1989. Could you update testPauseContainerEvent and testResumeContainerEvent as well? dummyMap is not necessary there.
@aajisaka Thank you very much for helping to review the code, I will modify the code. |
This comment was marked as outdated.
This comment was marked as outdated.
|
@aajisaka Can you help review the code again? Thank you very much! |
|
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
@aajisaka Thank you very much for your help reviewing the code! |
Signed-off-by: Akira Ajisaka <[email protected]>
JIRA:YARN-11187. Remove WhiteBox in yarn module.