Skip to content

Conversation

@slfan1989
Copy link
Contributor

JIRA:YARN-11187. Remove WhiteBox in yarn module.

@hadoop-yetus

This comment was marked as outdated.

@hadoop-yetus

This comment was marked as outdated.

@hadoop-yetus

This comment was marked as outdated.

@hadoop-yetus

This comment was marked as outdated.

@slfan1989
Copy link
Contributor Author

slfan1989 commented Jun 22, 2022

@jojochuang please help to review the code, thank you very much!

@hadoop-yetus

This comment was marked as outdated.

@slfan1989
Copy link
Contributor Author

@steveloughran @aajisaka Please help to review the code, I hope that Whitebox can be completely removed from the yarn module.

@hadoop-yetus

This comment was marked as outdated.

@slfan1989
Copy link
Contributor Author

slfan1989 commented Jul 10, 2022

Hi, @aajisaka I have seen the suggestions you gave, I will modify and refactor the relevant code according to your suggestions, thank you very much.

Refer to the discussion of this jira
https://issues.apache.org/jira/browse/HADOOP-18277?focusedCommentId=17564659&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17564659

@hadoop-yetus

This comment was marked as outdated.

@hadoop-yetus

This comment was marked as outdated.

@hadoop-yetus

This comment was marked as outdated.

@hadoop-yetus

This comment was marked as outdated.

@hadoop-yetus

This comment was marked as outdated.

@hadoop-yetus

This comment was marked as outdated.

@hadoop-yetus

This comment was marked as outdated.

@hadoop-yetus

This comment was marked as outdated.

@slfan1989
Copy link
Contributor Author

@aajisaka Can you help review this pr? Thank you very much!

@hadoop-yetus

This comment was marked as outdated.

@hadoop-yetus

This comment was marked as outdated.

@hadoop-yetus

This comment was marked as outdated.

@slfan1989
Copy link
Contributor Author

@aajisaka Can you help review this pr? Thank you very much!

@slfan1989 slfan1989 requested a review from aajisaka September 25, 2022 15:40
@slfan1989
Copy link
Contributor Author

@aajisaka Can you help review the code again? Thank you very much!

@hadoop-yetus

This comment was marked as outdated.

Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your update @slfan1989. Could you update testPauseContainerEvent and testResumeContainerEvent as well? dummyMap is not necessary there.

@slfan1989
Copy link
Contributor Author

Thank you for your update @slfan1989. Could you update testPauseContainerEvent and testResumeContainerEvent as well? dummyMap is not necessary there.

@aajisaka Thank you very much for helping to review the code, I will modify the code.

@hadoop-yetus

This comment was marked as outdated.

@slfan1989 slfan1989 requested a review from aajisaka September 27, 2022 06:55
@slfan1989
Copy link
Contributor Author

@aajisaka Can you help review the code again? Thank you very much!

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 41s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 39m 6s trunk passed
+1 💚 compile 1m 42s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 compile 1m 32s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 checkstyle 0m 49s trunk passed
+1 💚 mvnsite 1m 4s trunk passed
+1 💚 javadoc 1m 6s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 46s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 1m 46s trunk passed
+1 💚 shadedclient 21m 50s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 43s the patch passed
+1 💚 compile 1m 25s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 javac 1m 25s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 0 new + 105 unchanged - 9 fixed = 105 total (was 114)
+1 💚 compile 1m 22s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 javac 1m 22s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu120.04-b07 with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu120.04-b07 generated 0 new + 78 unchanged - 9 fixed = 78 total (was 87)
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 33s the patch passed
+1 💚 mvnsite 0m 43s the patch passed
+1 💚 javadoc 0m 36s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 33s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 1m 29s the patch passed
+1 💚 shadedclient 20m 28s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 24m 13s hadoop-yarn-server-nodemanager in the patch passed.
+1 💚 asflicense 0m 45s The patch does not generate ASF License warnings.
123m 59s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4463/21/artifact/out/Dockerfile
GITHUB PR #4463
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux d0b38a71f768 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / fff7380
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4463/21/testReport/
Max. process+thread count 734 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4463/21/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@aajisaka aajisaka merged commit b31b3ea into apache:trunk Oct 6, 2022
@slfan1989
Copy link
Contributor Author

@aajisaka Thank you very much for your help reviewing the code!

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants