HADOOP-18297. Upgrade dependency-check-maven to 7.1.1 #4449

hotcodemacha · 2022-06-17T01:33:33Z

Description of PR

Upgrade dependency-check-maven to 7.1.1
The OWASP dependency-check-maven Plugin version has corrected various false positives in 7.1.1. We can upgrade to it.

https://github.com/jeremylong/DependencyCheck/milestone/45?closed=1

JIRA: HADOOP-18297

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?

hadoop-yetus · 2022-06-18T00:38:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 59s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	40m 22s		trunk passed
+1 💚	compile	25m 10s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	21m 50s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	mvnsite	19m 46s		trunk passed
-1 ❌	javadoc	2m 51s	/branch-javadoc-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt	root in trunk failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.
+1 💚	javadoc	7m 34s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	shadedclient	140m 40s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	24m 23s		the patch passed
+1 💚	compile	24m 32s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	24m 32s		the patch passed
+1 💚	compile	21m 49s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	21m 49s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	19m 16s		the patch passed
-1 ❌	javadoc	2m 37s	/patch-javadoc-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt	root in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.
+1 💚	javadoc	7m 27s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	shadedclient	53m 56s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	1113m 22s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	2m 17s		The patch does not generate ASF License warnings.
		1384m 6s

Reason	Tests
Failed junit tests	hadoop.tools.fedbalance.procedure.TestBalanceProcedureScheduler
	hadoop.yarn.server.resourcemanager.TestClientRMTokens
	hadoop.mapred.TestLocalDistributedCacheManager
	hadoop.mapreduce.security.TestJHSSecurity

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4449/1/artifact/out/Dockerfile
GITHUB PR	#4449
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname	Linux 53ce1bfafc75 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `3c2414d`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4449/1/testReport/
Max. process+thread count	2504 (vs. ulimit of 5500)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4449/1/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

PrabhuJoseph · 2022-06-20T05:48:28Z

Thanks @ashutoshcipher for the patch. Could you retrigger the jenkins to get +1 in javadoc and unit.

aajisaka · 2022-06-21T23:51:52Z

Hi @PrabhuJoseph you can retrigger the Jenkins job.

Go to https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4449
Login by your Apache ID
Click "build with parameters". The parameter should be blank.

aajisaka · 2022-06-21T23:52:50Z

For the contributors who don't have Apache ID:

Create an empty commit in the branch and push to your mirror.

hadoop-yetus · 2022-06-22T18:01:38Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 42s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	37m 48s		trunk passed
+1 💚	compile	22m 31s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	19m 45s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	mvnsite	18m 57s		trunk passed
+1 💚	javadoc	8m 38s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	7m 13s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	shadedclient	135m 20s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	22m 29s		the patch passed
+1 💚	compile	24m 13s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	24m 13s		the patch passed
+1 💚	compile	21m 6s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	21m 6s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	19m 0s		the patch passed
+1 💚	javadoc	8m 30s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	7m 29s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	shadedclient	55m 58s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	808m 6s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	1m 34s		The patch does not generate ASF License warnings.
		1071m 32s

Reason	Tests
Failed junit tests	hadoop.mapred.TestLocalDistributedCacheManager
	hadoop.yarn.server.router.webapp.TestRouterWebServicesREST

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4449/2/artifact/out/Dockerfile
GITHUB PR	#4449
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname	Linux d304b82ef3cf 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `1e12e7b`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4449/2/testReport/
Max. process+thread count	3056 (vs. ulimit of 5500)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4449/2/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-06-23T02:54:31Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 58s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
-1 ❌	mvninstall	40m 7s	/branch-mvninstall-root.txt	root in trunk failed.
+1 💚	compile	24m 51s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	21m 30s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	mvnsite	19m 44s		trunk passed
+1 💚	javadoc	8m 34s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	7m 31s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	shadedclient	145m 5s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	24m 18s		the patch passed
+1 💚	compile	24m 34s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	24m 34s		the patch passed
+1 💚	compile	23m 1s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	23m 1s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	19m 41s		the patch passed
+1 💚	javadoc	8m 32s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	7m 22s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	shadedclient	60m 24s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	1074m 15s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	2m 16s		The patch does not generate ASF License warnings.
		1357m 2s

Reason	Tests
Failed junit tests	hadoop.mapred.TestLocalDistributedCacheManager
	hadoop.yarn.server.router.webapp.TestRouterWebServicesREST
	hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4449/3/artifact/out/Dockerfile
GITHUB PR	#4449
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname	Linux 1e109e1e281f 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `1e12e7b`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4449/3/testReport/
Max. process+thread count	2172 (vs. ulimit of 5500)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4449/3/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

jojochuang

+1 the mvn install failures looks unrelated. Does not repro on my laptop.

jojochuang · 2022-06-30T20:33:24Z

I triggered another build just to be sure.

hotcodemacha · 2022-06-30T20:49:26Z

I triggered another build just to be sure.

Thanks @jojochuang

hadoop-yetus · 2022-07-01T19:27:52Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 0s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	40m 39s		trunk passed
+1 💚	compile	25m 14s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	21m 48s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	mvnsite	20m 1s		trunk passed
+1 💚	javadoc	8m 37s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	7m 30s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	shadedclient	146m 57s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	24m 39s		the patch passed
+1 💚	compile	24m 32s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	24m 32s		the patch passed
+1 💚	compile	21m 46s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	21m 46s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	mvnsite	19m 36s		the patch passed
+1 💚	javadoc	8m 51s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	7m 30s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	shadedclient	60m 50s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	1089m 31s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	2m 23s		The patch does not generate ASF License warnings.
		1373m 35s

Reason	Tests
Failed junit tests	hadoop.yarn.applications.distributedshell.TestDSTimelineV10

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4449/4/artifact/out/Dockerfile
GITHUB PR	#4449
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname	Linux 54441a7099ee 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `1e12e7b`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4449/4/testReport/
Max. process+thread count	2844 (vs. ulimit of 5500)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4449/4/console
versions	git=2.25.1 maven=3.6.3
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

jojochuang · 2022-07-02T20:04:42Z

+1

hotcodemacha · 2022-07-05T00:03:16Z

Thanks @jojochuang for reviewing and merging the PR, Can you mark the JIRA as fixed as well ? Thanks a lot.

dannycjones · 2022-07-05T08:01:18Z

Thanks @jojochuang for reviewing and merging the PR, Can you mark the JIRA as fixed as well ? Thanks a lot.

Akira has resolved HADOOP-18297.

Co-authored-by: Ashutosh Gupta <[email protected]>

HADOOP-18297. Upgrade dependency-check-maven to 7.1.1

3c2414d

Trigger jenkins

1e12e7b

jojochuang approved these changes Jun 30, 2022

View reviewed changes

hotcodemacha requested a review from jojochuang July 2, 2022 19:34

jojochuang merged commit 9e206fe into apache:trunk Jul 2, 2022

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022

HADOOP-18297. Upgrade dependency-check-maven to 7.1.1 (apache#4449)

b3583e9

Co-authored-by: Ashutosh Gupta <[email protected]>

HADOOP-18297. Upgrade dependency-check-maven to 7.1.1 #4449

HADOOP-18297. Upgrade dependency-check-maven to 7.1.1 #4449

Uh oh!

Conversation

hotcodemacha commented Jun 17, 2022

Description of PR

Uh oh!

hadoop-yetus commented Jun 18, 2022

Uh oh!

PrabhuJoseph commented Jun 20, 2022

Uh oh!

aajisaka commented Jun 21, 2022

Uh oh!

aajisaka commented Jun 21, 2022

Uh oh!

hadoop-yetus commented Jun 22, 2022

Uh oh!

hadoop-yetus commented Jun 23, 2022

Uh oh!

jojochuang left a comment

Choose a reason for hiding this comment

Uh oh!

jojochuang commented Jun 30, 2022

Uh oh!

hotcodemacha commented Jun 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hadoop-yetus commented Jul 1, 2022

Uh oh!

jojochuang commented Jul 2, 2022

Uh oh!

hotcodemacha commented Jul 5, 2022

Uh oh!

dannycjones commented Jul 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

hotcodemacha commented Jun 30, 2022 •

edited

Loading

dannycjones commented Jul 5, 2022 •

edited

Loading