Skip to content

Conversation

@andreAmorimF
Copy link
Contributor

@andreAmorimF andreAmorimF commented Jun 15, 2022

Description of PR

Bumping cos_api-bundle to 5.6.69

How was this patch tested?

In my internal environment. The public-suffix-list.txt resource brought on the classpath by this jar is now consistent with other versions (avoiding cert issues in some cases).

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@andreAmorimF andreAmorimF changed the title Bumping cos_api-bundle - fix public-suffix-list.txt HADOOP-18159 Bumping cos_api-bundle - fix public-suffix-list.txt Jun 15, 2022
@andreAmorimF andreAmorimF changed the title HADOOP-18159 Bumping cos_api-bundle - fix public-suffix-list.txt HADOOP-18159. Bumping cos_api-bundle - fix public-suffix-list.txt Jun 15, 2022
@steveloughran
Copy link
Contributor

normally i'd say "did you run the cloud tests?" but

  1. the old JAR breaks things I do get to field support calls on
  2. I'm not set up to test this either.

+1 pending the CI build working

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 0s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 xmllint 0m 1s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 42m 4s trunk passed
+1 💚 compile 0m 36s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 compile 0m 34s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 mvnsite 0m 39s trunk passed
+1 💚 javadoc 0m 42s trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javadoc 0m 35s trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 shadedclient 67m 52s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 27s the patch passed
+1 💚 compile 0m 23s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javac 0m 23s the patch passed
+1 💚 compile 0m 21s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 javac 0m 21s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 23s the patch passed
+1 💚 javadoc 0m 22s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javadoc 0m 22s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 shadedclient 24m 36s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 26s hadoop-cos in the patch passed.
+1 💚 asflicense 0m 42s The patch does not generate ASF License warnings.
97m 44s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4444/1/artifact/out/Dockerfile
GITHUB PR #4444
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname Linux f07b68722393 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 13d6455
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4444/1/testReport/
Max. process+thread count 522 (vs. ulimit of 5500)
modules C: hadoop-cloud-storage-project/hadoop-cos U: hadoop-cloud-storage-project/hadoop-cos
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4444/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran steveloughran merged commit 1b25851 into apache:trunk Jun 15, 2022
asfgit pushed a commit that referenced this pull request Jun 21, 2022
…ist.txt (#4444)


Bump cos_api-bundle to 5.6.69

All copies of httpclient, including shaded ones in libraries used
by the s3a, gs and cos cloud connectors, turn out to load their
TLD list from the same resource mozilla/public-suffix-list.txt 

Updating the hadoop-cos dependency ensures that its version 
of public-suffix-list.txt is up to date -and so the s3a connector 
able to talk to s3 resources if the cos-api-bundle JAR is where
the resource is loaded from.

Contributed by André Fonseca
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
…ist.txt (apache#4444)


Bump cos_api-bundle to 5.6.69

All copies of httpclient, including shaded ones in libraries used
by the s3a, gs and cos cloud connectors, turn out to load their
TLD list from the same resource mozilla/public-suffix-list.txt 

Updating the hadoop-cos dependency ensures that its version 
of public-suffix-list.txt is up to date -and so the s3a connector 
able to talk to s3 resources if the cos-api-bundle JAR is where
the resource is loaded from.

Contributed by André Fonseca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants