HADOOP-18229. Fix Hadoop-Common JavaDoc Error #4292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
added 11 commits
May 9, 2022 05:12
|
@steveloughran Thanks for review the code, I tried to fix some compilation problems of Java Doc, including error and warn, but there are a lot of problems, I will submit another batch of fixes in the next JIRA |
This comment was marked as outdated.
This comment was marked as outdated.
goiri
approved these changes
May 9, 2022
GenericOptionsParser.java empty p tag and unexpected end tag: p Tool.java empty p tag RemoteIterators.java empty p tag FileSystem.java empty p tag MultipartUploaderBuilder.java no description for @param InodeTree.java reference not found JMXJsonServlet.java empty p tag and unexpected end tag CBZip2OutputStream.java no summary or caption for table
|
Thanks for taking this up, +1 (non-binding) assuming next QA results from Jenkins are good for Javadoc |
|
💔 -1 overall
This message was automatically generated. |
added 3 commits
May 9, 2022 21:32
ConfigRedactor.java no description for @param Configuration.java warning: no @return, no description for @param, no @param for <U>, no @throws for java.io.IOException, no description for @throws etc. GenericOptionsParser.java unexpected end tag. IOStatisticsSnapshot.java warning: empty <p> tag. Writable.java no description for @throws.
Configured.java no @param for conf CryptoCodec.java no @throws for java.security.GeneralSecurityException Reconfigurable.java no @param for property, no @param for newVal, no @throws for org.apache.hadoop.conf.ReconfigurationException ReconfigurableBase.java no @param for conf,no @return,no @throws for java.io.IOException ReconfigurationException.java no @param for property, no @param for newVal, no @param for cause for property etc ReconfigurationTaskStatus.java no @return
CryptoInputStream.java no description for @throws, CryptoOutputStream.java no description for @throws, CryptoStreamUtils.java no @param for buffer, no @param for conf, no @return, no @param for codec, no @throws for java.io.IOException HasFileDescriptor.java no description for @throws, KeyProvider.java no description for @throws, OpensslCipher.java no description for @throws, Seekable.java no @param for pos, no @throws for java.io.IOException, no @param for targetPos
This comment was marked as outdated.
This comment was marked as outdated.
KeyProvider.java no @throws for java.security.NoSuchAlgorithmException, no @throws for java.io.IOException KeyProviderCryptoExtension.java warning: no description for @param, warning: no @throws for java.io.IOException DelegationTokenIssuer.java warning: no @return, warning: no @param for renewer, no @param for issuer etc KeyProviderDelegationTokenExtension.java no description for @throws, Tool.java warning: no description for @throws CommandShell.java warning: no @return, warning: no description for @param KeyShell.java warning: no description for @throws TokenRenewer.java warning: no description for @throws,warning: no @param for token
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
💔 -1 overall
This message was automatically generated. |
AbstractFileSystem.java no @param for f, no @param for opts etc Configuration.java warning: no @throws for java.lang.Exception CryptoStreamUtils.java: warning: no @param for buffer KeyProvider.java warning: no description for @throws DelegationTokenIssuer.java: no description for @param TokenRenewer.java: no @param for token ValueQueue.java: no description for @throws CryptoStreamUtils.java checkstyle KeyProvider.java checkstyle OpensslCipher.java checkstyle
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
added 2 commits
May 16, 2022 03:56
Change Pom.xml Maven Support JDK1.8
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@steveloughran @virajjasani @goiri I have completed the compilation and repair of hadoop-common under jdk11, please help to review the code. Thank you everyone. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Hi,@steveloughran @virajjasani @goiri , I have fixed hadoop-common javadoc compilation problem in jdk11, please help to review the code. The java doc compilation will run twice, the first time it is compiled directly using the trunk branch, and the second time it will be compiled in merge pr. The error you see is the error after compiling the trunk branch, the problem is solved after merge pr. my changes are as follows: 1.modify the java doc configuration of the pom file, skip the proto file. 2.fix the warn and error problems, as follows: |
|
@steveloughran please help to review the code, I feel that this work is quite meaningful, for the code normative point of view, thanks! |
steveloughran
approved these changes
May 18, 2022
|
now, can we get this cherrypicked into branch-3.3? |
Thank you very much for your help reviewing the code, I will push the changes to branch3.3. |
I fixed it in PR(#4327) |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
Contributed by slfan1989
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA：HADOOP-18229. Fix Hadoop Common Java Doc Error
It is found that the JavaDoc Error problem blocks the merge of HADOOP-18222. HADOOP-18222 will cause the RM startup problem, which needs to be solved as soon as possible.