Skip to content

YARN-11123. ResourceManager webapps test failures due to org.apache.hadoop.metrics2.MetricsException and subsequent java.net.BindException: Address already in use #4289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

YARN-11123. ResourceManager webapps test failures due to org.apache.hadoop.metrics2.MetricsException and subsequent java.net.BindException: Address already in use #4289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a84e40f
TestRMWebServicesDelegationTokenAuthentication: Call DefaultMetricsSy…
szilard-nemeth May 8, 2022
9545561
Fix error handling in case ResourceManager's web app can't be started…
szilard-nemeth May 8, 2022
6102d0e
Revert "TestRMWebServicesDelegationTokenAuthentication: Call DefaultM…
szilard-nemeth May 12, 2022
08897ad
Empty-Commit
szilard-nemeth May 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebAppException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@
public class WebAppException extends YarnRuntimeException {

private static final long serialVersionUID = 1L;
private WebApp webApp;

public WebApp getWebApp() {
return webApp;
}

public WebAppException(String msg) {
super(msg);
Expand All @@ -35,6 +40,11 @@ public WebAppException(Throwable cause) {
}

public WebAppException(String msg, Throwable cause) {
this(msg, cause, null);
}

public WebAppException(String msg, Throwable cause, WebApp webApp) {
super(msg, cause);
this.webApp = webApp;
}
}
2 changes: 1 addition & 1 deletion ...t/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ public WebApp start(WebApp webapp, WebAppContext ui2Context) {
LOG.info("Web app " + name + " started at "
+ httpServer.getConnectorAddress(0).getPort());
} catch (IOException e) {
throw new WebAppException("Error starting http server", e);
throw new WebAppException("Error starting http server", e, webApp);
}
return webApp;
}
Expand Down
8 changes: 7 additions & 1 deletion ...emanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import com.sun.jersey.spi.container.servlet.ServletContainer;

import org.apache.hadoop.yarn.metrics.GenericEventTypeMetrics;
import org.apache.hadoop.yarn.webapp.WebAppException;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.slf4j.Marker;
Expand Down Expand Up @@ -1440,7 +1441,12 @@ protected void startWepApp() {
IsResourceManagerActiveServlet.PATH_SPEC,
IsResourceManagerActiveServlet.class);

webApp = builder.start(new RMWebApp(this), uiWebAppContext);
try {
webApp = builder.start(new RMWebApp(this), uiWebAppContext);
} catch (WebAppException e) {
webApp = e.getWebApp();
throw e;
}
}

private String getWebAppsPath(String appName) {
Expand Down