YARN-11116. Migrate Times util from SimpleDateFormat to thread-safe D…

[jteagles]

…ateTimeFormatter class

Description of PR

Upgrading to the recommended thread safe java.time libraries for formatting and parsing with a little better performance

How was this patch tested?

Attached a performance test patch to the jira and added unit test to ensure compatible behavior

For code changes:

• [ x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
• [ x] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
• [ x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• [ x] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

[hadoop-yetus]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 36s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	38m 28s		trunk passed
+1 💚	compile	1m 5s		trunk passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	compile	1m 1s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	0m 57s		trunk passed
+1 💚	mvnsite	1m 7s		trunk passed
+1 💚	javadoc	1m 12s		trunk passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 2s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	2m 7s		trunk passed
+1 💚	shadedclient	21m 27s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 45s		the patch passed
+1 💚	compile	0m 48s		the patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javac	0m 48s		the patch passed
+1 💚	compile	0m 44s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 44s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 34s		hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common: The patch generated 0 new + 1 unchanged - 2 fixed = 1 total (was 3)
+1 💚	mvnsite	0m 46s		the patch passed
+1 💚	javadoc	0m 45s		the patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	0m 44s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	1m 46s		the patch passed
+1 💚	shadedclient	21m 6s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	4m 59s		hadoop-yarn-common in the patch passed.
+1 💚	asflicense	0m 49s		The patch does not generate ASF License warnings.
		103m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4242/1/artifact/out/Dockerfile
GITHUB PR	#4242
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 6e562b66e22e 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / e194e3f
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4242/1/testReport/
Max. process+thread count	550 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4242/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

[aajisaka]

Thank you @jteagles for migrating to Java 8 Date/Time API. I'm +1 if my comment is addressed.

[jteagles]

@aajisaka, I was hoping to backport this to earlier lines. Do you see any problem with me backporting to 2.10.x? Perhaps that is too far back.

I was taking a look at https://cwiki.apache.org/confluence/display/HADOOP/GitHub+Integration#GitHubIntegration-MergingaPR(forcommitters) to catch myself up with the updated github process. Before, I would just cherry-pick at this now that it is merged to trunk, but don't see the exact steps to follow.

[aajisaka]

@jteagles, I cannot backport this to 2.10.x because 2.10.x still supports JDK 7.

How to update the release branches

Just cherry-picking the trunk commit to the branches is fine. Thanks.

[jteagles]

@aajisaka, good catch on jdk 7. Thanks so much on this jira.