HDFS-16537.Fix oev decode xml error #4160

GuoPhilipse · 2022-04-11T11:11:52Z

JIRA:HDFS-16537

sync

hadoop-yetus · 2022-04-11T17:12:55Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 40s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 34s		trunk passed
+1 💚	compile	1m 35s		trunk passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	compile	1m 26s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 10s		trunk passed
+1 💚	mvnsite	1m 39s		trunk passed
+1 💚	javadoc	1m 16s		trunk passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 41s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 57s		trunk passed
+1 💚	shadedclient	26m 26s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 24s		the patch passed
+1 💚	compile	1m 31s		the patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javac	1m 31s		the patch passed
+1 💚	compile	1m 19s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	1m 19s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 1s		the patch passed
+1 💚	mvnsite	1m 29s		the patch passed
+1 💚	javadoc	0m 57s		the patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 28s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 28s		the patch passed
+1 💚	shadedclient	26m 5s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	241m 59s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 45s		The patch does not generate ASF License warnings.
		359m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4160/1/artifact/out/Dockerfile
GITHUB PR	#4160
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 52ae822bd966 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `3276544`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4160/1/testReport/
Max. process+thread count	3320 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4160/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Hexiaoqiao · 2022-04-17T12:33:03Z

...fs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java

      this.timestamp = Long.parseLong(st.getValue("TIMESTAMP"));
      if (st.hasChildren("BLOCK"))
-        this.truncateBlock = FSEditLogOp.blockFromXml(st);
+        this.truncateBlock = FSEditLogOp.blockFromXml(st.getChildren("BLOCK").get(0));


Good catch here. I think it is better to fix it at org.apache.hadoop.hdfs.server.namenode.FSEditLogOp#blockFromXml. Thanks.

After another review, I think it is proper now. Do you mind to add new unit test to cover this case?

thanks @Hexiaoqiao for your review, will add test later

hadoop-yetus · 2022-04-24T22:00:45Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 40s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	39m 9s		trunk passed
+1 💚	compile	1m 39s		trunk passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	compile	1m 35s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 29s		trunk passed
+1 💚	mvnsite	1m 47s		trunk passed
+1 💚	javadoc	1m 25s		trunk passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 50s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 44s		trunk passed
+1 💚	shadedclient	23m 22s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 22s		the patch passed
+1 💚	compile	1m 27s		the patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javac	1m 27s		the patch passed
+1 💚	compile	1m 19s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	1m 19s		the patch passed
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️	checkstyle	1m 5s	/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 338 unchanged - 0 fixed = 340 total (was 338)
+1 💚	mvnsite	1m 24s		the patch passed
+1 💚	javadoc	0m 59s		the patch passed with JDK Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 32s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 25s		the patch passed
+1 💚	shadedclient	22m 40s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	253m 6s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	1m 12s		The patch does not generate ASF License warnings.
		364m 8s

Reason	Tests
Failed junit tests	hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4160/2/artifact/out/Dockerfile
GITHUB PR	#4160
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 4618e2d41192 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `4dc4150`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14.1+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4160/2/testReport/
Max. process+thread count	3290 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4160/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

GuoPhilipse and others added 22 commits November 29, 2020 05:02

Merge pull request #1 from apache/trunk

3c51579

sync

Merge pull request #2 from apache/trunk

a449d04

sync

Merge pull request #3 from apache/trunk

d4f968b

sync

Merge pull request #4 from apache/trunk

d522abf

sync

Merge pull request #5 from apache/trunk

de633b8

sync

Merge pull request #6 from apache/trunk

66ce06b

sync

Merge pull request #7 from apache/trunk

bea061f

sync

'triggerrebuild'

ee06d41

Merge pull request #8 from apache/trunk

9375f21

sync

Merge branch 'trunk' of github.com:GuoPhilipse/hadoop into trunk

8721aa8

Merge pull request #9 from apache/trunk

56a7aea

sync

Merge branch 'trunk' of github.com:GuoPhilipse/hadoop into trunk

9d39e29

Merge pull request #10 from apache/trunk

989f31c

sync

Merge branch 'trunk' of github.com:GuoPhilipse/hadoop into trunk

d028aae

Merge pull request #11 from apache/trunk

60f347a

sync

Merge branch 'trunk' of github.com:GuoPhilipse/hadoop into trunk

296d306

Merge pull request #12 from apache/trunk

99a3513

sync

Merge pull request #13 from apache/trunk

0797b25

sync

Merge branch 'trunk' of github.com:GuoPhilipse/hadoop into trunk

1881045

Merge pull request #14 from apache/trunk

6f29c61

sync

Merge branch 'trunk' of github.com:GuoPhilipse/hadoop into trunk

0e68cc6

'fixdecodeerror'

3276544

Hexiaoqiao reviewed Apr 17, 2022

View reviewed changes

addtestcase

4dc4150

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDFS-16537.Fix oev decode xml error #4160

HDFS-16537.Fix oev decode xml error #4160

GuoPhilipse commented Apr 11, 2022

Uh oh!

hadoop-yetus commented Apr 11, 2022

Uh oh!

Hexiaoqiao Apr 17, 2022

Uh oh!

Hexiaoqiao Apr 17, 2022

Uh oh!

Hexiaoqiao Apr 17, 2022

Uh oh!

GuoPhilipse Apr 18, 2022

Uh oh!

hadoop-yetus commented Apr 24, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

HDFS-16537.Fix oev decode xml error #4160

Are you sure you want to change the base?

HDFS-16537.Fix oev decode xml error #4160

Conversation

GuoPhilipse commented Apr 11, 2022

Uh oh!

hadoop-yetus commented Apr 11, 2022

Uh oh!

Hexiaoqiao Apr 17, 2022

Choose a reason for hiding this comment

Uh oh!

Hexiaoqiao Apr 17, 2022

Choose a reason for hiding this comment

Uh oh!

Hexiaoqiao Apr 17, 2022

Choose a reason for hiding this comment

Uh oh!

GuoPhilipse Apr 18, 2022

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Apr 24, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants