Skip to content

Conversation

@iwasakims
Copy link
Member

https://issues.apache.org/jira/browse/HADOOP-18192

Jar of slf4j-relad4j exists in libdirs of both common and hdfs.

$ ~/dist/hadoop-3.2.4-SNAPSHOT/bin/hdfs dfs -ls /
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/ext/dist/hadoop-3.2.4-SNAPSHOT/share/hadoop/common/lib/slf4j-reload4j-1.7.35.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/ext/dist/hadoop-3.2.4-SNAPSHOT/share/hadoop/hdfs/lib/slf4j-reload4j-1.7.35.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Reload4jLoggerFactory]


$ find ~/dist/hadoop-3.2.4-SNAPSHOT/ -name 'slf4j-reload4j-*.jar'
/home/centos/dist/hadoop-3.2.4-SNAPSHOT/share/hadoop/common/lib/slf4j-reload4j-1.7.35.jar
/home/centos/dist/hadoop-3.2.4-SNAPSHOT/share/hadoop/hdfs/lib/slf4j-reload4j-1.7.35.jar

We need to update the part referring to slf4j-log4j12 in files under hadoop-assemblies too.

@iwasakims
Copy link
Member Author

The patch removed duplicate slf4j-reload4j-1.7.35.jar in dist layout on my local.

$ mvn clean install -DskipTests -DskipShade -Pdist
$ find hadoop-dist/target/hadoop-3.2.4-SNAPSHOT -name 'slf4j-reload4j*.jar'
hadoop-dist/target/hadoop-3.2.4-SNAPSHOT/share/hadoop/common/lib/slf4j-reload4j-1.7.35.jar

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 8m 10s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 1s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-3.2 Compile Tests _
+1 💚 mvninstall 30m 21s branch-3.2 passed
+1 💚 compile 0m 20s branch-3.2 passed
+1 💚 mvnsite 0m 25s branch-3.2 passed
+1 💚 javadoc 0m 31s branch-3.2 passed
+1 💚 shadedclient 44m 30s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 15s the patch passed
+1 💚 compile 0m 13s the patch passed
+1 💚 javac 0m 13s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 15s the patch passed
+1 💚 xml 0m 9s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 14s the patch passed
+1 💚 shadedclient 14m 49s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 17s hadoop-assemblies in the patch passed.
+1 💚 asflicense 0m 36s The patch does not generate ASF License warnings.
71m 4s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4136/1/artifact/out/Dockerfile
GITHUB PR #4136
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml
uname Linux 014f641a528d 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.2 / 8bca719
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4136/1/testReport/
Max. process+thread count 411 (vs. ulimit of 5500)
modules C: hadoop-assemblies U: hadoop-assemblies
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4136/1/console
versions git=2.17.1 maven=3.6.0
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Copy link
Member

@aajisaka aajisaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thank you @iwasakims

@iwasakims iwasakims merged commit 2d770e4 into apache:branch-3.2 Apr 6, 2022
@iwasakims
Copy link
Member Author

I merged this. Thanks, @aajisaka.

jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
…eload4j. (apache#4136)

(cherry picked from commit 2d770e4)
Change-Id: I15ae5d08c842fb5ffac6ec808609e7a8ae112814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants