HADOOP-18117. Add an option to preserve root directory permissions #3970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
It might be better to add a test, e.g. ...
fs.setOwner(src,"userA", "groupA");
fs.setTimes(src, new Random().nextLong(), new Random().nextLong());
String[] args = {"-p", "-update", src.toString(), dest.toString()};
DistCp distCp = new DistCp(conf, null);
assertEquals(DistCpConstants.SUCCESS, ToolRunner.run(conf, distCp, args));
FileStatus srcStatus = fs.getFileStatus(src);
FileStatus destStatus = fs.getFileStatus(dest);
assertTrue(destStatus.getOwner().equals(srcStatus.getOwner()));
assertTrue(destStatus.getModificationTime() == srcStatus.getModificationTime()); |
|
@whbing you mean something like this to test functionality before and after? @Test
public void testUpdateRootDirectoryAttributes() throws Exception {
FileSystem fs = cluster.getFileSystem();
Path source = new Path("/src");
Path dest1 = new Path("/dest1");
Path dest2 = new Path("/dest2");
fs.delete(source, true);
fs.delete(dest1, true);
fs.delete(dest2, true);
// Create a source dir
fs.mkdirs(source);
fs.setOwner(source,"userA", "groupA");
fs.setTimes(source, new Random().nextLong(), new Random().nextLong());
GenericTestUtils.createFiles(fs, source, 3, 5, 5);
// should not preserve attrs
DistCpTestUtils.assertRunDistCp(DistCpConstants.SUCCESS, source.toString(),
dest1.toString(), "-p -update", conf);
FileStatus srcStatus = fs.getFileStatus(source);
FileStatus destStatus1 = fs.getFileStatus(dest1);
assertNotEquals(destStatus1.getOwner(), srcStatus.getOwner());
assertNotEquals(destStatus1.getModificationTime(), srcStatus.getModificationTime());
// should preserve attrs
DistCpTestUtils.assertRunDistCp(DistCpConstants.SUCCESS, source.toString(),
dest2.toString(), "-p -update -updateRootDirectoryAttributes", conf);
FileStatus destStatus2 = fs.getFileStatus(dest1);
assertEquals(destStatus2.getOwner(), srcStatus.getOwner());
assertEquals(destStatus2.getModificationTime(), srcStatus.getModificationTime());
} |
|
🎊 +1 overall
This message was automatically generated. |
|
@mohan3d Overall it looks good. Please check the checkstyle reported by Yetus. |
|
🎊 +1 overall
This message was automatically generated. |
ferhui
reviewed
Feb 14, 2022
hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestDistCpSystem.java
Outdated
Show resolved
Hide resolved
| | `-xtrack <path>` | Save information about missing source files to the specified path. | This option is only valid with `-update` option. This is an experimental property and it cannot be used with `-atomic` option. | | ||
| | `-direct` | Write directly to destination paths | Useful for avoiding potentially very expensive temporary file rename operations when the destination is an object store | | ||
| | `-useiterator` | Uses single threaded listStatusIterator to build listing | Useful for saving memory at the client side. Using this option will ignore the numListstatusThreads option | | ||
| | `-updateRootDirectoryAttributes` | Update root directory attributes (eg permissions, ownership ...) | Useful if you need to enforce root directory attributes update when using distcp | |
There was a problem hiding this comment.
Could you replace updateRoot instead of updateRootDirectoryAttributes or give another short name?
There was a problem hiding this comment.
sure, since we have no other suggestions I will go with updateRoot.
There was a problem hiding this comment.
@ferhui should I re-work the internal code so everything is updateRoot instead of updateRootDirectoryAttributes or only the enduser distcp tool?
Better to be consistent and use updateRoot everywhere.
mohan3d
force-pushed
the
HADOOP-18117
branch
from
a79999c to
f62d3c3
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
ferhui
approved these changes
Feb 15, 2022
|
Since there are no other comments within these days, I merge this. |
|
Thanks @ferhui! |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Add an option to preserve root directory permissions when using distcp
How was this patch tested?
dev-support/bin/test-patch against trunk and unittest
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?