-
Notifications
You must be signed in to change notification settings - Fork 9.2k
YARN-11053. AuxService should not use class name as default system classes #3816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
Member
Author
|
@aajisaka would you please take a look? |
aajisaka
approved these changes
Dec 23, 2021
Member
aajisaka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. The fix makes sense.
aajisaka
pushed a commit
that referenced
this pull request
Dec 24, 2021
…asses (#3816) Signed-off-by: Akira Ajisaka <[email protected]> (cherry picked from commit 4db27ac)
Member
|
Thank you @pan3793 for your contribution! |
aajisaka
pushed a commit
that referenced
this pull request
Jan 4, 2022
…asses (#3816) Signed-off-by: Akira Ajisaka <[email protected]> (cherry picked from commit 4db27ac) (cherry picked from commit 7b51e68)
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…asses (apache#3816) Signed-off-by: Akira Ajisaka <[email protected]>
symious
pushed a commit
to symious/hadoop
that referenced
this pull request
Nov 21, 2024
…asses (apache#3816) Signed-off-by: Akira Ajisaka <[email protected]> (cherry picked from commit 4db27ac) (cherry picked from commit 7b51e68)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
[YARN-11053] AuxService should not use class name as default system classes
Currently, if
yarn.nodemanager.aux-services.spark_shuffle.system-classesis absent, yarn will treatyarn.nodemanager.aux-services.spark_shuffle.classas the system classes, and use system ClassLoader rather than AuxServiceClassLoader to load aux service entry class, then cause ClassNotFound exception.How was this patch tested?
Existing UTs.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?