-
Notifications
You must be signed in to change notification settings - Fork 9.1k
YARN-11034. Add enhanced headroom in AllocateResponse #3766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72 changes: 72 additions & 0 deletions
72
...rn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/records/EnhancedHeadroom.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * <p> | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * <p> | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.hadoop.yarn.api.records; | ||
|
|
||
| import org.apache.hadoop.yarn.util.Records; | ||
|
|
||
| /** | ||
| * Enhanced head room in AllocateResponse. | ||
| * This provides a channel for RMs to return load information for AMRMProxy | ||
| * decision making when rerouting resource requests. | ||
| * | ||
| * Contains total pending container count and active cores for a cluster. | ||
| */ | ||
| public abstract class EnhancedHeadroom { | ||
| public static EnhancedHeadroom newInstance(int totalPendingCount, | ||
| int totalActiveCores) { | ||
| EnhancedHeadroom enhancedHeadroom = | ||
| Records.newRecord(EnhancedHeadroom.class); | ||
| enhancedHeadroom.setTotalPendingCount(totalPendingCount); | ||
| enhancedHeadroom.setTotalActiveCores(totalActiveCores); | ||
| return enhancedHeadroom; | ||
| } | ||
|
|
||
| /** | ||
| * Set total pending container count. | ||
| * @param totalPendingCount the pending container count | ||
| */ | ||
| public abstract void setTotalPendingCount(int totalPendingCount); | ||
|
|
||
| /** | ||
| * Get total pending container count. | ||
| * @return the pending container count | ||
| */ | ||
| public abstract int getTotalPendingCount(); | ||
|
|
||
| /** | ||
| * Set total active cores for the cluster. | ||
| * @param totalActiveCores the total active cores for the cluster | ||
| */ | ||
| public abstract void setTotalActiveCores(int totalActiveCores); | ||
|
|
||
| /** | ||
| * Get total active cores for the cluster. | ||
| * @return totalActiveCores the total active cores for the cluster | ||
| */ | ||
| public abstract int getTotalActiveCores(); | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| StringBuilder sb = new StringBuilder(); | ||
| sb.append("<pendingCount:").append(this.getTotalPendingCount()); | ||
| sb.append(", activeCores:").append(this.getTotalActiveCores()); | ||
| sb.append(">"); | ||
| return sb.toString(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
123 changes: 123 additions & 0 deletions
123
...mmon/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/EnhancedHeadroomPBImpl.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * <p> | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * <p> | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.hadoop.yarn.api.records.impl.pb; | ||
|
|
||
| import org.apache.hadoop.yarn.api.records.EnhancedHeadroom; | ||
| import org.apache.hadoop.yarn.proto.YarnServiceProtos.EnhancedHeadroomProto; | ||
| import org.apache.hadoop.yarn.proto.YarnServiceProtos.EnhancedHeadroomProtoOrBuilder; | ||
|
|
||
| import org.apache.hadoop.thirdparty.protobuf.TextFormat; | ||
|
|
||
| public class EnhancedHeadroomPBImpl extends EnhancedHeadroom { | ||
|
|
||
| private EnhancedHeadroomProto proto = | ||
| EnhancedHeadroomProto.getDefaultInstance(); | ||
| private EnhancedHeadroomProto.Builder builder = null; | ||
| private boolean viaProto = false; | ||
|
|
||
| public EnhancedHeadroomPBImpl() { | ||
| builder = EnhancedHeadroomProto.newBuilder(); | ||
| } | ||
|
|
||
| public EnhancedHeadroomPBImpl(EnhancedHeadroomProto proto) { | ||
| this.proto = proto; | ||
| viaProto = true; | ||
| } | ||
|
|
||
| public EnhancedHeadroomProto getProto() { | ||
| mergeLocalToProto(); | ||
| proto = viaProto ? proto : builder.build(); | ||
| viaProto = true; | ||
| return proto; | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return getProto().hashCode(); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object other) { | ||
| if (other == null) { | ||
| return false; | ||
| } | ||
| if (other.getClass().isAssignableFrom(this.getClass())) { | ||
| return this.getProto().equals(this.getClass().cast(other).getProto()); | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return TextFormat.shortDebugString(getProto()); | ||
| } | ||
|
|
||
| private void mergeLocalToBuilder() { | ||
| // No local content yet | ||
| } | ||
|
|
||
| private void mergeLocalToProto() { | ||
| if (viaProto) { | ||
| maybeInitBuilder(); | ||
| } | ||
| mergeLocalToBuilder(); | ||
| proto = builder.build(); | ||
| viaProto = true; | ||
| } | ||
|
|
||
| private void maybeInitBuilder() { | ||
| if (viaProto || builder == null) { | ||
| builder = EnhancedHeadroomProto.newBuilder(proto); | ||
| } | ||
| viaProto = false; | ||
| } | ||
|
|
||
| @Override | ||
| public void setTotalPendingCount(int totalPendingCount) { | ||
| maybeInitBuilder(); | ||
| if (totalPendingCount == 0) { | ||
| builder.clearTotalPendingCount(); | ||
| return; | ||
| } | ||
| builder.setTotalPendingCount(totalPendingCount); | ||
| } | ||
|
|
||
| @Override | ||
| public int getTotalPendingCount() { | ||
| EnhancedHeadroomProtoOrBuilder p = viaProto ? proto : builder; | ||
| return (p.hasTotalPendingCount()) ? p.getTotalPendingCount() : 0; | ||
| } | ||
|
|
||
| @Override | ||
| public void setTotalActiveCores(int totalActiveCores) { | ||
| maybeInitBuilder(); | ||
| if (totalActiveCores == 0) { | ||
| builder.clearTotalActiveCores(); | ||
| return; | ||
| } | ||
| builder.setTotalActiveCores(totalActiveCores); | ||
| } | ||
|
|
||
| @Override | ||
| public int getTotalActiveCores() { | ||
| EnhancedHeadroomProtoOrBuilder p = viaProto ? proto : builder; | ||
| return (p.hasTotalActiveCores()) ? p.getTotalActiveCores() : 0; | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.