Skip to content

Conversation

@PHILO-HE
Copy link
Member

@PHILO-HE PHILO-HE commented Dec 8, 2021

Description of PR

Fix an issue: 'hadoop check native' command doesn't correctly reflect the loading state of native pmdk lib when this lib is removed after building.

How was this patch tested?

We tested the validity of the patch on our lab machine. The test depends on the installation of pmdk lib.

For code changes:

  • [Yes] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • [N/A] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • [N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [N/A] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

Copy link
Contributor

@rakeshadr rakeshadr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1LGTM, thanks @PHILO-HE for the contribution.

Pending Build CI

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 43m 17s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 36m 4s trunk passed
+1 💚 compile 20m 22s trunk passed
+1 💚 checkstyle 1m 0s trunk passed
+1 💚 mvnsite 1m 37s trunk passed
+1 💚 javadoc 1m 42s trunk passed
+1 💚 spotbugs 2m 31s trunk passed
+1 💚 shadedclient 25m 1s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 1s the patch passed
+1 💚 compile 19m 35s the patch passed
-1 ❌ cc 19m 35s /results-compile-cc-root.txt root generated 23 new + 182 unchanged - 23 fixed = 205 total (was 205)
+1 💚 golang 19m 35s the patch passed
+1 💚 javac 19m 35s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 58s the patch passed
+1 💚 mvnsite 1m 36s the patch passed
+1 💚 javadoc 1m 39s the patch passed
+1 💚 spotbugs 2m 40s the patch passed
+1 💚 shadedclient 25m 2s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 17m 44s /patch-unit-hadoop-common-project_hadoop-common.txt hadoop-common in the patch passed.
+1 💚 asflicense 0m 49s The patch does not generate ASF License warnings.
201m 6s
Reason Tests
Failed junit tests hadoop.crypto.TestCryptoCodec
hadoop.service.launcher.TestServiceInterruptHandling
hadoop.crypto.TestCryptoStreamsWithOpensslSm4CtrCryptoCodec
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3762/1/artifact/out/Dockerfile
GITHUB PR #3762
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell cc golang
uname Linux 26d74d675ec3 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 25a4ca7
Default Java Red Hat, Inc.-1.8.0_312-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3762/1/testReport/
Max. process+thread count 3137 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3762/1/console
versions git=2.9.5 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@rakeshadr
Copy link
Contributor

@PHILO-HE

There are few test failures, is that random failures and if yes please re-trigger the build.

@PHILO-HE
Copy link
Member Author

PHILO-HE commented Dec 9, 2021

These test failure looks not relevant to our patch. We can build again.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 44m 26s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 35m 35s trunk passed
+1 💚 compile 20m 34s trunk passed
+1 💚 checkstyle 1m 2s trunk passed
+1 💚 mvnsite 1m 38s trunk passed
+1 💚 javadoc 1m 47s trunk passed
+1 💚 spotbugs 2m 28s trunk passed
+1 💚 shadedclient 24m 57s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 1s the patch passed
+1 💚 compile 19m 49s the patch passed
-1 ❌ cc 19m 49s /results-compile-cc-root.txt root generated 18 new + 187 unchanged - 18 fixed = 205 total (was 205)
+1 💚 golang 19m 49s the patch passed
+1 💚 javac 19m 49s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 2s the patch passed
+1 💚 mvnsite 1m 35s the patch passed
+1 💚 javadoc 1m 40s the patch passed
+1 💚 spotbugs 2m 42s the patch passed
+1 💚 shadedclient 24m 44s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 17m 28s /patch-unit-hadoop-common-project_hadoop-common.txt hadoop-common in the patch passed.
+1 💚 asflicense 0m 50s The patch does not generate ASF License warnings.
201m 52s
Reason Tests
Failed junit tests hadoop.crypto.TestCryptoStreamsWithOpensslSm4CtrCryptoCodec
hadoop.crypto.TestCryptoCodec
hadoop.service.launcher.TestServiceInterruptHandling
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3762/3/artifact/out/Dockerfile
GITHUB PR #3762
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell cc golang
uname Linux bd1322e8e29f 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 25a4ca7
Default Java Red Hat, Inc.-1.8.0_312-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3762/3/testReport/
Max. process+thread count 1252 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3762/3/console
versions git=2.9.5 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@PHILO-HE
Copy link
Member Author

After a check, it looks the failed unit tests are not related to this patch. @rakeshadr, do you have any comment?

@rakeshadr rakeshadr merged commit 8e08f43 into apache:trunk Dec 14, 2021
@rakeshadr
Copy link
Contributor

+1 LGTM . Merged the changes to trunk.

Thank you @PHILO-HE for the contribution.

hotcodemacha pushed a commit to hotcodemacha/hadoop that referenced this pull request Dec 22, 2021
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants