-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HDFS-16014: Fix an issue in checking native pmdk lib by 'hadoop check native' command #3762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rakeshadr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1LGTM, thanks @PHILO-HE for the contribution.
Pending Build CI
|
💔 -1 overall
This message was automatically generated. |
|
There are few test failures, is that random failures and if yes please re-trigger the build. |
|
These test failure looks not relevant to our patch. We can build again. |
|
💔 -1 overall
This message was automatically generated. |
|
After a check, it looks the failed unit tests are not related to this patch. @rakeshadr, do you have any comment? |
|
+1 LGTM . Merged the changes to trunk. Thank you @PHILO-HE for the contribution. |
Description of PR
Fix an issue: 'hadoop check native' command doesn't correctly reflect the loading state of native pmdk lib when this lib is removed after building.
How was this patch tested?
We tested the validity of the patch on our lab machine. The test depends on the installation of pmdk lib.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?